Commit Graph

54 Commits

Author SHA1 Message Date
JinmingHu
395e9a0640
Test proxy & storage tests improvements (#4241) 2023-02-22 09:37:49 +08:00
Azure SDK Bot
2be39bcc8b
Increment package version after release of azure-security-attestation (#4345) 2023-02-08 01:44:55 +00:00
Anton Kolesnyk
08a267275d
Attestation February Release (#4326)
* Attestation February Release

* Changelog (repeat Beta changes)

* Update azure core minimum version dependency

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-02-07 16:13:04 -08:00
George Arama
3762c59552
Test proxy start (#4295)
* lll

* sss

* oipio

* vcvc

* enable test proxy start at test suite start for KV and storage , example created for attestation, we cannot find the base definitions for the test suites,

* Contrib

* clangs

* clangs

* test logs

* pipeline

* more clangs

* pipeline

* clang

* try try again

* try try again

* try again

* try again

* again

* update paths , moved to macro , call macro in target code

* core

* capitalization
2023-02-07 10:52:20 -08:00
Anton Kolesnyk
243fb4c58d
Compilation fixes for UWP (#4335)
* Compilation fixes for UWP

* More accurate condition

* Fix warnings

* Format files as vcpkg formats them; pull one change back from vcpkg

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-02-02 20:04:21 -08:00
Larry Osterman
f757bb06e7
Clean up tracing logic - prepare for new tracing functionality. (#4263)
- Made Context immutable (including marking the static ApplicationContext as const
- Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
- Changed Az.Namespace value from being the package name to being the service name.
- Change test SpanExporter to fully capture exported values rather than keeping references to the values.


Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-01-25 19:07:25 +00:00
Larry Osterman
a34b8d19a5
Add ApiView settings for existing packages. (#4226)
* Create ApiViewSettings for most existing packages

* Corrected name for blobs storage review name

* Added cspell settings for DCURL

* Create ApiViewSettings for most existing packages

* Corrected name for blobs storage review name

* Added cspell settings for DCURL

* ApiView settings changes for DataLake

* Renamed includeInternal to allowInternal; Added storage common; Fixed package names

* Fixed spelling error

* If there's an error accessing the site with no CRL checks, don't try it any more

* Stop checking example.com because it doesn't work

* Update sdk/attestation/azure-security-attestation/inc/ApiViewSettings.json

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* Update sdk/core/azure-core/inc/ApiViewSettings.json

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* Update sdk/keyvault/azure-security-keyvault-secrets/inc/ApiViewSettings.json

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-01-11 08:16:13 -08:00
Anton Kolesnyk
a70be339e7
Audit string comparisons (#4197)
* Audit string comparisons

* Mac fix

* !isxdigit()

* Rewrite condition + comment

* <3

* Clang-format

* 255

* Allow uppercase

* stoi() radix

* ShouldEncode()

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-03 11:16:54 -08:00
George Arama
ef4d41267f
Test proxy (#4118)
* start

* recording

* playback

* refactor, playback and record

* recordings for kv

* klklk

* open telemetry, identity

* attest

* all tests recorded except storage

* STORAGE RECORDINGDS

* some cleanup

* ignore result

* testproxy remade

* fiiine , do something with the result , goooosh

* install test proxy

* clang

* clang

* certs maybe

* cmake generate fix,

* start test proxy script

* start test proxy on env

* clang, move TP after build

* reregen

* certs

* sda

* dss

* allow insecure connections

* put back

* debug

* iuy

* try again

* ewew

* chmod

* try again

* update sanitizer

* output testproxy log

* sjhgasjgdajh

* folder

* worxy

* fix tests and log file

* format files

* clang format

* clang

* sa

* sa

* cleanup

* cspell

* oops

* remove redundant method

* tests

* put back original

* restore to 933486385a

* recordings

* remove storage values

* storage recordings

* disable non functioning tests

* remove core install of test proxy

* _LIVEONLY_ tests

* clang install when needed

* logs on condition

* skip tests

* revert cpp to original version

* quick test

* right that one

* one skip

* identity pushed

* maybe

* override

* clang

* clang

* attestetion

* keyvault

* reenable 20+ tests

* 5 tests left , lease related

* a bit of cleanup

* try now

* snitizers

* some fixes

* capitalization

* clang , cover, peakA

* WEIRD NAME THING ON WINDOWS

* storage recordings

* one more livee

* createappenddelete_liveonly

* CreateWithTags_LIVEONLY_

* try capitalization

* another onw

* maybe now

* all liveonly

* try restore before test

* typo

* condition

* clang and cc

* azure core ci

* qwqwq

* dsasdas

* cleanup1

* typo

* spaces

* cleanup2

* cleanup 3

* remove start proxy

* cleanup +1

* Update cmake-modules/TestProxyPrep.cmake

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update eng/scripts/Start-TestProxy.ps1

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update eng/scripts/Stop-TestProxy.ps1

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* PR comments

* clangs

* Update sdk/core/azure-core-test/src/test_proxy_policy.cpp

* build

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2022-12-13 10:58:19 -08:00
Anton Kolesnyk
c14775d5fb
Better TokenRequestContext initialization (#4169)
* Better TokenRequestContext initialization

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2022-12-07 20:25:22 -08:00
George Arama
1da78ce13e
Gtest timeout fix (#4078)
* PT1

* typo

* timeout

* gtest_1.12.1

* cspell isnore cmakelistst , it seem to freeze when checking these files

* timeout for cmake generate

* timeout for cmake generate p2

* timeout for cmake generate p3

* timeout for cmake generate p4

* timeout for cmake generate p5

* PR

* node 18

* nppm

* npm

* bug in cspell, freezed on txt files

* AntonComment extra space

* cspell
2022-11-02 15:46:38 -07:00
Azure SDK Bot
02e233c7a3
Increment package version after release of azure-security-attestation (#4018) 2022-10-11 21:06:21 -07:00
Ahson Khan
f99e9d014f
Updated attestation change log to add periods for consistency (#4016)
* Updated attestation change log to add periods for consistency

* Update wording for a breaking change.

* Add back-ticks.
2022-10-11 23:45:20 +00:00
Larry Osterman
2bc639432c
Attestation October (#4017) 2022-10-11 23:34:30 +00:00
Anton Kolesnyk
dd2d050ec8
Update Attestation readme.md (#3991) 2022-10-04 16:53:55 -07:00
Anton Kolesnyk
cc64ffae58
Upadte Attestation changelog.md (#3992) 2022-10-04 15:00:00 -07:00
Peng Li
52f9437adb
Update AttestationClient::AttestTpm API to match existing AttestOpenEnclave and AttestSgxmEnclave (#3928)
* Fix broken link and typo in contributing.md

* Use vector<uint8_t> for attest instead of strings

* remove options

* fix comments

* update release version

* remove versionig

* revert changelog

* add the change

* update comment

* Update sdk/attestation/azure-security-attestation/CHANGELOG.md

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>

* fix formatting

* address pr comment

* fix formating

* update a comment

* remove the attest tpm comment

Co-authored-by: Peng Li <pengfeli@microsoft.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
2022-09-19 16:01:44 -07:00
Jamie Magee
deb847e59f
Add $schema to cgmanifest.json (#3918)
Co-authored-by: Jamie Magee <jamie.magee@microsoft.com>
2022-09-13 08:50:38 -07:00
Ahson Khan
593437b8f2
Update attestation core vcpkg dependency to latest GA version that is required. (#3830)
* Update attestation core vcpkg dependency to latest GA version that is required.

* Update vcpkg config.cmake to match the dependency version needed.
2022-07-15 10:06:16 -07:00
Azure SDK Bot
0c12c92311
Increment package version after release of azure-security-attestation (#3810) 2022-07-07 16:26:24 -07:00
Larry Osterman
2e6e46792a
Azure Security Attestation 1.0 release (#3796)
* Attestation 1.0

* Updates
2022-07-07 19:15:03 +00:00
Larry Osterman
9c144c7301
Version->ApiVersion (#3805)
* Version->ApiVersion

* Don't remember credentials they're not needed
2022-07-07 11:51:58 -07:00
Larry Osterman
2bf0d38236
Updated attestation SDK to remove ServiceVersion extensible enumeration (#3799)
Jeff has pointed out that the current practice in the SDK of having a ServiceVersion which contains the current API versions of the service (for instance:

```c++
  class ServiceVersion final {
  public:
    explicit ServiceVersion(std::string version) : m_version(std::move(version)) {}
    AZ_STORAGE_QUEUES_DLLEXPORT const static ServiceVersion V2018_03_28;
    AZ_STORAGE_QUEUES_DLLEXPORT const static ServiceVersion V2020_10_01;
  };
)

```
Has a problem because the `ServiceVersion` construct has an implication that each of the `ServiceVersion` values listed is fully supported by the SDK.

The reality is that the SDK client team only tests the most recent API version listed in the SDK (the value which is the default version listed in the `ServiceClient` constructor).

How do we resolve this issue?

There are a few possible solutions that we’ve explored:
1)	Test all the API versions listed in the `ServiceVersion` enumeration.
2)	Remove the unsupported values from the `ServiceVersion` enumeration.
3)	Remove the `ServiceVersion` enumeration
4)	Remove the ability to set the API version at all.

Each of these solutions has some fairly significant drawbacks.

1)	Test all the API versions listed.
The core problem with this is that the SDK team is small and adding tests to support every possible API version is going to be prohibitively expensive.
2)	Remove the unsupported values from the `ServiceVersion` enumeration.
This is a breaking change and it means that moving to a new API version requires a breaking change to the SDK, even if the changes between API versions is strictly additive.
3)	Remove the ServiceVersion enumeration.
This is also a breaking change for shipping SDKs (specifically KeyVault and Storage Queues). However, it is a one-time breaking change and we don’t have evidence of customers actually using the feature.
4)	Remove the ability to set the API version at all.
Having *some* mechanism to set the API version is an important “escape hatch” which will allow customers to specify a specific API version even if that API version is not fully supported.

After discussing this a LOT, [@Ahson Khan](mailto:ahkha@microsoft.com), [@Rick Winter](mailto:Rick.Winter@microsoft.com), [@Jeffrey Richter](mailto:jeffreyr@microsoft.com), [@George Arama](mailto:George.Arama@microsoft.com), and [@Larry Osterman](mailto:Larry.Osterman@microsoft.com) came to the conclusion that we should probably take option #3, but leave the ClientOptions.Version value as a std::string.
2022-07-06 09:29:55 -07:00
Larry Osterman
99f45a5f18
Enable Distributed Tracing for Attestation SDK client. (#3706)
* Implement tracing for Attestation and Template services

* Pipeline no longer requires service name if opting into distributed tracing; enable tracing in attestation service

* Generate user-agent header from request activity policy

* Added test to catch the redacted header regression

* Updated documentation to reflect API surface changes
2022-06-08 11:40:56 -07:00
Azure SDK Bot
42e284dc14
Increment package version after release of azure-security-attestation (#3717) 2022-06-08 09:40:58 -07:00
Larry Osterman
7e8065a2e3
Removed empty sections in changelog (#3718) 2022-06-07 11:39:48 -07:00
Larry Osterman
8ec7a9958a
Removed version>= fields for openssl in vcpkg.json files (#3705) 2022-06-03 16:43:08 -07:00
Larry Osterman
bea147905a
Added ability to create instance with pointer (#3698)
* Added ability to create instance with pointer

* Pull request feedback
2022-06-03 00:59:20 +00:00
Larry Osterman
6b903d0b3f
Attestation 1.0.0 GA Release (#3693)
* Prepare attestation for release

* removed references to RetrieveResponseValidationCollateral from docs

* Added C++ SDK team as owners of attestation SDK

* Added Ahmad from attestation team to attestation owners

* Removed dead API; switched attestation back to beta-3
2022-06-02 12:13:12 -07:00
Larry Osterman
0fd02674fe
Moved attestation factory back to static method on attestation class … (#3682)
* Moved attestation factory back to static method on attestation class and return a concrete type not a pointer

* Fixed factory in readme file
2022-06-01 18:33:59 +00:00
Larry Osterman
7c93854125
Complete the initial implementation of OpenTelemetry (#3677)
* Added telemetry support for HTTP pipeline elements

* Finish OpenTelemetry implementation

* clang-format and added doxygen comments
2022-05-31 10:57:32 -07:00
Larry Osterman
745091d01c
Split out attestation client factory into separate class (#3654)
* Split out attestation client factory into separate class

* Updated readme; clang-format

* Final set of API review changes

* Replaced () constructors with {} constructors
2022-05-23 15:54:57 -07:00
Anton Kolesnyk
80cf3d09fd
Update all-inclusive headers, and CMakeFiles for including all headers (#3640) 2022-05-17 20:45:46 -07:00
Azure SDK Bot
c0e92e4f92
Increment package version after release of azure-security-attestation (#3636) 2022-05-11 14:23:18 -07:00
Larry Osterman
44af947141
Prepare Attestation SDK for May Release. (#3625)
* Prepare attestation for May release

* Removed some noise from changelog
2022-05-05 16:01:23 -07:00
Larry Osterman
f8ced21a1a
Remove version pin for OpenSSL (#3610)
* Remove version pin for OpenSSL

* Gratuitous change to trigger CI pipelines
2022-05-03 16:05:36 -07:00
Larry Osterman
a2d975c7d4
API Review Feedback for Attestation SDK (#3543)
* API Review Feedback for Attestation SDK

* Updated changelog to reflect API Review updates
2022-05-03 13:46:35 -07:00
Daniel Jurek
140e05baa7
Migrate to matrix generator (#3553)
* Represent existing matrix in json
* Use new matrix
* Move to stage
* Cloud configuration
* MaxParallel
* DependsOn
* Quote CtestRegex
* Use template for cmake generate tests
* Template name mappings
* Formatting, parameters
* Remove duplicate bypass-local-dns.yml
* Enable Location override
* Add Location
* Add spelling words
* Use Ubuntu 20 where the name specifies Ubuntu 20
* Apply suggestions from code review

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

* PR feedback
* fix storage sample
* Matrix documentation

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
2022-04-26 14:34:23 +00:00
Azure SDK Bot
b16ff00d98
Increment package version after release of azure-security-attestation (#3505) 2022-04-05 23:35:21 +00:00
Larry Osterman
45b8553979
Removed one more Azure Core 1.2.0 dependency (#3498)
* Update vcpkg.json

* Removed Core 1.2.0 dependency
2022-04-01 11:23:59 -07:00
Larry Osterman
b61cd1b91d
Updated cmakelists to include core 1.5 requirement (#3494) 2022-03-31 16:35:54 -07:00
Larry Osterman
75d0d74486
Update vcpkg.json (#3493) 2022-03-31 17:03:21 +00:00
Larry Osterman
731a4e632b
Prepare for C++ attestation release (#3481)
* Prepare for C++ attestation release
2022-03-29 17:14:41 -07:00
Victor Vazquez
835f156af9
Vcpkg manifest and binary caching (#3329)
* binary cache and manifest

* update packages

* udpate

* add cache to private pipeline

* next try

* aver

* other

* again

* aver quick

* more

* this way

* again

* one more

* print

* test

* use depend

* more deps

* dep

* Apply suggestions from code review

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* updated to use group variable

* update identity

* end line

* Update vcpkg.json

* Apply suggestions from code review

* cspell

* remove comment

* updates

* make cache mode depend on SAS env var

* map env var only for internal pipelines

* other approach

* what about this

* and this

* try

* amd

* another

* extra step

* typo

* override for internal

* use default succeded

* azure core update manifest

* a

* run cmake-generate nightly as well

* check for SAS

* check cache

* no secret

* fix is secret

* pass explicit

* use secret all the time

* char

* One more

* export

* echos

* last

* array

* remove question

* ok

* weird

* use account key

* substring

* VCPKG_BINARY_SOURCES

* Add module installation

* task:

* Correct pathing for module

* update source gen

* format

* update spelling

* IsWindoows

* Use pwsh

* Cannot clobber with PSModule-Helpers. Attempt plain install

* Attempt plain install

* Revert unnecessary change to Update-DocsMsToc.ps1

* template ready

* curl is required on Windows as well for some CI gates

* attestation

* fix format

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2022-03-24 09:11:30 -07:00
Larry Osterman
af7281ef1a
Updated and add samples for Attestation service. (#3448)
* Moved samples around to meet new recommendations; added a couple of additional tests.
* Reworked attestation to include RetrieveAttestationValidationCollateral
* Attestation sample readme updates
* TPM doesn't need to retrieve response validation collateral
* Added cautionary warning about the dangers of overriding the TearDown method from inside a test case
* Added attestation team members to codeowners for attestation SDK
* Remove CODEOWNERS from cspell checks
* Don't hold a lock across retrieving the signers over the network
* Updated snippets in readme; clang-format
2022-03-22 14:29:03 -07:00
Victor Vazquez
feaaf0b414
Update release mode windows + samples (#3451)
* changes

* vs generator

* use macro

* release and samples

* add target to build smoke test

* revert

* reuse macro for samples

* extra legs for samples only

* storage connection string

* format

* order and macro

* update

* samples

* missing
2022-03-22 01:39:39 +00:00
George Arama
13175a4f41
Openssl1.1.1 (#3457)
* open ssl 1.1.1n

* manifests and vcpkg for attestation

* opensll - > git

* oops git

* set 1.1.1n as min version
2022-03-21 13:59:20 -07:00
George Arama
282ed53068
open ssl 1.1.1n (#3447)
* open ssl 1.1.1n

* manifests and vcpkg for attestation

* opensll - > git

* oops git
2022-03-21 11:17:21 -07:00
Larry Osterman
abb6ac0c9a
Add Policy Management Certificates APIs (#3417)
* Added GetPolicyManagementCertificates

* Added Add and Remove policy certificate

* Added support for Tpm attestation

* Moved TPM to attestation service specific section

* Added support for validation callback

* Updated RequestFailedException documentation
2022-03-16 15:12:33 -07:00
Larry Osterman
8672f985aa
Create Extendable Enumeration base class (#3421)
* Created extendableenumeration class

* Convert attestation to use extendable enumeration; added test for extendable enumerations

Co-authored-by: Casey Carter <cartec69@gmail.com>
2022-03-11 02:37:31 +00:00