Commit Graph

884 Commits

Author SHA1 Message Date
Ahson Khan
3d7eaddb9d
Use new macros in existing surface area, so that classes marked as final don't have virtual methods. (#5389)
* Use new macros in existing surface area, so that classes marked as final don't have virtual methods.

* Update doc comments.

* Use DOXYGEN_PREDEFINED to expand only the macros we want expanded.

* Add the compile definition for more projects.

* Address PR feedback.

* Make TestableTokenCache a friend class of TokenCache.
2024-02-29 20:48:12 -08:00
Morten Ofstad
93d8c12e4c
Fix use of namespace qualifiers that have not been explicitly introduced (#5371)
* Fix use of namespace qualifiers that have not been explicitly introduced.

* Format (sort usings alphabetically)

* Update CHANGELOG.md

* Update cspell.json

---------

Co-authored-by: Morten Ofstad <morten.ofstad@bluware.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-02-29 02:51:42 +00:00
Larry Osterman
c707769604
Updated tests to support -UserAuth test resources switch to enable non-corpnet access. (#5387)
* Updated tests to support -UserAuth test resources switch to enable non-corpnet access.

* Try setting sample environment variables in sample script pipeline
2024-02-28 01:36:54 +00:00
Anton Kolesnyk
00b30e3d86
AMQP: do not use scope.MinimumExpiration when getting SAS Token (#5376)
* AMQP: do not use scope.MinimumExpiration when getting SAS Token

* Remove unused parameters

* Match style

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-23 15:11:40 -08:00
Larry Osterman
aadd25dcd1
Reworked EventHubs Stress test to export information to OpenTelemetry (#5370)
# Significant rewrite of Eventhubs stress test.

## Cleaned up implementation of EventHubs stress/reliability test

* Reworked stress test layout to isolate stress test implementation from stress deployment elements.
* Added ability of stress test scenarios to be independently configured.
* Rewrote stress test app to be closer to the Go equivalent app.
* added apparg.hpp for command line parsing
* added scope_guard to test for scope_guard implementation.

## Added close methods to Consumer client and Producer client.

They don't do much currently, but will eventually.

## AI Generated summary of pull request

This pull request primarily focuses on the `azure-core-amqp` and `azure-messaging-eventhubs` packages, introducing changes to improve code efficiency and maintainability. The most significant changes include the removal of unnecessary `#include` directives in various files in the `azure-core-amqp` package, the addition of `Close` methods in `consumer_client.hpp` and `producer_client.hpp` in the `azure-messaging-eventhubs` package, and modifications to the `cgmanifest.json` files in the `azure-messaging-eventhubs-checkpointstore-blob` and `azure-messaging-eventhubs` directories.

Removal of unnecessary `#include` directives:

* [`sdk/core/azure-core-amqp/src/amqp/claim_based_security.cpp`](diffhunk://#diff-5acd7049cef5955540cc4253f264207e5a7d2701612e148c736ca5781e69d224L12-L14): Removed unnecessary `#include` directives for `iostream` and `sstream`.
* [`sdk/core/azure-core-amqp/src/amqp/connection.cpp`](diffhunk://#diff-fc3a6e5b11f1254c4fd344bcd1846c83ad4ca8e2a8a23b7db0657c2846f43937L18): Removed unnecessary `#include` directive for `azure/core/url.hpp`.
* [`sdk/core/azure-core-amqp/src/amqp/connection_string_credential.cpp`](diffhunk://#diff-14cf130dc5f0b51f698cca57724b733591d48fad0e5beb4745fc1cd78cbdaa72L7-L20): Removed unnecessary `#include` directives for `azure/core/amqp/internal/models/amqp_protocol.hpp`, `azure_c_shared_utility/azure_base64.h`, `azure_c_shared_utility/buffer_.h`, and `iostream`.
* [`sdk/core/azure-core-amqp/src/amqp/link.cpp`](diffhunk://#diff-249643f29ca2c0b1226e9d22ce90be83c77105f55221a1092fb605a5c7ead356L10-L21): Removed unnecessary `#include` directives for `azure/core/amqp/internal/message_receiver.hpp`, `azure/core/amqp/internal/message_sender.hpp`, `azure/core/amqp/internal/models/messaging_values.hpp`, and `azure_uamqp_c/amqp_definitions_sequence_no.h`.
* [`sdk/core/azure-core-amqp/src/amqp/management.cpp`](diffhunk://#diff-b03544340ff264961e045648c2c274dde9fa7ceb33b07b0c41a708128e28d40fL6-L16): Removed unnecessary `#include` directives for `azure/core/amqp/internal/connection.hpp`, `azure/core/amqp/internal/session.hpp`, and `azure_uamqp_c/amqp_management.h`.

Addition of `Close` methods:

* [`sdk/eventhubs/azure-messaging-eventhubs/inc/azure/messaging/eventhubs/consumer_client.hpp`](diffhunk://#diff-fad00d7bec0f12ef5e7d36387e866ab5291c6f5f57568845dfabe3f23320c899R152-R159): Added a `Close` method to the `ConsumerClient` class.
* [`sdk/eventhubs/azure-messaging-eventhubs/inc/azure/messaging/eventhubs/producer_client.hpp`](diffhunk://#diff-cba1fbd1d786b763c27123a2284476e1cc8093753abe6e3a6af9ca78aae4d594R96-R113): Added a `Close` method to the `ProducerClient` class.

Modification of `cgmanifest.json` files:

* [`sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/cgmanifest.json`](diffhunk://#diff-465b096c14ed240a8f14180f16e0924e3df69bd1c95934dca435c0b3c97468a0R1-R37): Added a new `cgmanifest.json` file specifying development dependencies.
* [`sdk/eventhubs/azure-messaging-eventhubs/cgmanifest.json`](diffhunk://#diff-f3e86a1f7be148625ac80b2151504461f3faff4d0564db588c6df9d0d9eb0986R1-R48): Added a new `cgmanifest.json` file specifying development dependencies.
* 

---------

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2024-02-22 20:41:18 -08:00
George Arama
8ef815dc6a
Install test proxy and enable all tests (#5365)
* mroe quotes

* dssf

* compact the tests in the proper folder

* 2 more tests

* eqwq

* enabled all except http

* endline

* fhg

* oops

* new teests

* update

* update defaults

* hdg
2024-02-21 10:58:35 -08:00
Azure SDK Bot
c0c7f88e65
Increment package version after release of azure-core (#5366) 2024-02-16 17:13:53 -08:00
George Arama
2a9934a596
Core perf tests consolidation (#5363)
* mroe quotes

* dssf

* compact the tests in the proper folder

* 2 more tests

* eqwq

* enabled all except http

* endline
2024-02-16 15:15:36 -08:00
Anton Kolesnyk
46fe50212c
Azure Core 1.11.2 Release (#5360)
* Azure Core 1.11.2 Release

* Update release date to 2/16

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-16 15:14:13 -08:00
George Arama
73bb6c63c1
Winhttp flaky test (#5356)
* mroe quotes

* dssf

* attempt 2

* updated test and logs

* clang

* update PR

* changelog update

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

---------

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-02-15 15:55:03 -08:00
Anton Kolesnyk
9271d13542
Guard against Windows' min/max macros (#5348)
* Guard against Windows' min/max macros

* Add NOMINMAX and LEAN_AND_MEAN + clang-format

* clang-format

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-13 13:41:34 -08:00
Larry Osterman
0229d0a3b3
Multithreaded support for Eventhubs management family of APIs (#5315)
* Enabled multithreaded calls to eventhubs management APIs

* Added partition client properties tests, removed unused variables in consumer client tests

* Restructured properties APIs in eventhubs to simplify producer client and consumer client implementations

* Fixed test crash in LinkAttachDetach AMQP test

* Added test cases for management authn failures

* Don't emit body contents in AmqpMessage insertion operator

* Don't take numeric value parameters by value to ostream insertion operators

* Updated eventhubs dependency to match reality

* Added value based tests for enumeration stream inserters
2024-02-09 14:22:28 -08:00
George Arama
50cc742865
Json test (#5324)
* mroe quotes

* dssf

* sqa

* Json test p1

* qw

* re

* pr build

* cast part 2

* ew

* jj
2024-02-07 12:20:52 -08:00
Anton Kolesnyk
025c06715c
Retroactively update AMQP's changelog (#5321)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-03 04:34:45 +00:00
Anton Kolesnyk
111ec80478
Update Azure Core changelog after #5308 (#5317)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-02 23:32:07 +00:00
Mykhailo Chelnokov
79cc06d004
Move the connection back to the connection pool when HTTP error 404 was received (#5308)
* Move the connection back to the connection pool when HTTP error 404 was received

* Use symbolic name for 404 status code
2024-02-02 14:10:58 -08:00
Azure SDK Bot
807b6c946a
Increment version for core releases (#5316)
* Increment package version after release of azure-core

* Increment package version after release of azure-core-amqp
2024-02-02 22:06:37 +00:00
George Arama
1689a00df9
Pipeline tests (#5310)
* mroe quotes

* dssf

* sqa

* pipeline and policies

* PR comments

* cast int
2024-02-02 13:03:38 -08:00
George Arama
4f6cc88004
Http Transport perf test (#5309)
* mroe quotes

* dssf

* sqa

* first identity test no caching

* cache no cache

* cleanup cache shortcircuit

* some cleanup

* http test 1

* Update sdk/core/perf/src/base_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR comments

* remove cache option

* wqq

* dsd

* saa

* wqq

* dfs

* clang

* http get post curl winhttp

* Update sdk/core/perf/inc/azure/perf/dynamic_test_options.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* rtter

* PR comments

* PT comments

* clang

* http transport test

* Update sdk/core/perf/src/base_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR comments

* remove cache option

* wqq

* dsd

* saa

* wqq

* dfs

* clang

* http get post curl winhttp

* rtter

* PR comments

* PT comments

* clang

* http transport test

* PR comments

* clangs

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-02-02 11:28:26 -08:00
Anton Kolesnyk
901bd298e4
Azure Core February Releases (#5312)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-02 10:23:58 -08:00
Larry Osterman
092d6bcc3b
Fixed nightly CI pipeline build error (#5311)
* Fixed nightly CI pipeline build error

* printf format string errors
2024-02-02 10:10:09 -08:00
Anton Kolesnyk
9b79205b68
Azure Core February Releases (#5304)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-02-01 12:54:29 -08:00
George Arama
070c7e94db
Step 1 in adding (more)perf tests for Core and Identity. (#5300)
* mroe quotes

* dssf

* sqa

* first identity test no caching

* cache no cache

* cleanup cache shortcircuit

* some cleanup

* Update sdk/core/perf/src/base_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR comments

* remove cache option

* wqq

* dsd

* saa

* wqq

* clang

* Update sdk/core/perf/inc/azure/perf/dynamic_test_options.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR comments

* PT comments

* clang

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-02-01 10:47:02 -08:00
Larry Osterman
c2f189695c
Removed dead script (#5306) 2024-01-31 23:13:08 +00:00
Larry Osterman
27aab786c2
AMQP Session related fixes. (#5299)
* Implemented connection handle table to fix half closed session problem

* Correctly handle session begin after connection is open

* Split out amqp settle mode to separate header; added test coverage for AMQP Transfer and Detach performatives

* Use absolute path for settle mode header
2024-01-30 15:32:58 -08:00
Larry Osterman
47bf038701
Ported uAMQP bug fix to C++ repo (#5291) 2024-01-24 13:34:11 -08:00
Larry Osterman
f109f63f4e
Synchronous AMQP Close (#5281)
* First cut at blocking close

* Removed synchronous ifdefs
2024-01-18 12:54:23 -08:00
Larry Osterman
32e774f2ed
Changelog entry for winhttp bug fix (#5277)
* Changelog entry for winhttp bug fix

* Updated changelog with further suggestions
2024-01-17 13:21:13 -08:00
Larry Osterman
3bff843704
Attempt to diagnose WinHTTP CI pipeline errors. (#5259)
* Fixes for CVE-2024-21646

* Added note about this fix to CHANGELOG.md

* Tweaks to investigate CI pipeline error
2024-01-17 12:02:42 -08:00
Azure SDK Bot
2e343802cd
Increment version for core releases (#5255)
* Increment package version after release of azure-core

* Increment package version after release of azure-core-amqp
2024-01-11 15:43:19 -08:00
Anton Kolesnyk
03de1fbaa4
Core-Core (GA) + Core-AMQP (Beta) + Event Hubs (Beta) January Releases (#5243)
* Core-Core + Core-AMQP + Event Hubs January Releases

* Update CHANGELOG.md

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-01-11 13:30:42 -08:00
Larry Osterman
23ecf87ecb
Fixes for CVE-2024-21646 (#5251)
* Fixes for CVE-2024-21646

* Added note about this fix to CHANGELOG.md
2024-01-11 11:33:25 -08:00
Ahson Khan
dece333752
Add a remark in CAInfo doc comment mentioning it is Linux only. (#5248) 2024-01-11 19:23:35 +00:00
George Arama
e69559f45e
Options UT (#5249)
* Options Http Enum add

* spaces

* options UT

* remove Options

* Revert "remove Options"

This reverts commit 0da5d2c1f57133c22723208d6feb2c925e7f8103.
2024-01-11 10:11:01 -08:00
Ahson Khan
88242f3cf1
Make the CAPath option available on all OSes and change to throw on runtime on non-linux. (#5207)
* Make the CAPath option available on all OSes and change to throw on
runtime on non-linux.

* Address PR feedback, update test, and let curl fail on unsupported
platforms.
2024-01-10 17:16:50 -08:00
George Arama
7eeb60960c
Options Http Enum add to Core (#5246)
* Options Http Enum add

* spaces
2024-01-10 12:26:37 -08:00
Ben Broderick Phillips
e5e675440b
Move squid image to registry mirror (#5218)
* Move squid image to registry mirror

* Add comments regarding private registry
2023-12-19 18:32:01 +00:00
Anton Kolesnyk
e328665588
Update cspell words and exclusions (#5231)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-12-15 17:41:11 -08:00
Anton Kolesnyk
15716714a4
Fix spelling errors (#5230)
* Fix spelling errors

* Exclusion list

* More updates for the exclusion list

* Even more updates for the exclusion list

* And even more updates for the exclusion list

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-12-15 14:17:59 -08:00
Larry Osterman
faeb832f8a
Initial cut at snippet generation tool. Also updated KeyVault Secrets readme to use snippets as a working proof of concept. (#5213)
* First cut at snippet generation - markdown files only for now.

* Removed trailing blank lines in updated file

* Use snippet generator for keyvault snippets
2023-11-30 19:40:30 +00:00
Anton Kolesnyk
c6fecca8e7
Remove unnecessary condition (#5210)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-29 12:52:45 -08:00
Anton Kolesnyk
1b3b872b10
Move Azure::Core::_internal::UniqueHandleHelper to _detail (#5177)
* Move Azure::Core::_internal::UniqueHandleHelper to _detail

* Linux build fix

* More Linux fixes and clang-format

* Get back the @cond

* Revert one more @cond removal

* Linux fix: include necessary header

* Undo unnecessary clang-format

* Clang-format, again

* Trigger CI

* Trigger CI

* amqps, amqpvalue

* Update cspell.json

* Update curl.cpp

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-29 08:39:04 -08:00
Anton Kolesnyk
73399d7325
Change samples to use DefaultAzureCredential (#5183)
* Change samples to use `DefaultAzureCredential`

* Missed instance

* Oaep

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-29 16:07:40 +00:00
Anton Kolesnyk
217b3cd8a5
Add thread safety for KeyVaultChallengeBasedAuthenticationPolicy (#5189)
* Add thread safety for `KeyVaultChallengeBasedAuthenticationPolicy`

* Copy constructor

* Add comment

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-29 07:37:15 +00:00
Anton Kolesnyk
135e746243
BearerTokenAuthenticationPolicy to use shared_lock in case no refresh is needed (#5188)
* `BearerTokenAuthenticationPolicy` to use shared_lock in case no refresh is needed

* Copy constructor

* Update bearer_token_authentication_policy.cpp

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 21:29:54 +00:00
Anton Kolesnyk
24ecd16308
Fix some spelling errors (for some PRs that are currently in review) (#5202)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 10:49:58 -08:00
Anton Kolesnyk
fbf58139f7
Nullable::Emplace() to set HasValue() (#5178)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 08:10:52 +00:00
Anton Kolesnyk
ee4be19b3f
URL: avoid double slash at the start of the path (#5187)
* URL: avoid double slash at the start of the path

* Remove unnecessary change

* More test coverage

* Changelog

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-27 23:03:27 -08:00
Larry Osterman
a318d3756f
Make cspell checks case sensitive. Fixes #5198. (#5199)
* Make cspell checks case sensitive

* Add .vscode to path filter for CI pipeline

* Fixed some spelling errors
2023-11-27 22:04:25 +00:00
Anton Kolesnyk
6da4d9649d
FIx typos (#5185)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-27 13:55:27 -08:00