Commit Graph

443 Commits

Author SHA1 Message Date
Azure SDK Bot
53a74b0299
Increment package version after release of azure-core (#6332) 2025-01-11 04:04:43 -08:00
Ronnie Geraghty
b391d65809
Docs links coversion: docs.microsoft.com -> learn.microsoft.com (#6276)
* Docs links coversion: docs.microsoft.com -> learn.microsoft.com
Some markdown formatting

* Adding "msrc" to cspell words

* Undoing things auto formatter did

* Appling Ahson's suggestions
2024-12-16 09:32:19 -08:00
Anton Kolesnyk
bef420162e
Fix typos (#6234)
* Fix typos

* Fix name collision

* Re-trigger CI

* Re-trigger CI

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-17 23:06:28 -08:00
Anton Kolesnyk
384552adff
Remove unused includes (#6209)
* Remove unused includes

* Fixes

* move statics instantiation into cpp

* clang-format

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-14 14:41:53 -08:00
Azure SDK Bot
7469049097
Increment package version after release of azure-core (#6218)
---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-13 17:15:19 -08:00
Anton Kolesnyk
b74d9c36be
Minor code cleanups (3) (#6179)
* Minor code cleanups (3)

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-11 15:36:58 -08:00
Larry Osterman
9770fb77dc
Implement mTLS support in WinHTTP transport. (#6131)
* Very preliminary mTLS implementation

* Tests for TLS client certificate

* Tested mTLS functionality

* Added changelog entry; updated PCCERT_CONTEXT using declaration to be more succinct.
2024-11-06 20:03:08 +00:00
Anton Kolesnyk
868a14f4d8
Minor code cleanups 2 (#6171)
* Minor code cleanups

* Clang-format

* Adjust line coverage target

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-05 10:12:13 -08:00
Anton Kolesnyk
daeff2ce9e
Minor code cleanups (#6169)
* Minor code cleanups

* Update claims_based_security_impl.hpp

Undo UniqueAmqpCbsHandle removal - it is right, but will create problems for Larry working in a feature branch when merging it back.

* Update claims_based_security_impl.hpp

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-04 19:58:06 +00:00
Azure SDK Bot
54872294f9
Increment package version after release of azure-core (#6168)
---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-01 16:21:12 -07:00
Anton Kolesnyk
0180c8ee5c
HttpShared::GenerateUserAgent() (#6163)
* Rename UserAgentGenerator

* Update includes

* Clang-format

* Move GenerateUserAgent() to HttpShared class

* Update invocations

* Update invocations

* Clang-format

* Drop unnecessary include

* Update release dates

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-01 14:07:45 -07:00
Anton Kolesnyk
99e0895a5d
Move UserAgentGenerator to _internal (#6067)
* Move UserAgentGenerator to _internal

* Clang-format

* Update release date to November release (Core)

* Update release date to November release (EventHubs)

* _MSVC_LANG

* Move comment up

* Add /Zc:__cplusplus when building the SDK, and add unittest

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-10-31 10:00:12 -07:00
Ahson Khan
064fcad72f
Set token to be expired if response comes back as unauthorized, within BeareTokenAuthenticationPolicy. (#6151)
* Set token to be expired if response comes back as unauthorized.

* Add CL entry.

* Update CL.

* Use trc MinimumExpiration to invalidate the credential's token cache.

* Add test.

* Address PR feedback.

* Remove comment as it is no longer relevant.

* Use initializer list syntax to see if posix compilers are okay with that.

* Keep the bool field as non-atomic.

* Revert "Keep the bool field as non-atomic."

This reverts commit 1b8c7622d5234b010bb0a4eb5db8a436de5a2adf.
2024-10-30 14:00:42 -07:00
Ahson Khan
8f8d24280f
Fixed warning for an unused function in curl.cpp when building the SDK using a version of libcurl older than 7.77.0 (#6073) 2024-10-07 16:28:25 -07:00
Azure SDK Bot
4722e3df3c
Increment package version after release of azure-core (#6062)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-10-03 19:50:04 -07:00
Anton Kolesnyk
1289063cc2
Azure Core October GA Release (#6053)
* Azure Core October GA Release

* Change to re-trigger CI

* Undo change, still re-trigger CI

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>

* Also update wording in the previous release

* Spelling

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
2024-10-03 11:29:28 -07:00
Ahson Khan
5a6176706d
Add basic input validation to ResourceIdentifier for ensuring the prefix match what is expected. (#6056)
* Initial verification and tests.

* Simplify validation checks to what's needed.

* Update changelog entry.

* Fix typo and disable cspell for a test line.

* Address PR feedback.
2024-10-02 06:42:01 +00:00
Ahson Khan
23729124bd
Make the HTTP transport behavior consistent between WinHTTP and libcurl by disabling automatically following redirects on Windows. (#6018)
* Make the HTTP transport behavior consistent between WinHTTP and libCurl by disabling automatically following redirects on Windows.

* Re-enable APC test.

* Fix casing in changelog.

* Add http bin based unit test and fix typo in doc comment for curl.

* Update test name to avoid 'dont'

* Fix typo.
2024-09-24 13:14:08 -07:00
Azure SDK Bot
da2ea2113d
Increment version for core releases (#5980)
* Increment package version after release of azure-core-amqp

* Increment package version after release of azure-core

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-09-12 11:22:35 -07:00
Ahson Khan
c3265d3e5b
Fix input validation check for TimeFractionFormat in the DateTime ToString method (#5927)
* Fix input validation check for TimeFractionFormat in the DateTime ToString() method.

* Add changelog entry.

* Use switch-case instead of static casting the enum values.

* Address CL PR feedback.

* Fix the features added CL to put ResourceIdentifier in the right release.

* Address PR feedback - use type traits
2024-09-10 14:35:07 -07:00
Anton Kolesnyk
6ae78faec8
Update Uuid parameter name, and improve tests (#5943)
* Update Uuid parameter name, and improve tests

* Update sdk/core/azure-core/inc/azure/core/uuid.hpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2024-08-27 18:40:54 -07:00
Anton Kolesnyk
ee0c7565df
Uuid: add default ctor and Parse() (#5935)
* Uuid: add default ctor and Parse()

* Fix merge, integrate better

* nano-optimization for IsNil()

* Changelog

* Pedantism

* GCC fix

* GCC fix (include <stdexcept>)

* PR feedback

* Update sdk/core/azure-core/test/ut/uuid_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Comments for bad tests

* Add doxygen comments

* One more constexpr, and clang-format

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2024-08-23 23:15:24 -07:00
Ahson Khan
d8b555a670
Optimize Uuid.ToString() by avoiding using sprintf to do the basic string transformation (#5925)
* Optimize Uuid.ToString() to use a cached value on multiple calls.

* Add tests which call ToString() multiple times.

* Optimize Uuid::ToString by avoiding using sprintf.

* Assert all byte values will fit into a hex character.

* Update comment in test.
2024-08-22 17:34:17 -07:00
Ahson Khan
54a7bc363b
Add support for providing an object ID to ManagedIdentityCredential. (#5910)
* Add support for providing an object ID to ManagedIdentityCredential.

* Update cspell checks.

* Add support for creating a Uuid from a string, and use that as the
MICred overload for objectId.

* Add a remark comment to make it clear that object and client ids are not interchangeable.

* Remove the non-const ToString() as that isn't required.

* Update tests to use valid hex Uuid values.

* Use a discriminated union design approach with a ManagedIdentityType
object and ManagedIdentityIdType enum.

* Fix typo and remove Uuid CreateFromString.

* Address PR feedback.

* Update doc comment.

* Update comments and exception message to consistently use hyphens
between user/system and assigned.
2024-08-16 20:47:05 -07:00
George Arama
70dc0ebecb
Log policy extra headers (#5868)
* log policy extra headers

* failing test

* adding back WWW-Authenticate

* changelog update

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2024-08-07 17:40:37 +00:00
Azure SDK Bot
cd385362f9
Increment package version after release of azure-core (#5870)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-08-01 22:38:35 +00:00
Robert Schulze
401b97e0ac
Remove unneeded <regex> includes (#5851)
* Remove unneeded <regex> includes

* Fix build (hopefully)
2024-07-31 13:07:47 -07:00
Anton Kolesnyk
0f62b3aa63
Add consumption-time value of __cplusplus to User-Agent (#5662)
* Add consumption-time value of __cplusplus to User-Agent

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-07-29 18:31:51 -07:00
Larry Osterman
90089ad326
Cleaned up Azure::Core::Context API surface (#5676)
* Deprecated Azure::Core::ApplicationContext because its use is confusing and inconsistent with the original design. 

---------

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2024-07-17 12:38:30 -07:00
Azure SDK Bot
fb6c039f5e
Increment package version after release of azure-core (#5794) 2024-07-12 21:34:14 +00:00
Anton Kolesnyk
6b9e1cc691
Revert commits related to the new RetryPolicy method (#5793)
* Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)"

This reverts commit 9ccd206ff8.

* Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)"

This reverts commit f1d95520d1.

* Do not remove changelog entry from a previous beta release

* Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)"

This reverts commit ab90ef68b0.

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-07-12 12:03:43 -07:00
Anton Kolesnyk
e8c7c559d9
Azure Core July GA Release (#5792)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-07-12 10:24:12 -07:00
Robert Schulze
8f26ebb8a8
Add missing include (#5766) 2024-07-08 09:17:46 -07:00
Anton Kolesnyk
ef9d2a5e18
Remove 'include windows.h' from inc/* (#5691)
* Remove 'include windows.h' from inc/*

* Clang format

* Qualify namespace

* Clean up includes a bit further

* Fix errors

* Clang format

* move out _detail definitions

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-06-07 03:07:10 -07:00
Azure SDK Bot
c5d0549cb5
Increment version for core releases (#5700)
* Increment package version after release of azure-core

* Increment package version after release of azure-core-amqp
2024-06-07 00:07:00 +00:00
Ahson Khan
f1d95520d1
Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)
* Update the RetryPolicy and ShouldRetry customization logic to allow
loosen the retry condition.

* Add CL entry and update doc comment.

* Move WasLastAttempt check out, and add more tests.

* Address PR feedback, remove use of void and unused params.
2024-05-30 11:08:56 +08:00
Anton Kolesnyk
fdb8657f41
Add HTTP request version logging, and scope the variables (#5643)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-05-20 14:06:55 -07:00
Ahson Khan
f517aabb98
Clean-up the HTTP versions check in response parsing, and don't reuse connections on any response other than HTTP/1.1 (#5608)
* Harden the HTTP versions check in response parsing, validating specifically for 1.1 or 1.0, and throwing otherwise.

* Address feedback - comment was confusing.

* Update sdk/core/azure-core/src/http/curl/curl.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Clarify the http version check and set keep-alive as false instead of throwing for non-http1.x.

* Address PR feedback - add comment snippet, and update log message.

---------

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2024-05-20 00:23:48 -07:00
Anton Popov
5d3f95535a
fix possible endless loop while polling curl socket (#5589) 2024-05-16 12:02:01 -07:00
Ahson Khan
6b5a8d1e36
Update CURLCode error to the non-obsoleted value. (#5545) 2024-05-16 17:49:09 +00:00
Ahson Khan
ab90ef68b0
Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)
* Add a virtual ShouldTry method to the RetryPolicy for customization.

* Make test hooks virtual again.

* Add unit test for ShouldRetry.

* Fix typo.

* Address PR feedback.

* Revert making the mock'd functions private for non-test builds.

* Add new line.
2024-05-14 01:09:02 +00:00
Azure SDK Bot
3b9574c610
Increment package version after release of azure-core (#5614) 2024-05-13 15:42:57 -07:00
Anton Kolesnyk
a0cb5dd55c
Core May GA Release (#5572)
* Core May GA Release

* Add azure-core-amqp to release

* Update date on the core changelog.

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2024-05-09 20:01:52 +00:00
George Arama
8db62bf8da
reenable the global cleanup test (#5590) 2024-05-01 14:02:09 -07:00
Azure SDK Bot
a74ecaad3d
Increment package version after release of azure-core (#5511) 2024-04-10 15:55:55 -07:00
Anton Kolesnyk
145f6dbdb6
Fixed libcurl connection pool to use Connection response header values (#5473)
* Fixed libcurl connection pool to use `Connection` response header values

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-04-10 08:01:29 -07:00
Azure SDK Bot
7f2f593b30
Increment version for core releases (#5503)
* Increment package version after release of azure-core-amqp

* Increment package version after release of azure-core
2024-04-09 14:39:30 -07:00
Ahson Khan
0bdec1e3c9
Core April GA Release (#5491)
* Azure Core 1.12.0 April Release

* Update Core's CHANGELOG.md

* Update Core's package_version.hpp

* Update AMQPCHANGELOG.md

* Update ci.tests.yml

* Re-enable coverage checks

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2024-04-09 10:45:25 -07:00
Ahson Khan
da1513977a
Rename the TESTING_BUILD macro to be _azure_TESTING_BUILD to highlight this is internal only and reduce chances of collision. (#5419)
* Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where they are not needed.

* Rename the TESTING_BUILD macro to be _azure_TESTING_BUILD to highlight this is internal only and reduce chances of collision.

* Update remaining macro names and add comments.

* Revert rename change which was using BUILD_TESTING cmake flag in source.
2024-04-05 12:05:04 -07:00
Anton Kolesnyk
d62b0d6669
Revert "Move the connection back to the connection pool when HTTP error 404 was received (#5308)" (#5472)
* Revert "Move the connection back to the connection pool when HTTP error 404 was received (#5308)"

This reverts commit 79cc06d004.

* Changelog

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-04-02 17:08:34 -07:00