* Support BaseName overrides in CI mode for New-TestResources.ps1 (#3559)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Do not pass Generated to -BaseName (#3562)
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Sort by service name first (#3570)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Initialize the suppression file. (#3569)
* Sync eng/common directory with azure-sdk-tools for PR 3169 (#3572)
* Use the batch version of ValidateDocsMsPackagesFn
* Use proper pipelining for GetPackageInfoJson function
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* [Tech Docs] Libcurl transport adapter (#3484)
* libcurl transport adapter
* updates
* Update LibcurlTransportAdapter.md
* Update LibcurlTransportAdapter.md
* Update doc/LibcurlTransportAdapter.md
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
* Skip azcopy download if it already exists (#3576)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* Pin openssl to 1.1.1n (#3575)
* Pin openssl to 1.1.1n
* Updated vcpkg commit to one containing OpenSSL 1.1.1n
* Fixed version number in vcpkg.json
* Fix typo (#3583)
* update curl transport options to support ignore proxy from system (#3564)
* update curl transport options to support ignore proxy from system
* update changelog
* bug fix for cl
* update log level from Retry policy (#3586)
* update log level
* Update sdk/core/azure-core/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Add batch protocol layer (#3580)
* Add batch protocol layer
* some small fixes on Storage cmakefiles (#3588)
* Migrate to matrix generator (#3553)
* Represent existing matrix in json
* Use new matrix
* Move to stage
* Cloud configuration
* MaxParallel
* DependsOn
* Quote CtestRegex
* Use template for cmake generate tests
* Template name mappings
* Formatting, parameters
* Remove duplicate bypass-local-dns.yml
* Enable Location override
* Add Location
* Add spelling words
* Use Ubuntu 20 where the name specifies Ubuntu 20
* Apply suggestions from code review
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* PR feedback
* fix storage sample
* Matrix documentation
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
* Sync eng/common directory with azure-sdk-tools for PR 3212 (#3587)
* bump consumed version of test proxy. update scripting to target the fully cross-platform image tag name.
* update target version of the test-proxy to one that enforces http/1.1
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3238 (#3590)
* pin proxy version to one that properly sets listenoptions
* update targeted test-proxy docker repo. "testproxy" -> "test-proxy"
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3221 (#3591)
* Make docs.ms link relative link
* Update Update-DocsMsMetadata.ps1
* Update eng/common/scripts/Update-DocsMsMetadata.ps1
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Remove the daily branch before date (#3593)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Add ClientCertificateCredential (#3578)
* Add ClientCertificateCredential
* Update unit test
* cspell
* Update Readme
* Cosmetic fixes
* Changelog to mention env cred update
* Fix warning
* cspell
* Tell CI to install openssl
* openssl for all Windows
* update dependency manifest
* Re-phrase changelog
* Clang warnings
* Clang warning
* Clang warning - 2
* Ubuntu18 warning
* Update sdk/identity/azure-identity/CHANGELOG.md
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* PR feedback
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3250 (#3595)
* Change the direction of the commit date
* Log on right place
* remove auth
* fix typo
* Add auth token back
* add delete back
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Create a session handle once in the transport ctor and reuse it for all requests rather than creating a new one each time. (#3585)
* Reuse the same session handle for all requests rather than creating a new one each time.
* Move the session handle creation to the transport adapter ctor.
* Update changelog entry.
* Address PR feedback.
* Change CreateSessionHandle to return a local session handle
* Fix-up the changelog entry link for the curtransportoption bug fix (#3598)
* Remove extra period at ends of exception messages in winhttp transport (#3601)
* fix cmake in storage (#3604)
* Reword the curl proxy fix changelog entry. (#3606)
* Add Emma Zhu as code owner (#3605)
* Short circuit out of msdocs publish if no package locations are specified (#3607)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* sdk/core: Reimplement Md5OpenSSL using EVP API (#3609)
The MD5_Init/Update/Final functions are deprecated in OpenSSL 3.0 and result in
a compile-time warning. Due to the default usage of -Werror during compilation,
these warnings are treated as errors and prevent the SDK from being built on
Ubuntu 22.04, which ships with OpenSSL by default. The deprecated APIs should
be replaced by the EVP APIs, which are already in use for the SHA family of
functions, and supported on all versions of OpenSSL.
* API Review Feedback for Attestation SDK (#3543)
* API Review Feedback for Attestation SDK
* Updated changelog to reflect API Review updates
* Remove version pin for OpenSSL (#3610)
* Remove version pin for OpenSSL
* Gratuitous change to trigger CI pipelines
* Update the version tool to the latest (#3616)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Get rid of warnings in nullable.hpp (#3617)
* cl (#3613)
* Update pipeline-generator version (#3623)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* Prepare Attestation SDK for May Release. (#3625)
* Prepare attestation for May release
* Removed some noise from changelog
* Increment package version after release of azure-core (#3624)
* Update CODEOWNERS (#3628)
* Fix identity samples running in CI (#3632)
* azure identity may 2022 release (#3615)
* Increment package version after release of azure-identity (#3637)
* Removed uwp-x86 from platform matrix. (#3629)
* Increment package version after release of azure-security-attestation (#3636)
* Update readme for -pre and -post TestResource scripts (#3645)
Co-authored-by: Christopher Scott <chriss@microsoft.com>
* Fixed a bug where text of XML element cannot be empty. (#3643)
* String parsing improvements to service directory resource names (#3644)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Adding Acknowledgments (#3611)
* cl
* Update sdk/core/azure-core/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* cspell
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Add skip variable for remove test resources to support debugging (#3648)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Storage Blob Stg78 Features (#3650)
* Clean up target_include_directories() (#3641)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update all-inclusive headers, and CMakeFiles for including all headers (#3640)
* Remove (#3657)
oexcept specifier from Context::IsCancelled()
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add Language product slug (#3665)
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3342 (#3664)
* Delete PR and branch which central PR is closed
* more logging changes
* resume the delete operations.
* Change the pr link directly
* fix the regex
* Refactor on regex name
* change the function to inline logic
* change typo
* delete on branch
* make changes on comments
* add commnets
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Split out attestation client factory into separate class (#3654)
* Split out attestation client factory into separate class
* Updated readme; clang-format
* Final set of API review changes
* Replaced () constructors with {} constructors
* Initial implementation of OpenTelemetry APIs. (#3561)
* Start of tracing prototype
* Created initial implementation of azure-core-opentelemetry package
* New version of enabling MSVCRT Lib for static configs
* Attempt to add OpenTelemetry tests to build
* Take a dependency on OpenTelemetry version 1.3
* Added service API level tracing support
* API Review feedback
* storage unittest fix and improvement (#3667)
* Sync eng/common directory with azure-sdk-tools for PR 3362 (#3676)
* spell-check skippable by commit
* suceededOrFailed -> succeededOrFailed
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3378 (#3679)
* Create json package property parent directory
* Fix the issue in script
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Vcpkg sample (#3670)
* one commit to rule them all
* main merge
* error
* all smoke
* typo
* 120 minutes
* timeout param missing on job
* actual url
* Update samples/integration/vcpkg-all-smoke/src/main.cpp
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* actual creds
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* Complete the initial implementation of OpenTelemetry (#3677)
* Added telemetry support for HTTP pipeline elements
* Finish OpenTelemetry implementation
* clang-format and added doxygen comments
* Creadscan skips (#3671)
* one commit to rule them all
* main merge
* error
* add recordings for cred scan skipping
* certificates added
* remove dupe
* cspell
* Moved attestation factory back to static method on attestation class … (#3682)
* Moved attestation factory back to static method on attestation class and return a concrete type not a pointer
* Fixed factory in readme file
* OpenTelemetry API Review Feedback (#3687)
* OpenTelemetry API Review Feedback
* Attestation 1.0.0 GA Release (#3693)
* Prepare attestation for release
* removed references to RetrieveResponseValidationCollateral from docs
* Added C++ SDK team as owners of attestation SDK
* Added Ahmad from attestation team to attestation owners
* Removed dead API; switched attestation back to beta-3
* Disable detached head warnings on sparse checkout to commit (#3680)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Remove samples with docker.io (#3621)
* remove samples using docker.io
* removing docker files
* remove project
* Fix issue where matrix replace was not using imported display names (#3694)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Additional OpenTelemetry Feedback... (#3691)
* OpenTelemetry API Review Feedback
* Returns std::unique_ptr<DiagnosticTracingFactory instead of raw pointer
* Late breaking pull request feedback
* Renamed clientContext parameter to CreateSpan
* Renamed ContextAndSpanFactory to TracingContextFactory and CreateSpan to CreateTracingContext.
* Added ability to create instance with pointer (#3698)
* Added ability to create instance with pointer
* Pull request feedback
* Core 1.7.0-beta.1 Release (#3684)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-core (#3699)
* Format vcpkg.json (#3701)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update README to list all the vcpkgs (#3704)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Removed version>= fields for openssl in vcpkg.json files (#3705)
* Tab vcpkg publishing condition in to apply to the task (#3709)
* Storage June Release (#3686)
* Override live test location default to westus (#3696)
* Changelog updates for secrets and certificates (#3714)
* Changelog updates for secrets and certificates
* Update package versions
* Removed empty sections in changelog (#3718)
* Identity 1.3.0 Release (#3685)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* OpenTelemetry vcpkg fixes (#3716)
* OpenTelemetry vcpkg fixes
* Update ci.yml
* Drop version >= from project-level vcpkg
* find_package only supports numeric versions
* include(AzureBuildTargetForCI)
* Do not build as Windows/UWP DLL
* Docs and package dependencies
* Update condition
* Move condition down
* Move more under condition
* Rephrase condition
* Try hack for CI that won't affect vcpkg
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-identity (#3721)
* Increment version for storage releases (#3713)
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* [EngSys] Get Vcpkg automatically (#3614)
* get vcpkg automatically
* Updated changelog (#3726)
* Increment package version after release of azure-core-tracing-opentelemetry (#3727)
* Increment package version after release of azure-security-attestation (#3717)
* Increment package version after release of azure-security-attestation (#3720)
* Enable Distributed Tracing for Attestation SDK client. (#3706)
* Implement tracing for Attestation and Template services
* Pipeline no longer requires service name if opting into distributed tracing; enable tracing in attestation service
* Generate user-agent header from request activity policy
* Added test to catch the redacted header regression
* Updated documentation to reflect API surface changes
* Make sample service an object library (#3728)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Include pi-version to default list of unredacted query params for logging (#3730)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3433 (#3731)
* add condition
* divide line
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3267 (#3655)
* Use seperate scripts
* address comments.
* do compare and update
* save on the service level readme
* have the helper for reuse function
* remove mgmt table
* changes
* fix
* no return on error
* return if no contents
* Address comments
* change the table
* address wes comments.
* address wes comments.
* address more comments.
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3386 (#3733)
* Update the order of remarks and examples to align with docs.ms
* change all occurance
* Update class.tmpl.partial
Co-authored-by: sizhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* ensure conditions all work properly in the case of a previous error (#3732)
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
* InputSanitizer: rename to HttpSanitizer, remove static member (#3736)
* InputSanitizer => HttpSanitizer, remove static
* Update cpp
* Clang format
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment version for keyvault releases (#3719)
* Increment package version after release of azure-security-keyvault-certificates
* Increment package version after release of azure-security-keyvault-secrets
* Update DistributedTracing.md (#3715)
Fix typo
* ApiView command line generation script (#3711)
* ApiView command line generation script
* Strongly typed parameters
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* Add missing license header to http_sanitizer source file (#3739)
* Add ResourceType parameter - Selects live test or perf test resources (#3740)
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Update identity codeowners (#3744)
* ManagedIdentityCredential: Add support for AppServiceV2019 (#3734)
* ManagedIdentityCredential: Add support for AppServiceV2019
* Attempt to create 2019 before 2017
* Changelog update
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Fix Bug in Resource Ref Verifier (#3758)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Use westus as default region in test resource deployments (#3759)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Perf test for certs (#3729)
* one commit to rule them all
* main merge
* error
* main merge
* error
* main merge
* error
* main merge
* error
* example of perf test
* remove file
* create certs and keys in post setup, use to run the test
* PR comments
* Revert "Override live test location default to westus (#3696)" (#3761)
This reverts commit d4192609d5.
* Sync eng/common directory with azure-sdk-tools for PR 3481 (#3764)
* Support local addons path override in stress test deployment
* Support username based deployId in local stress deployment
* Support WhatIf in stress infrastructure provision script
* Simplify stress user detection
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Run helm plugin add with helper
* Add WhatIf support to ps module install helper function
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Fixed typo in LibcurlTransportAdapter.md (#3768)
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Script that automates updating vcpkg betas
* Wire up to pipeline
* Spelling, commentary
* Clone into repo name
* Remove-Item requires the path to exist, even if -Force is specified
* Bootstrap vcpkg
* Arguments to Test-ShouldReleaseToVcpkg.ps1
* More commit
* Escape quotes
* Quote git commit
* Set strict mode
* Use tags
* Actually tag
* Run git commands
* Invoke-Expression
* Onboard releasing package to vcpkg before attempting to isntall from overaly
* temporarily disable matrix generation (30s tasks sometimes runs for 20+ minutes)
* Test-ShouldReleaseToVcpkg.ps1
* Test-Path
* Test vcpkg build, also ensure we push
* Just the tags... low probability of success given that '--' if frequently treated as a separator
* Add ability to skip link verification for tighter inner loop
* Push tag separately
* Unnecessary condition and conjunction
* Base repo owner: Azure
* Specify remote name
* Tighten inner loop
* git remote -v
* workingDirectory
* Go back to two tags and a regular push
* Saving some progress
* Use original push method
* BaseRepoOwner
* Cleanup, put changes in the default branch (vcpkg does not look at refs outside of the default branch)
* Use default branch
* binary cache and manifest
* update packages
* udpate
* add cache to private pipeline
* next try
* aver
* other
* again
* aver quick
* more
* this way
* again
* one more
* print
* test
* use depend
* more deps
* dep
* Apply suggestions from code review
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* updated to use group variable
* update identity
* end line
* Update vcpkg.json
* Apply suggestions from code review
* cspell
* remove comment
* updates
* make cache mode depend on SAS env var
* map env var only for internal pipelines
* other approach
* what about this
* and this
* try
* amd
* another
* extra step
* typo
* override for internal
* use default succeded
* azure core update manifest
* a
* run cmake-generate nightly as well
* check for SAS
* check cache
* no secret
* fix is secret
* pass explicit
* use secret all the time
* char
* One more
* export
* echos
* last
* array
* remove question
* ok
* weird
* use account key
* substring
* VCPKG_BINARY_SOURCES
* Add module installation
* task:
* Correct pathing for module
* update source gen
* format
* update spelling
* IsWindoows
* Use pwsh
* Cannot clobber with PSModule-Helpers. Attempt plain install
* Attempt plain install
* Revert unnecessary change to Update-DocsMsToc.ps1
* template ready
* curl is required on Windows as well for some CI gates
* attestation
* fix format
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Moved samples around to meet new recommendations; added a couple of additional tests.
* Reworked attestation to include RetrieveAttestationValidationCollateral
* Attestation sample readme updates
* TPM doesn't need to retrieve response validation collateral
* Added cautionary warning about the dangers of overriding the TearDown method from inside a test case
* Added attestation team members to codeowners for attestation SDK
* Remove CODEOWNERS from cspell checks
* Don't hold a lock across retrieving the signers over the network
* Updated snippets in readme; clang-format
* Added GetPolicyManagementCertificates
* Added Add and Remove policy certificate
* Added support for Tpm attestation
* Moved TPM to attestation service specific section
* Added support for validation callback
* Updated RequestFailedException documentation
* cp
* cp
* cp
* Enable test proxy for perf tests
* unwanted
* format
* fix docs
* cspell
* parallel support and multi proxy
* update arg name
* more logs
* fix request redirection
* Apply suggestions from code review
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* run once before record, then after recording on
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* RequestFailedException includes error information
* Fixed test collateral
* Added changelog entry for new core version; Added tests to verify response message contains all expected fields
* Created extendableenumeration class
* Convert attestation to use extendable enumeration; added test for extendable enumerations
Co-authored-by: Casey Carter <cartec69@gmail.com>
* Set WinHTTP_OPTION_CLIENT_CERT_CONTEXT to enable connections to attestation service
* Set serviceDirectory from environment variables
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* Removing the two param RFE ctor, there should be no callers
* Remove the two param RFE ctor from the source file.
* Fix-up unit test and add a changelog entry.
* Remove test that uses the removed ctor.
* Delegate to RFE string ctor and move impl from header to src.
* Removing the two param RFE ctor, there should be no callers
* Remove the two param RFE ctor from the source file.
* Fix-up unit test and add a changelog entry.
* Remove test that uses the removed ctor.
It all started with UWP. The [docs](https://docs.microsoft.com/en-us/cpp/cppcx/crt-functions-not-supported-in-universal-windows-platform-apps?view=msvc-170) say: "`Environment variables are not available to UWP apps.`". And it truly won't work, I tried: linker error, the function is simply not present.
So, for a year or so, we were `ifdef`ing everything enivoronment-related: console logger, environment credential, managed identity credential.
And then just recently we wanted to enable our CI for UWP, including tests and samples. And it required to do more ifdefs (in vcpkg, we don't build samples or tests, so that problem did not exist).
It just became more messy. Especially in samples - you can see how we would disable warning with `#pragma warning(disable : 4996)` or defining `_CRT_SECURE_NO_WARNINGS` already, but now came UWP, so we would have to add comment that `getenv()` is not available and make the sample compilation to either fail with clear message, or throw an exception. Plus we would have to detect that we are being compiled on UWP, which also adds visual clutter for reader. You can see how such an irrelevant (for a sample) thing as `getenv` was consuming more and more lines of sample code and reader's attention.
But then! I read docs on more APIs for UWP. And I noticed that on .NET you can read environment variables. So I went and checked Win32 API docs for [GetEnvironmentVariable()](https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getenvironmentvariable) - it says: "`Minimum supported client: ... UWP apps`".
**GetEnvironmentVariable() works on UWP!**
And so does `SetEnvironmentVariable()` (our tests use it, which means we can make all of them work and execute for UWP).
That's good news, but now it would probably be more code: it usually takes more lines to invoke WinAPI, it is no more an one-liner to call `getenv()/setenv()`. So, I encapsulated that into `Azure::Core::_internal::Environment::GetVariable()` and `SetVariable()`. You can see how much less ifdefs is in our code now. Not to mention it works on UWP!
Per team request, that API is SDK-internal. Samples use their own mini-helper project, `get-env-helper` that makes is so that `getenv()` works naturally on Linux and macOS, compiles without warnings and works on Win32, and compiles and works on UWP (using `GetEnvironmentStringsA()`)
If it was for me, I would just make `Azure::Core::Environment::GetVariable()` public and simplify even further, I think it would be beneficial for sample readers (you can see that extra `get-env-helper` stuff adds just a little more visual clutter, compared to nothing). But I can see reasons against that, why team did not want to do it.
* Generate map files in build
* Add .map file artifact publishing
* Add Xlinker to spelling exceptions
* Remove PublishMapFiles from clang builds
* Generate the map file artifact name
* CXX_COMPILER_ID and some logging for Clang which might be linking using the GNU linker by default
* More logging
* Move logging out of conditional
* Logging up high, use OS to determine which link flags to set
* Use linker options specific to AppleClang's context, publish map files for all platforms
* Use code coverage annotations in places that never can be covered
* Comments
* Increment goal
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
