github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

clang-13 version of cstdlib doesn't define integer types in global na… (#5031)

Browse Source 
* clang-13 version of cstdlib doesn't define integer types in global namespace

* Added clang-13 and clang-15 variants to mix

* Pull request feedback

* Update sdk/core/azure-core/inc/azure/core/uuid.hpp

* Update sdk/core/azure-core/inc/azure/core/base64.hpp

---------

Co-authored-by: Larry Osterman <larryo@LOTHAIR-HOME.ntdev.corp.microsoft.com>
This commit is contained in:
Larry Osterman 2023-10-17 11:55:54 -07:00 committed by GitHub
parent e7b9b0aaaf
commit fbec02365b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 50 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
CMakePresets.json
View File

@ -370,6 +370,24 @@
"rhs": "Linux"
}
},
{
"name": "linux-basic-clang-13",
"displayName": "Linux clang-13",
"description": "Using compilers: C = /usr/bin/clang-13, CXX = /usr/bin/clang++-13",
"binaryDir": "${sourceDir}/out/build/${presetName}",
"generator": "Ninja",
"hidden": true,
"cacheVariables": {
"CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}",
"CMAKE_C_COMPILER": "/usr/bin/clang-13",
"CMAKE_CXX_COMPILER": "/usr/bin/clang++-13"
},
"condition": {
"type": "equals",
"lhs": "${hostSystemName}",
"rhs": "Linux"
}
},
{
"name": "linux-basic-g++",
"displayName": "Linux G++",
@ -403,9 +421,19 @@
"inherits": [ "linux-basic-clang-11", "debug-build" ]
},
{
"name": "linux-clang-11-debug-tests",
"inherits": [ "linux-basic-clang-11", "debug-build", "enable-tests" ],
"displayName": "Linux clang 11 Debug+Tests"
"name": "linux-clang-13-debug-tests",
"inherits": [ "linux-basic-clang-13", "debug-build", "enable-tests" ],
"displayName": "Linux clang 13 Debug+Tests"
},
{
"name": "linux-clang-11-debug",
"displayName": "Linux clang 11 Debug",
"inherits": [ "linux-basic-clang-11", "debug-build" ]
},
{
"name": "linux-clang-13-debug-tests",
"inherits": [ "linux-basic-clang-13", "debug-build", "enable-tests" ],
"displayName": "Linux clang 13 Debug+Tests"
},
{
"name": "linux-g++-debug",

15
eng/pipelines/templates/stages/platform-matrix.json
View File

@ -149,6 +149,16 @@
"CC": "/usr/bin/gcc-9",
"CXX": "/usr/bin/g++-9"
},
"clang-13": {
"AptDependencies": "clang-13",
"CC": "/usr/bin/clang-13",
"CXX": "/usr/bin/clang++-13"
},
"clang-15": {
"AptDependencies": "clang-15",
"CC": "/usr/bin/clang-15",
"CXX": "/usr/bin/clang++-15"
},
"included_coverage": {
"AptDependencies": "gcovr lcov",
"CmakeArgs": " -DBUILD_TESTING=ON -DBUILD_PERFORMANCE_TESTS=ON -DRUN_LONG_UNIT_TESTS=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_CODE_COVERAGE=ON -DCMAKE_VERBOSE_MAKEFILE=ON",
@ -156,6 +166,11 @@
"CODE_COVERAGE": "enabled",
"PublishMapFiles": "true"
},
"included_debug": {
"CMAKE_BUILD_TYPE": "Debug",
"CmakeArgs": " -DBUILD_TESTING=ON -DBUILD_PERFORMANCE_TESTS=ON -DRUN_LONG_UNIT_TESTS=ON",
"PublishMapFiles": "true"
},
"included_release": {
"CMAKE_BUILD_TYPE": "Release",
"CmakeArgs": " -DBUILD_TESTING=ON -DBUILD_PERFORMANCE_TESTS=ON -DRUN_LONG_UNIT_TESTS=ON",

3
sdk/core/azure-core/inc/azure/core/base64.hpp
View File

@ -10,8 +10,9 @@
#pragma once
#include <algorithm>
#include <cstdint>
#include <cstdint> // defines std::uint8_t
#include <stdexcept>
#include <stdint.h> // deprecated, defines uint8_t in global namespace. TODO: Remove when uint8_t in the global namespace is removed.
#include <string>
#include <vector>

3
sdk/core/azure-core/inc/azure/core/uuid.hpp
View File

@ -11,8 +11,9 @@
#include "azure/core/platform.hpp"
#include <array>
#include <cstdint>
#include <cstdint> // defines std::uint8_t
#include <cstring>
#include <stdint.h> // deprecated, defines uint8_t in global namespace. TODO: Remove in the future when references to uint8_t and friends are removed.
#include <string>
namespace Azure { namespace Core {