github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed the TablesAudience field from TableClientOptions since it is not required. (#6145)

Browse Source
This commit is contained in:
Ahson Khan 2024-10-29 15:07:09 -07:00 committed by GitHub
parent 6dc58c07d5
commit fb79281273
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sdk/tables/azure-data-tables/CHANGELOG.md
View File

@ -6,6 +6,7 @@
### Breaking Changes
- Removed the `TablesAudience` field from `TableClientOptions` since it is not required.
- Removed ServiceVersion type and changed the ApiVersion field within `TableClientOptions` to be std::string.
- Removed the `TableServiceClient` constructor that only accepts one defaulted options parameter.

27
sdk/tables/azure-data-tables/inc/azure/data/tables/tables_clients.hpp
View File

@ -70,27 +70,6 @@ namespace Azure { namespace Data { namespace Tables {
constexpr static const char* ODataError = "odata.error";
} // namespace _detail
/**
* @brief Audiences available for Blobs
*
*/
class TablesAudience final
: public Azure::Core::_internal::ExtendableEnumeration<TablesAudience> {
public:
/**
* @brief Construct a new TablesAudience object
*
* @param tablesAudience The Azure Active Directory audience to use when forming authorization
* scopes. For the Language service, this value corresponds to a URL that identifies the Azure
* cloud where the resource is located. For more information: See
* https://learn.microsoft.com/en-us/azure/storage/blobs/authorize-access-azure-active-directory
*/
explicit TablesAudience(std::string tablesAudience)
: ExtendableEnumeration(std::move(tablesAudience))
{
}
};
/**
* @brief Optional parameters for constructing a new TableClient.
*/
@ -107,12 +86,6 @@ namespace Azure { namespace Data { namespace Tables {
* to prompt a challenge in order to discover the correct tenant for the resource.
*/
bool EnableTenantDiscovery = false;
/**
* The Audience to use for authentication with Azure Active Directory (AAD).
*
*/
Azure::Nullable<TablesAudience> Audience;
};
/**

8
sdk/tables/azure-data-tables/src/tables_clients.cpp
View File

@ -52,9 +52,7 @@ TableServiceClient::TableServiceClient(
perRetryPolicies.emplace_back(std::make_unique<TimeoutPolicy>());
{
Azure::Core::Credentials::TokenRequestContext tokenContext;
tokenContext.Scopes.emplace_back(
newOptions.Audience.HasValue() ? newOptions.Audience.Value().ToString()
: m_url.GetAbsoluteUrl() + "/.default");
tokenContext.Scopes.emplace_back(m_url.GetAbsoluteUrl() + "/.default");
perRetryPolicies.emplace_back(std::make_unique<TenantBearerTokenAuthenticationPolicy>(
credential, tokenContext, newOptions.EnableTenantDiscovery));
@ -336,9 +334,7 @@ TableClient::TableClient(
perRetryPolicies.emplace_back(std::make_unique<TimeoutPolicy>());
{
Azure::Core::Credentials::TokenRequestContext tokenContext;
tokenContext.Scopes.emplace_back(
newOptions.Audience.HasValue() ? newOptions.Audience.Value().ToString()
: m_url.GetAbsoluteUrl() + "/.default");
tokenContext.Scopes.emplace_back(m_url.GetAbsoluteUrl() + "/.default");
perRetryPolicies.emplace_back(std::make_unique<TenantBearerTokenAuthenticationPolicy>(
credential, tokenContext, newOptions.EnableTenantDiscovery));