github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

update context to const ref (#389)

Browse Source
This commit is contained in:
Victor Vazquez 2020-08-04 09:45:13 -07:00 committed by GitHub
parent 3de57667d4
commit eeffd6248f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
28 changed files with 107 additions and 92 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/core/azure-core/inc/context.hpp
View File

@ -185,7 +185,7 @@ namespace Azure { namespace Core {
m_contextSharedState, time_point::max(), key, std::move(value))};
}
time_point CancelWhen();
time_point CancelWhen() const;
const ContextValue& operator[](const std::string& key)
{
@ -221,7 +221,7 @@ namespace Azure { namespace Core {
void Cancel() { m_contextSharedState->CancelAt = time_point::min(); }
void ThrowIfCanceled()
void ThrowIfCanceled() const
{
if (CancelWhen() < std::chrono::system_clock::now())
{

5
sdk/core/azure-core/inc/credentials/credentials.hpp
View File

@ -20,7 +20,7 @@ namespace Azure { namespace Core { namespace Credentials {
class TokenCredential {
public:
virtual AccessToken GetToken(Context& context, std::vector<std::string> const& scopes)
virtual AccessToken GetToken(Context const& context, std::vector<std::string> const& scopes)
const = 0;
protected:
@ -48,7 +48,8 @@ namespace Azure { namespace Core { namespace Credentials {
{
}
AccessToken GetToken(Context& context, std::vector<std::string> const& scopes) const override;
AccessToken GetToken(Context const& context, std::vector<std::string> const& scopes)
const override;
};
class AuthenticationException : public std::runtime_error {

2
sdk/core/azure-core/inc/credentials/policy/policies.hpp
View File

@ -54,7 +54,7 @@ namespace Azure { namespace Core { namespace Credentials { namespace Policy {
}
std::unique_ptr<Http::RawResponse> Send(
Context& context,
Context const& context,
Http::Request& request,
Http::NextHttpPolicy policy) const override;
};

20
sdk/core/azure-core/inc/http/body_stream.hpp
View File

@ -43,12 +43,16 @@ namespace Azure { namespace Core { namespace Http {
// Reads more data; throws if error/canceled
// return copied size
virtual int64_t Read(Context& context, uint8_t* buffer, int64_t count) = 0;
virtual int64_t Read(Context const& context, uint8_t* buffer, int64_t count) = 0;
// Keep reading until buffer is all fill out of the end of stream content is reached
static int64_t ReadToCount(Context& context, BodyStream& body, uint8_t* buffer, int64_t count);
static int64_t ReadToCount(
Context const& context,
BodyStream& body,
uint8_t* buffer,
int64_t count);
static std::vector<uint8_t> ReadToEnd(Context& context, BodyStream& body);
static std::vector<uint8_t> ReadToEnd(Context const& context, BodyStream& body);
};
class MemoryBodyStream : public BodyStream {
@ -73,7 +77,7 @@ namespace Azure { namespace Core { namespace Http {
int64_t Length() const override { return this->m_length; }
int64_t Read(Context& context, uint8_t* buffer, int64_t count) override;
int64_t Read(Context const& context, uint8_t* buffer, int64_t count) override;
void Rewind() override { m_offset = 0; }
};
@ -87,7 +91,7 @@ namespace Azure { namespace Core { namespace Http {
void Rewind() override {}
int64_t Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count) override
int64_t Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count) override
{
(void)context;
(void)buffer;
@ -121,7 +125,7 @@ namespace Azure { namespace Core { namespace Http {
// Rewind seek back to 0
void Rewind() override { this->m_offset = 0; }
int64_t Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count) override;
int64_t Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count) override;
int64_t Length() const override { return this->m_length; };
};
@ -146,7 +150,7 @@ namespace Azure { namespace Core { namespace Http {
// Rewind seek back to 0
void Rewind() override { this->m_offset = 0; }
int64_t Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count) override;
int64_t Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count) override;
int64_t Length() const override { return this->m_length; };
};
@ -170,7 +174,7 @@ namespace Azure { namespace Core { namespace Http {
this->m_inner->Rewind();
this->m_bytesRead = 0;
}
int64_t Read(Context& context, uint8_t* buffer, int64_t count) override;
int64_t Read(Context const& context, uint8_t* buffer, int64_t count) override;
};
}}} // namespace Azure::Core::Http

10
sdk/core/azure-core/inc/http/curl/curl.hpp
View File

@ -325,8 +325,8 @@ namespace Azure { namespace Core { namespace Http {
*
* @return CURL_OK when response is sent successfully.
*/
CURLcode HttpRawSend(Context& context);
CURLcode UploadBody(Context& context);
CURLcode HttpRawSend(Context const& context);
CURLcode UploadBody(Context const& context);
/**
* @brief This method will use libcurl socket to write all the bytes from buffer.
@ -391,7 +391,7 @@ namespace Azure { namespace Core { namespace Http {
* @param context TBD
* @return CURLE_OK when the network call is completed successfully.
*/
CURLcode Perform(Context& context);
CURLcode Perform(Context const& context);
/**
* @brief Moved the ownership of the HTTP RawResponse out of the session.
@ -403,7 +403,7 @@ namespace Azure { namespace Core { namespace Http {
int64_t Length() const override { return this->m_contentLength; }
int64_t Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count) override;
int64_t Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count) override;
};
/**
@ -419,7 +419,7 @@ namespace Azure { namespace Core { namespace Http {
* @param request an HTTP Request to be send.
* @return unique ptr to an HTTP RawResponse.
*/
std::unique_ptr<RawResponse> Send(Context& context, Request& request) override;
std::unique_ptr<RawResponse> Send(Context const& context, Request& request) override;
};
}}} // namespace Azure::Core::Http

2
sdk/core/azure-core/inc/http/pipeline.hpp
View File

@ -47,7 +47,7 @@ namespace Azure { namespace Core { namespace Http {
* @param request The request to be processed
* @return unique_ptr<Response>
*/
std::unique_ptr<RawResponse> Send(Context& ctx, Request& request) const
std::unique_ptr<RawResponse> Send(Context const& ctx, Request& request) const
{
return m_policies[0]->Send(ctx, request, NextHttpPolicy(0, &m_policies));
}

34
sdk/core/azure-core/inc/http/policy.hpp
View File

@ -22,7 +22,7 @@ namespace Azure { namespace Core { namespace Http {
// Any errors in the pipeline throws an exception
// At the top of the pipeline we might want to turn certain responses into exceptions
virtual std::unique_ptr<RawResponse> Send(
Context& context,
Context const& context,
Request& request,
NextHttpPolicy policy) const = 0;
virtual ~HttpPolicy() {}
@ -47,7 +47,7 @@ namespace Azure { namespace Core { namespace Http {
{
}
std::unique_ptr<RawResponse> Send(Context& ctx, Request& req);
std::unique_ptr<RawResponse> Send(Context const& ctx, Request& req);
};
class TransportPolicy : public HttpPolicy {
@ -65,8 +65,10 @@ namespace Azure { namespace Core { namespace Http {
return std::make_unique<TransportPolicy>(m_transport);
}
std::unique_ptr<RawResponse> Send(Context& ctx, Request& request, NextHttpPolicy nextHttpPolicy)
const override;
std::unique_ptr<RawResponse> Send(
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const override;
};
struct RetryOptions
@ -97,8 +99,10 @@ namespace Azure { namespace Core { namespace Http {
return std::make_unique<RetryPolicy>(*this);
}
std::unique_ptr<RawResponse> Send(Context& ctx, Request& request, NextHttpPolicy nextHttpPolicy)
const override;
std::unique_ptr<RawResponse> Send(
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const override;
};
class RequestIdPolicy : public HttpPolicy {
@ -110,8 +114,10 @@ namespace Azure { namespace Core { namespace Http {
return std::make_unique<RequestIdPolicy>(*this);
}
std::unique_ptr<RawResponse> Send(Context& ctx, Request& request, NextHttpPolicy nextHttpPolicy)
const override
std::unique_ptr<RawResponse> Send(
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const override
{
// Do real work here
return nextHttpPolicy.Send(ctx, request);
@ -147,8 +153,10 @@ namespace Azure { namespace Core { namespace Http {
return std::make_unique<TelemetryPolicy>(*this);
}
std::unique_ptr<RawResponse> Send(Context& ctx, Request& request, NextHttpPolicy nextHttpPolicy)
const override;
std::unique_ptr<RawResponse> Send(
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const override;
};
class LoggingPolicy : public HttpPolicy {
@ -160,8 +168,10 @@ namespace Azure { namespace Core { namespace Http {
return std::make_unique<LoggingPolicy>(*this);
}
std::unique_ptr<RawResponse> Send(Context& ctx, Request& request, NextHttpPolicy nextHttpPolicy)
const override;
std::unique_ptr<RawResponse> Send(
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const override;
};
class LogClassification : private Azure::Core::Logging::Details::LogClassificationProvider<

4
sdk/core/azure-core/inc/http/transport.hpp
View File

@ -14,8 +14,8 @@ namespace Azure { namespace Core { namespace Http {
// Any errors in the pipeline throws an exception
// At the top of the pipeline we might want to turn certain responses into exceptions
//TODO - Should this be const
virtual std::unique_ptr<RawResponse> Send(Context& context, Request& request) = 0;
// TODO - Should this be const
virtual std::unique_ptr<RawResponse> Send(Context const& context, Request& request) = 0;
virtual ~HttpTransport() {}
protected:

3
sdk/core/azure-core/inc/http/winhttp/win_http_client.hpp
View File

@ -15,12 +15,11 @@ namespace Azure { namespace Core { namespace Http {
class WinHttpTansport : public HttpTransport {
private:
public:
WinHttpTansport();
~WinHttpTansport();
virtual std::unique_ptr<RawResponse> Send(Context& context, Request& request) ;
virtual std::unique_ptr<RawResponse> Send(Context const& context, Request& request);
};
}}} // namespace Azure::Core::Http

2
sdk/core/azure-core/src/context.cpp
View File

@ -12,7 +12,7 @@ Context& Azure::Core::GetApplicationContext()
return ctx;
}
time_point Context::CancelWhen()
time_point Context::CancelWhen() const
{
auto result = time_point::max();
for (auto ptr = m_contextSharedState; ptr; ptr = ptr->Parent)

2
sdk/core/azure-core/src/credentials/credentials.cpp
View File

@ -38,7 +38,7 @@ std::string UrlEncode(std::string const& s)
} // namespace
AccessToken ClientSecretCredential::GetToken(
Context& context,
Context const& context,
std::vector<std::string> const& scopes) const
{
static std::string const errorMsgPrefix("ClientSecretCredential::GetToken: ");

2
sdk/core/azure-core/src/credentials/policy/policies.cpp
View File

@ -6,7 +6,7 @@
using namespace Azure::Core::Credentials::Policy;
std::unique_ptr<Azure::Core::Http::RawResponse> BearerTokenAuthenticationPolicy::Send(
Context& context,
Context const& context,
Http::Request& request,
Http::NextHttpPolicy policy) const
{

16
sdk/core/azure-core/src/http/body_stream.cpp
View File

@ -23,7 +23,11 @@
using namespace Azure::Core::Http;
// Keep reading until buffer is all fill out of the end of stream content is reached
int64_t BodyStream::ReadToCount(Context& context, BodyStream& body, uint8_t* buffer, int64_t count)
int64_t BodyStream::ReadToCount(
Context const& context,
BodyStream& body,
uint8_t* buffer,
int64_t count)
{
int64_t totalRead = 0;
@ -39,7 +43,7 @@ int64_t BodyStream::ReadToCount(Context& context, BodyStream& body, uint8_t* buf
}
}
std::vector<uint8_t> BodyStream::ReadToEnd(Context& context, BodyStream& body)
std::vector<uint8_t> BodyStream::ReadToEnd(Context const& context, BodyStream& body)
{
constexpr int64_t chunkSize = 1024 * 8;
auto buffer = std::vector<uint8_t>();
@ -58,7 +62,7 @@ std::vector<uint8_t> BodyStream::ReadToEnd(Context& context, BodyStream& body)
}
}
int64_t MemoryBodyStream::Read(Context& context, uint8_t* buffer, int64_t count)
int64_t MemoryBodyStream::Read(Context const& context, uint8_t* buffer, int64_t count)
{
context.ThrowIfCanceled();
@ -73,7 +77,7 @@ int64_t MemoryBodyStream::Read(Context& context, uint8_t* buffer, int64_t count)
#ifdef POSIX
int64_t FileBodyStream::Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count)
int64_t FileBodyStream::Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count)
{
context.ThrowIfCanceled();
@ -89,7 +93,7 @@ int64_t FileBodyStream::Read(Azure::Core::Context& context, uint8_t* buffer, int
#ifdef WINDOWS
int64_t FileBodyStream::Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count)
int64_t FileBodyStream::Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count)
{
context.ThrowIfCanceled();
@ -113,7 +117,7 @@ int64_t FileBodyStream::Read(Azure::Core::Context& context, uint8_t* buffer, int
}
#endif // Windows
int64_t LimitBodyStream::Read(Context& context, uint8_t* buffer, int64_t count)
int64_t LimitBodyStream::Read(Context const& context, uint8_t* buffer, int64_t count)
{
(void)context;
// Read up to count or whatever length is remaining; whichever is less

10
sdk/core/azure-core/src/http/curl/curl.cpp
View File

@ -8,7 +8,7 @@
using namespace Azure::Core::Http;
std::unique_ptr<RawResponse> CurlTransport::Send(Context& context, Request& request)
std::unique_ptr<RawResponse> CurlTransport::Send(Context const& context, Request& request)
{
// Create CurlSession to perform request
auto session = std::make_unique<CurlSession>(request);
@ -39,7 +39,7 @@ std::unique_ptr<RawResponse> CurlTransport::Send(Context& context, Request& requ
return response;
}
CURLcode CurlSession::Perform(Context& context)
CURLcode CurlSession::Perform(Context const& context)
{
AZURE_UNREFERENCED_PARAMETER(context);
@ -249,7 +249,7 @@ CURLcode CurlSession::SendBuffer(uint8_t const* buffer, size_t bufferSize)
return CURLE_OK;
}
CURLcode CurlSession::UploadBody(Context& context)
CURLcode CurlSession::UploadBody(Context const& context)
{
// Send body UploadStreamPageSize at a time (libcurl default)
// NOTE: if stream is on top a contiguous memory, we can avoid allocating this copying buffer
@ -282,7 +282,7 @@ CURLcode CurlSession::UploadBody(Context& context)
}
// custom sending to wire an http request
CURLcode CurlSession::HttpRawSend(Context& context)
CURLcode CurlSession::HttpRawSend(Context const& context)
{
// something like GET /path HTTP1.0 \r\nheaders\r\n
auto rawRequest = this->m_request.GetHTTPMessagePreBody();
@ -431,7 +431,7 @@ void CurlSession::ReadStatusLineAndHeadersFromRawResponse()
}
// Read from curl session
int64_t CurlSession::Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count)
int64_t CurlSession::Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count)
{
context.ThrowIfCanceled();

2
sdk/core/azure-core/src/http/logging_policy.cpp
View File

@ -74,7 +74,7 @@ std::string GetResponseLogMessage(
} // namespace
std::unique_ptr<RawResponse> Azure::Core::Http::LoggingPolicy::Send(
Context& ctx,
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const
{

2
sdk/core/azure-core/src/http/policy.cpp
View File

@ -14,7 +14,7 @@ Azure::Core::Logging::LogClassification const Azure::Core::Http::LogClassificati
Azure::Core::Logging::LogClassification const Azure::Core::Http::LogClassification::Retry;
#endif
std::unique_ptr<RawResponse> NextHttpPolicy::Send(Context& ctx, Request& req)
std::unique_ptr<RawResponse> NextHttpPolicy::Send(Context const& ctx, Request& req)
{
if (m_policies == nullptr)
throw;

2
sdk/core/azure-core/src/http/retry_policy.cpp
View File

@ -126,7 +126,7 @@ bool ShouldRetryOnResponse(
} // namespace
std::unique_ptr<RawResponse> Azure::Core::Http::RetryPolicy::Send(
Context& ctx,
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const
{

2
sdk/core/azure-core/src/http/telemetry_policy.cpp
View File

@ -133,7 +133,7 @@ std::string TelemetryPolicy::BuildTelemetryId(
}
std::unique_ptr<RawResponse> TelemetryPolicy::Send(
Context& ctx,
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const
{

2
sdk/core/azure-core/src/http/transport_policy.cpp
View File

@ -6,7 +6,7 @@
using namespace Azure::Core::Http;
std::unique_ptr<RawResponse> TransportPolicy::Send(
Context& ctx,
Context const& ctx,
Request& request,
NextHttpPolicy nextHttpPolicy) const
{

8
sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp
View File

@ -9,15 +9,11 @@
using namespace Azure::Core::Http;
WinHttpTansport::WinHttpTansport() :
HttpTransport()
{
}
WinHttpTansport::WinHttpTansport() : HttpTransport() {}
WinHttpTansport::~WinHttpTansport() {}
std::unique_ptr<RawResponse> WinHttpTansport::Send(Context& context, Request& request)
std::unique_ptr<RawResponse> WinHttpTansport::Send(Context const& context, Request& request)
{
AZURE_UNREFERENCED_PARAMETER(context);
AZURE_UNREFERENCED_PARAMETER(request);

26
sdk/core/azure-core/test/e2e/azure_core_with_curl_bodyBuffer.cpp
View File

@ -30,13 +30,13 @@ using namespace std;
constexpr auto BufferSize = 50;
std::vector<uint8_t> buffer(BufferSize);
void doGetRequest(Context context, HttpPipeline& pipeline);
void doPutRequest(Context context, HttpPipeline& pipeline);
void doHeadRequest(Context context, HttpPipeline& pipeline);
void doDeleteRequest(Context context, HttpPipeline& pipeline);
void doPatchRequest(Context context, HttpPipeline& pipeline);
void doGetRequest(Context const& context, HttpPipeline& pipeline);
void doPutRequest(Context const& context, HttpPipeline& pipeline);
void doHeadRequest(Context const& context, HttpPipeline& pipeline);
void doDeleteRequest(Context const& context, HttpPipeline& pipeline);
void doPatchRequest(Context const& context, HttpPipeline& pipeline);
void printRespose(std::unique_ptr<Http::RawResponse> response);
void doFileRequest(Context context, HttpPipeline& pipeline);
void doFileRequest(Context const& context, HttpPipeline& pipeline);
int main()
{
@ -74,7 +74,7 @@ int main()
}
#ifdef POSIX
void doFileRequest(Context context, HttpPipeline& pipeline)
void doFileRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/put");
@ -106,7 +106,7 @@ void doFileRequest(Context context, HttpPipeline& pipeline)
#endif // Posix
#ifdef WINDOWS
void doFileRequest(Context context, HttpPipeline& pipeline)
void doFileRequest(Context const& context, HttpPipeline& pipeline)
{
(void)pipeline;
string host("https://httpbin.org/put");
@ -132,7 +132,7 @@ void doFileRequest(Context context, HttpPipeline& pipeline)
}
#endif // Windows
void doGetRequest(Context context, HttpPipeline& pipeline)
void doGetRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/get");
cout << "Creating a GET request to" << endl << "Host: " << host << endl;
@ -148,7 +148,7 @@ void doGetRequest(Context context, HttpPipeline& pipeline)
printRespose(std::move(pipeline.Send(context, request)));
}
void doPutRequest(Context context, HttpPipeline& pipeline)
void doPutRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/put");
cout << "Creating a PUT request to" << endl << "Host: " << host << endl;
@ -209,7 +209,7 @@ void printRespose(std::unique_ptr<Http::RawResponse> response)
return;
}
void doPatchRequest(Context context, HttpPipeline& pipeline)
void doPatchRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/patch");
cout << "Creating an PATCH request to" << endl << "Host: " << host << endl;
@ -221,7 +221,7 @@ void doPatchRequest(Context context, HttpPipeline& pipeline)
printRespose(std::move(pipeline.Send(context, request)));
}
void doDeleteRequest(Context context, HttpPipeline& pipeline)
void doDeleteRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/delete");
cout << "Creating an DELETE request to" << endl << "Host: " << host << endl;
@ -233,7 +233,7 @@ void doDeleteRequest(Context context, HttpPipeline& pipeline)
printRespose(std::move(pipeline.Send(context, request)));
}
void doHeadRequest(Context context, HttpPipeline& pipeline)
void doHeadRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/get");
cout << "Creating an HEAD request to" << endl << "Host: " << host << endl;

22
sdk/core/azure-core/test/e2e/azure_core_with_curl_bodyStream.cpp
View File

@ -28,11 +28,11 @@ std::vector<uint8_t> buffer(BufferSize);
constexpr auto StreamSize = 1024; // 100 MB
std::array<uint8_t, StreamSize> bufferStream;
void doGetRequest(Context context, HttpPipeline& pipeline);
void doNoPathGetRequest(Context context, HttpPipeline& pipeline);
void doPutRequest(Context context, HttpPipeline& pipeline);
void doPutStreamRequest(Context context, HttpPipeline& pipeline);
void printStream(Azure::Core::Context& context, std::unique_ptr<Http::RawResponse> response);
void doGetRequest(Context const& context, HttpPipeline& pipeline);
void doNoPathGetRequest(Context const& context, HttpPipeline& pipeline);
void doPutRequest(Context const& context, HttpPipeline& pipeline);
void doPutStreamRequest(Context const& context, HttpPipeline& pipeline);
void printStream(Azure::Core::Context const& context, std::unique_ptr<Http::RawResponse> response);
int main()
{
@ -74,7 +74,7 @@ int main()
}
// Request GET with no path
void doNoPathGetRequest(Context context, HttpPipeline& pipeline)
void doNoPathGetRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org");
cout << "Creating a GET request to" << endl << "Host: " << host << endl;
@ -86,7 +86,7 @@ void doNoPathGetRequest(Context context, HttpPipeline& pipeline)
}
// Request GET with no body that produces stream response
void doGetRequest(Context context, HttpPipeline& pipeline)
void doGetRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/get//////?arg=1&arg2=2");
cout << "Creating a GET request to" << endl << "Host: " << host << endl;
@ -106,7 +106,7 @@ void doGetRequest(Context context, HttpPipeline& pipeline)
}
// Put Request with bodyBufferBody that produces stream
void doPutRequest(Context context, HttpPipeline& pipeline)
void doPutRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://httpbin.org/put/?a=1");
cout << "Creating a PUT request to" << endl << "Host: " << host << endl;
@ -132,7 +132,7 @@ void doPutRequest(Context context, HttpPipeline& pipeline)
}
// Put Request with stream body that produces stream
void doPutStreamRequest(Context context, HttpPipeline& pipeline)
void doPutStreamRequest(Context const& context, HttpPipeline& pipeline)
{
string host("https://putsreq.com/SDywlz7z6j90bJFNvyTO");
cout << "Creating a PUT request to" << endl << "Host: " << host << endl;
@ -162,7 +162,7 @@ void doPutStreamRequest(Context context, HttpPipeline& pipeline)
printStream(context, std::move(pipeline.Send(context, request)));
}
void printStream(Context& context, std::unique_ptr<Http::RawResponse> response)
void printStream(Context const& context, std::unique_ptr<Http::RawResponse> response)
{
if (response == nullptr)
{
@ -172,7 +172,7 @@ void printStream(Context& context, std::unique_ptr<Http::RawResponse> response)
}
cout << static_cast<typename std::underlying_type<Http::HttpStatusCode>::type>(
response->GetStatusCode())
response->GetStatusCode())
<< endl;
cout << response->GetReasonPhrase() << endl;
cout << "headers:" << endl;

2
sdk/core/azure-core/test/ut/telemetry_policy.cpp
View File

@ -11,7 +11,7 @@ using namespace Azure::Core::Http;
namespace {
class NoOpPolicy : public HttpPolicy {
std::unique_ptr<RawResponse> Send(Context& context, Request& request, NextHttpPolicy policy)
std::unique_ptr<RawResponse> Send(Context const& context, Request& request, NextHttpPolicy policy)
const override
{
(void)context;

2
sdk/storage/inc/common/common_headers_request_policy.hpp
View File

@ -18,7 +18,7 @@ namespace Azure { namespace Storage {
}
std::unique_ptr<Core::Http::RawResponse> Send(
Core::Context& ctx,
Core::Context const& ctx,
Core::Http::Request& request,
Core::Http::NextHttpPolicy nextHttpPolicy) const override;
};

7
sdk/storage/inc/common/reliable_stream.hpp
View File

@ -16,8 +16,9 @@ namespace Azure { namespace Storage {
};
// Defines a fn signature to be use to get a bodyStream from an specific offset.
typedef std::function<
std::unique_ptr<Azure::Core::Http::BodyStream>(Azure::Core::Context&, HTTPGetterInfo const&)>
typedef std::function<std::unique_ptr<Azure::Core::Http::BodyStream>(
Azure::Core::Context const&,
HTTPGetterInfo const&)>
HTTPGetter;
// Options used by reliable stream
@ -68,7 +69,7 @@ namespace Azure { namespace Storage {
this->m_inner->Rewind();
this->m_retryInfo.Offset = 0;
}
int64_t Read(Azure::Core::Context& context, uint8_t* buffer, int64_t count) override;
int64_t Read(Azure::Core::Context const& context, uint8_t* buffer, int64_t count) override;
};
}} // namespace Azure::Storage

2
sdk/storage/inc/common/shared_key_policy.hpp
View File

@ -23,7 +23,7 @@ namespace Azure { namespace Storage {
}
std::unique_ptr<Core::Http::RawResponse> Send(
Core::Context& ctx,
Core::Context const& ctx,
Core::Http::Request& request,
Core::Http::NextHttpPolicy nextHttpPolicy) const override
{

2
sdk/storage/src/common/common_headers_request_policy.cpp
View File

@ -10,7 +10,7 @@
namespace Azure { namespace Storage {
std::unique_ptr<Core::Http::RawResponse> CommonHeadersRequestPolicy::Send(
Core::Context& ctx,
Core::Context const& ctx,
Core::Http::Request& request,
Core::Http::NextHttpPolicy nextHttpPolicy) const
{

2
sdk/storage/src/common/reliable_stream.cpp
View File

@ -9,7 +9,7 @@ using Azure::Core::Http::BodyStream;
namespace Azure { namespace Storage {
int64_t ReliableStream::Read(Context& context, uint8_t* buffer, int64_t count)
int64_t ReliableStream::Read(Context const& context, uint8_t* buffer, int64_t count)
{
if (this->m_options.DoInjectError)
{