github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

remove value policy from core (#1917)

Browse Source
This commit is contained in:
Victor Vazquez 2021-03-23 15:31:54 -07:00 committed by GitHub
parent b6c354f435
commit d6cd0af3cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 83 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
View File

@ -427,59 +427,4 @@ namespace Azure { namespace Core { namespace Http { namespace Policies {
Context const& ctx) const override;
};
namespace _internal {
/**
* @brief #Azure::Core::Http::Policies::_internal::ValuePolicy options.
*/
struct ValueOptions
{
CaseInsensitiveMap HeaderValues;
std::map<std::string, std::string> QueryValues;
};
/**
* @brief Value policy.
*
* @details Applies key-value pair values to each HTTP request (either HTTP headers or query
* parameters).
*/
class ValuePolicy : public HttpPolicy {
private:
ValueOptions m_options;
public:
/**
* @brief Construct a #Azure::Core::Http::Policies::_internal::ValuePolicy with the
* #Azure::Core::Http::Policies::_internal::ValueOptions provided.
* @param options #Azure::Core::Http::Policies::_internal::ValueOptions.
*/
explicit ValuePolicy(ValueOptions options) : m_options(std::move(options)) {}
std::unique_ptr<HttpPolicy> Clone() const override
{
return std::make_unique<ValuePolicy>(*this);
}
std::unique_ptr<RawResponse> Send(
Request& request,
NextHttpPolicy nextHttpPolicy,
Context const& ctx) const override
{
for (auto const& hdrPair : m_options.HeaderValues)
{
request.SetHeader(hdrPair.first, hdrPair.second);
}
{
auto& url = request.GetUrl();
for (auto const& qryPair : m_options.QueryValues)
{
url.AppendQueryParameter(qryPair.first, qryPair.second);
}
}
return nextHttpPolicy.Send(request, ctx);
}
};
} // namespace _internal
}}}} // namespace Azure::Core::Http::Policies

28
sdk/core/azure-core/test/ut/policy.cpp
View File

@ -124,34 +124,6 @@ TEST(Policy, throwWhenNoTransportPolicyMessage)
}
}
TEST(Policy, ValuePolicy)
{
using namespace Azure::Core;
using namespace Azure::Core::Http;
using namespace Azure::Core::Http::Policies;
using namespace Azure::Core::Http::_internal;
Azure::Core::Http::Policies::_internal::ValueOptions options
= {{{"hdrkey1", "HdrVal1"}, {"hdrkey2", "HdrVal2"}},
{{"QryKey1", "QryVal1"}, {"QryKey2", "QryVal2"}}};
std::vector<std::unique_ptr<HttpPolicy>> policies;
policies.emplace_back(
std::make_unique<Azure::Core::Http::Policies::_internal::ValuePolicy>(options));
policies.emplace_back(std::make_unique<NoOpPolicy>());
HttpPipeline pipeline(policies);
Request request(HttpMethod::Get, Url("https:://www.example.com"));
pipeline.Send(request, Context::GetApplicationContext());
auto headers = request.GetHeaders();
auto queryParams = request.GetUrl().GetQueryParameters();
ASSERT_EQ(headers, decltype(headers)({{"hdrkey1", "HdrVal1"}, {"hdrkey2", "HdrVal2"}}));
ASSERT_EQ(queryParams, decltype(queryParams)({{"QryKey1", "QryVal1"}, {"QryKey2", "QryVal2"}}));
}
TEST(Policy, RetryPolicyCounter)
{
using namespace Azure::Core;