diff --git a/sdk/storage/azure-storage-blobs/src/blob_batch_client.cpp b/sdk/storage/azure-storage-blobs/src/blob_batch_client.cpp index 27d71e911..442aaf48c 100644 --- a/sdk/storage/azure-storage-blobs/src/blob_batch_client.cpp +++ b/sdk/storage/azure-storage-blobs/src/blob_batch_client.cpp @@ -98,13 +98,13 @@ namespace Azure { namespace Storage { namespace Blobs { policies.emplace_back(p->Clone()); } policies.emplace_back( - std::make_unique(options.RetryOptions)); + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -118,8 +118,8 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back(std::make_unique()); m_subRequestPipeline = std::make_shared(policies); } @@ -139,12 +139,12 @@ namespace Azure { namespace Storage { namespace Blobs { policies.emplace_back(p->Clone()); } policies.emplace_back( - std::make_unique(options.RetryOptions)); + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Storage::Details::StorageScope)); policies.emplace_back( @@ -160,7 +160,7 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Storage::Details::StorageScope)); policies.emplace_back(std::make_unique()); @@ -179,12 +179,12 @@ namespace Azure { namespace Storage { namespace Blobs { policies.emplace_back(p->Clone()); } policies.emplace_back( - std::make_unique(options.RetryOptions)); + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -198,7 +198,7 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique()); m_subRequestPipeline = std::make_shared(policies); } diff --git a/sdk/storage/azure-storage-blobs/src/blob_client.cpp b/sdk/storage/azure-storage-blobs/src/blob_client.cpp index 3d1c9be60..a10334862 100644 --- a/sdk/storage/azure-storage-blobs/src/blob_client.cpp +++ b/sdk/storage/azure-storage-blobs/src/blob_client.cpp @@ -54,13 +54,14 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -80,12 +81,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Storage::Details::StorageScope)); policies.emplace_back( @@ -105,12 +107,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-blobs/src/blob_container_client.cpp b/sdk/storage/azure-storage-blobs/src/blob_container_client.cpp index b712fde9f..afcaea8b5 100644 --- a/sdk/storage/azure-storage-blobs/src/blob_container_client.cpp +++ b/sdk/storage/azure-storage-blobs/src/blob_container_client.cpp @@ -50,13 +50,14 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -76,12 +77,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Storage::Details::StorageScope)); policies.emplace_back( @@ -103,12 +105,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-blobs/src/blob_service_client.cpp b/sdk/storage/azure-storage-blobs/src/blob_service_client.cpp index 89fcbfb1e..f1cff7019 100644 --- a/sdk/storage/azure-storage-blobs/src/blob_service_client.cpp +++ b/sdk/storage/azure-storage-blobs/src/blob_service_client.cpp @@ -45,13 +45,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back(std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -71,12 +71,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Storage::Details::StorageScope)); policies.emplace_back( @@ -97,12 +98,13 @@ namespace Azure { namespace Storage { namespace Blobs { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-common/CHANGELOG.md b/sdk/storage/azure-storage-common/CHANGELOG.md index ea8cc2ab5..67318a508 100644 --- a/sdk/storage/azure-storage-common/CHANGELOG.md +++ b/sdk/storage/azure-storage-common/CHANGELOG.md @@ -4,6 +4,8 @@ * Rename `SharedKeyCredential` to `StorageSharedKeyCredential`. * Rename `StorageSharedKeyCredential::UpdateAccountKey` to `StorageSharedKeyCredential::Update`. +* Move `StorageRetryPolicy`, `StoragePerRetryPolicy` and `SharedKeyPolicy` to `Details` namespace. +* Remove `StorageRetryOptions`, use `Azure::Core::Http::RetryOptions` instead. ## 12.0.0-beta.5 (2020-11-13) diff --git a/sdk/storage/azure-storage-common/inc/azure/storage/common/shared_key_policy.hpp b/sdk/storage/azure-storage-common/inc/azure/storage/common/shared_key_policy.hpp index 378e69a68..9d8abbedb 100644 --- a/sdk/storage/azure-storage-common/inc/azure/storage/common/shared_key_policy.hpp +++ b/sdk/storage/azure-storage-common/inc/azure/storage/common/shared_key_policy.hpp @@ -6,7 +6,7 @@ #include "azure/core/http/policy.hpp" #include "azure/storage/common/storage_credential.hpp" -namespace Azure { namespace Storage { +namespace Azure { namespace Storage { namespace Details { class SharedKeyPolicy : public Core::Http::HttpPolicy { public: @@ -38,4 +38,4 @@ namespace Azure { namespace Storage { std::shared_ptr m_credential; }; -}} // namespace Azure::Storage +}}} // namespace Azure::Storage::Details diff --git a/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_credential.hpp b/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_credential.hpp index aef358aa2..d36a47779 100644 --- a/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_credential.hpp +++ b/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_credential.hpp @@ -24,6 +24,9 @@ namespace Azure { namespace Storage { struct DataLakeSasBuilder; } } // namespace Files + namespace Details { + class SharedKeyPolicy; + } /** * @brief A StorageSharedKeyCredential is a credential backed by a storage account's name and one @@ -61,7 +64,7 @@ namespace Azure { namespace Storage { const std::string AccountName; private: - friend class SharedKeyPolicy; + friend class Details::SharedKeyPolicy; friend struct Blobs::BlobSasBuilder; friend struct Files::Shares::ShareSasBuilder; friend struct Files::DataLake::DataLakeSasBuilder; diff --git a/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_per_retry_policy.hpp b/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_per_retry_policy.hpp index daa20187e..7456bd495 100644 --- a/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_per_retry_policy.hpp +++ b/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_per_retry_policy.hpp @@ -5,7 +5,7 @@ #include "azure/core/http/policy.hpp" -namespace Azure { namespace Storage { +namespace Azure { namespace Storage { namespace Details { class StoragePerRetryPolicy : public Core::Http::HttpPolicy { public: @@ -22,4 +22,4 @@ namespace Azure { namespace Storage { Core::Http::NextHttpPolicy nextHttpPolicy) const override; }; -}} // namespace Azure::Storage +}}} // namespace Azure::Storage::Details diff --git a/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_retry_policy.hpp b/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_retry_policy.hpp index 978943fc0..fe268a4d8 100644 --- a/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_retry_policy.hpp +++ b/sdk/storage/azure-storage-common/inc/azure/storage/common/storage_retry_policy.hpp @@ -10,43 +10,11 @@ namespace Azure { namespace Storage { - /** - * StorageRetryOptions configures the retry policy's behavior. - */ - struct StorageRetryOptions - { - /** - * @brief Maximum number of attempts to retry. - */ - int MaxRetries = 3; - - /** - * @brief Mimimum amount of time between retry attempts. - */ - std::chrono::milliseconds RetryDelay = std::chrono::seconds(4); - - /** - * @brief Maximum amount of time between retry attempts. - */ - std::chrono::milliseconds MaxRetryDelay = std::chrono::minutes(2); - - /** - * @brief HTTP status codes to retry on. - */ - std::vector StatusCodes{ - Azure::Core::Http::HttpStatusCode::RequestTimeout, - Azure::Core::Http::HttpStatusCode::InternalServerError, - Azure::Core::Http::HttpStatusCode::BadGateway, - Azure::Core::Http::HttpStatusCode::ServiceUnavailable, - Azure::Core::Http::HttpStatusCode::GatewayTimeout, - }; - }; - /** * StorageRetryWithSecondaryOptions configures whether the retry policy should retry a read * operation against another host. */ - struct StorageRetryWithSecondaryOptions : public StorageRetryOptions + struct StorageRetryWithSecondaryOptions : public Core::Http::RetryOptions { /** * SecondaryHostForRetryReads specifies whether the retry policy should retry a read @@ -58,33 +26,37 @@ namespace Azure { namespace Storage { std::string SecondaryHostForRetryReads; }; - class StorageRetryPolicy : public Azure::Core::Http::HttpPolicy { - public: - explicit StorageRetryPolicy(const StorageRetryOptions& options) - { - m_options.MaxRetries = options.MaxRetries; - m_options.RetryDelay = options.RetryDelay; - m_options.MaxRetryDelay = options.MaxRetryDelay; - m_options.StatusCodes = options.StatusCodes; - } + namespace Details { - explicit StorageRetryPolicy(const StorageRetryWithSecondaryOptions& options) - : m_options(options) - { - } + class StorageRetryPolicy : public Azure::Core::Http::HttpPolicy { + public: + explicit StorageRetryPolicy(const Core::Http::RetryOptions& options) + { + m_options.MaxRetries = options.MaxRetries; + m_options.RetryDelay = options.RetryDelay; + m_options.MaxRetryDelay = options.MaxRetryDelay; + m_options.StatusCodes = options.StatusCodes; + } - std::unique_ptr Clone() const override - { - return std::make_unique(*this); - } + explicit StorageRetryPolicy(const StorageRetryWithSecondaryOptions& options) + : m_options(options) + { + } - std::unique_ptr Send( - const Azure::Core::Context& ctx, - Azure::Core::Http::Request& request, - Azure::Core::Http::NextHttpPolicy nextHttpPolicy) const override; + std::unique_ptr Clone() const override + { + return std::make_unique(*this); + } - private: - StorageRetryWithSecondaryOptions m_options; - }; + std::unique_ptr Send( + const Azure::Core::Context& ctx, + Azure::Core::Http::Request& request, + Azure::Core::Http::NextHttpPolicy nextHttpPolicy) const override; + + private: + StorageRetryWithSecondaryOptions m_options; + }; + + } // namespace Details }} // namespace Azure::Storage diff --git a/sdk/storage/azure-storage-common/src/shared_key_policy.cpp b/sdk/storage/azure-storage-common/src/shared_key_policy.cpp index fffb685f3..28257fdb2 100644 --- a/sdk/storage/azure-storage-common/src/shared_key_policy.cpp +++ b/sdk/storage/azure-storage-common/src/shared_key_policy.cpp @@ -10,7 +10,8 @@ #include #include -namespace Azure { namespace Storage { +namespace Azure { namespace Storage { namespace Details { + std::string SharedKeyPolicy::GetSignature(const Core::Http::Request& request) const { std::string string_to_sign; @@ -82,4 +83,4 @@ namespace Azure { namespace Storage { return Base64Encode( Details::HmacSha256(string_to_sign, Base64Decode(m_credential->GetAccountKey()))); } -}} // namespace Azure::Storage +}}} // namespace Azure::Storage::Details diff --git a/sdk/storage/azure-storage-common/src/storage_per_retry_policy.cpp b/sdk/storage/azure-storage-common/src/storage_per_retry_policy.cpp index c7556b5cf..f2554033d 100644 --- a/sdk/storage/azure-storage-common/src/storage_per_retry_policy.cpp +++ b/sdk/storage/azure-storage-common/src/storage_per_retry_policy.cpp @@ -5,7 +5,7 @@ #include -namespace Azure { namespace Storage { +namespace Azure { namespace Storage { namespace Details { std::unique_ptr StoragePerRetryPolicy::Send( Core::Context const& ctx, @@ -42,4 +42,4 @@ namespace Azure { namespace Storage { return nextHttpPolicy.Send(ctx, request); } -}} // namespace Azure::Storage +}}} // namespace Azure::Storage::Details diff --git a/sdk/storage/azure-storage-common/src/storage_retry_policy.cpp b/sdk/storage/azure-storage-common/src/storage_retry_policy.cpp index 24c4ee6db..7815ce269 100644 --- a/sdk/storage/azure-storage-common/src/storage_retry_policy.cpp +++ b/sdk/storage/azure-storage-common/src/storage_retry_policy.cpp @@ -6,7 +6,7 @@ #include -namespace Azure { namespace Storage { +namespace Azure { namespace Storage { namespace Details { std::unique_ptr StorageRetryPolicy::Send( const Azure::Core::Context& ctx, @@ -131,4 +131,4 @@ namespace Azure { namespace Storage { return pResponse; } -}} // namespace Azure::Storage +}}} // namespace Azure::Storage::Details diff --git a/sdk/storage/azure-storage-files-datalake/src/datalake_directory_client.cpp b/sdk/storage/azure-storage-files-datalake/src/datalake_directory_client.cpp index 372dc8d93..ad490ec8d 100644 --- a/sdk/storage/azure-storage-files-datalake/src/datalake_directory_client.cpp +++ b/sdk/storage/azure-storage-files-datalake/src/datalake_directory_client.cpp @@ -59,14 +59,14 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -89,12 +89,12 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Azure::Storage::Details::StorageScope)); policies.emplace_back( @@ -118,12 +118,12 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp b/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp index 40f3bad1b..86cbcc3c3 100644 --- a/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp +++ b/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp @@ -137,14 +137,14 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -168,13 +168,13 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Azure::Storage::Details::StorageScope)); policies.emplace_back( @@ -196,13 +196,13 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-datalake/src/datalake_file_system_client.cpp b/sdk/storage/azure-storage-files-datalake/src/datalake_file_system_client.cpp index 830eac598..c417b90b5 100644 --- a/sdk/storage/azure-storage-files-datalake/src/datalake_file_system_client.cpp +++ b/sdk/storage/azure-storage-files-datalake/src/datalake_file_system_client.cpp @@ -80,14 +80,14 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -114,13 +114,13 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Azure::Storage::Details::StorageScope)); policies.emplace_back( @@ -147,13 +147,13 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-datalake/src/datalake_path_client.cpp b/sdk/storage/azure-storage-files-datalake/src/datalake_path_client.cpp index 10d4c0905..da9fd8549 100644 --- a/sdk/storage/azure-storage-files-datalake/src/datalake_path_client.cpp +++ b/sdk/storage/azure-storage-files-datalake/src/datalake_path_client.cpp @@ -121,14 +121,14 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -152,13 +152,13 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Azure::Storage::Details::StorageScope)); policies.emplace_back( @@ -181,8 +181,8 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique()); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); diff --git a/sdk/storage/azure-storage-files-datalake/src/datalake_service_client.cpp b/sdk/storage/azure-storage-files-datalake/src/datalake_service_client.cpp index 3f82bbff4..5c4f6b017 100644 --- a/sdk/storage/azure-storage-files-datalake/src/datalake_service_client.cpp +++ b/sdk/storage/azure-storage-files-datalake/src/datalake_service_client.cpp @@ -89,13 +89,13 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -121,12 +121,12 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back(std::make_unique( credential, Azure::Storage::Details::StorageScope)); policies.emplace_back( @@ -152,12 +152,12 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { StorageRetryWithSecondaryOptions dfsRetryOptions = options.RetryOptions; dfsRetryOptions.SecondaryHostForRetryReads = Details::GetDfsUriFromUri(options.RetryOptions.SecondaryHostForRetryReads); - policies.emplace_back(std::make_unique(dfsRetryOptions)); + policies.emplace_back(std::make_unique(dfsRetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp b/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp index 913f132b4..20181baa6 100644 --- a/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp +++ b/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp @@ -37,7 +37,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { /** * @brief Specify the number of retries and other retry-related options. */ - StorageRetryOptions RetryOptions; + Core::Http::RetryOptions RetryOptions; /** * @brief Customized HTTP client. We're going to use the default one if this is empty. diff --git a/sdk/storage/azure-storage-files-shares/src/share_client.cpp b/sdk/storage/azure-storage-files-shares/src/share_client.cpp index 5454d023e..b7770bc44 100644 --- a/sdk/storage/azure-storage-files-shares/src/share_client.cpp +++ b/sdk/storage/azure-storage-files-shares/src/share_client.cpp @@ -51,13 +51,13 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back(std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -74,12 +74,13 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-shares/src/share_directory_client.cpp b/sdk/storage/azure-storage-files-shares/src/share_directory_client.cpp index 2e1890c05..3f2c77161 100644 --- a/sdk/storage/azure-storage-files-shares/src/share_directory_client.cpp +++ b/sdk/storage/azure-storage-files-shares/src/share_directory_client.cpp @@ -52,13 +52,14 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -77,12 +78,13 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-shares/src/share_file_client.cpp b/sdk/storage/azure-storage-files-shares/src/share_file_client.cpp index ca0175881..670ede7f5 100644 --- a/sdk/storage/azure-storage-files-shares/src/share_file_client.cpp +++ b/sdk/storage/azure-storage-files-shares/src/share_file_client.cpp @@ -55,13 +55,14 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -78,12 +79,12 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); diff --git a/sdk/storage/azure-storage-files-shares/src/share_service_client.cpp b/sdk/storage/azure-storage-files-shares/src/share_service_client.cpp index 4a394b772..c9f189c7f 100644 --- a/sdk/storage/azure-storage-files-shares/src/share_service_client.cpp +++ b/sdk/storage/azure-storage-files-shares/src/share_service_client.cpp @@ -47,13 +47,14 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique(options.RetryOptions)); + policies.emplace_back( + std::make_unique(options.RetryOptions)); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); - policies.emplace_back(std::make_unique(credential)); + policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique(credential)); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies); @@ -72,12 +73,12 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); for (const auto& p : options.PerRetryPolicies) { policies.emplace_back(p->Clone()); } - policies.emplace_back(std::make_unique()); + policies.emplace_back(std::make_unique()); policies.emplace_back( std::make_unique(options.TransportPolicyOptions)); m_pipeline = std::make_shared(policies);