github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Test that a connection won't be moved to the connection pool if uploading fails (#910)

Browse Source 
Fixes: https://github.com/Azure/azure-sdk-for-cpp/issues/905
This commit is contained in:
Victor Vazquez 2020-11-06 12:36:27 -08:00 committed by GitHub
parent 66f4d223a8
commit c48bb033af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/core/azure-core/CHANGELOG.md
View File

@ -21,7 +21,7 @@
### Bug Fixes
- Prevent pipeline of length zero to be created.
- Avoid re-using a connection when an uploading request fail when using CurlTransport.
- Avoid re-using a connection when a request to upload data fails while using the `CurlTransport`.
### New Features

31
sdk/core/azure-core/test/ut/curl_session_test.cpp
View File

@ -6,6 +6,8 @@
#include <azure/core/http/curl/curl.hpp>
#include <azure/core/http/http.hpp>
#include <curl/curl.h>
using ::testing::_;
using ::testing::DoAll;
using ::testing::Return;
@ -78,4 +80,33 @@ namespace Azure { namespace Core { namespace Test {
// Clear the connections from the pool to invoke clean routine
Azure::Core::Http::CurlConnectionPool::ConnectionPoolIndex.clear();
}
TEST_F(CurlSession, DoNotReuseConnectionIfDownloadFail)
{
// Can't mock the curlMock directly from a unique ptr, heap allocate it first and then make a
// unique ptr for it
MockCurlNetworkConnection* curlMock = new MockCurlNetworkConnection();
// mock an upload error
EXPECT_CALL(*curlMock, SendBuffer(_, _, _)).WillOnce(Return(CURLE_SEND_ERROR));
EXPECT_CALL(*curlMock, DestructObj());
// Create the unique ptr to take care about memory free at the end
std::unique_ptr<MockCurlNetworkConnection> uniqueCurlMock(curlMock);
// Simulate a request to be sent
Azure::Core::Http::Url url("http://microsoft.com");
Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Get, url);
{
// Create the session inside scope so it is released and the connection is moved to the pool
auto session = std::make_unique<Azure::Core::Http::CurlSession>(
request, std::move(uniqueCurlMock), true);
auto returnCode = session->Perform(Azure::Core::GetApplicationContext());
EXPECT_EQ(CURLE_SEND_ERROR, returnCode);
}
// Check connection pool is empty (connection was not moved to the pool)
EXPECT_EQ(Azure::Core::Http::CurlConnectionPool::ConnectionPoolIndex.size(), 0);
}
}}} // namespace Azure::Core::Test