From b4fa6b835a149c3a9edbaacb6aec12d0533bc8c6 Mon Sep 17 00:00:00 2001 From: JinmingHu Date: Wed, 12 May 2021 17:05:03 +0800 Subject: [PATCH] Fix stream leak issue (#2257) * Fix stream leak issue * cl --- sdk/storage/azure-storage-common/CHANGELOG.md | 6 ++++++ sdk/storage/azure-storage-common/src/reliable_stream.cpp | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/sdk/storage/azure-storage-common/CHANGELOG.md b/sdk/storage/azure-storage-common/CHANGELOG.md index 6cb68fc41..c5dc307e5 100644 --- a/sdk/storage/azure-storage-common/CHANGELOG.md +++ b/sdk/storage/azure-storage-common/CHANGELOG.md @@ -2,8 +2,14 @@ ## 12.0.0-beta.11 (Unreleased) +### Breaking Changes + - Removed `Azure::PagedResponse`. +### Bug Fixes + +- Fixed a stream leak issue in `ReliableStream`. + ## 12.0.0-beta.10 (2021-04-16) ### New Features diff --git a/sdk/storage/azure-storage-common/src/reliable_stream.cpp b/sdk/storage/azure-storage-common/src/reliable_stream.cpp index d3918defb..4e6d1ed9a 100644 --- a/sdk/storage/azure-storage-common/src/reliable_stream.cpp +++ b/sdk/storage/azure-storage-common/src/reliable_stream.cpp @@ -36,7 +36,7 @@ namespace Azure { namespace Storage { namespace _internal { // forget about the inner stream. We will need to request a new one // As m_inner is unique_pr, it will be destructed on reassignment (cleaning up network // session). - this->m_inner.release(); + this->m_inner.reset(); (void)e; // todo: maybe log the exception in the future? if (intent == this->m_options.MaxRetryRequests) {