From b2a21c665db87808188fe4347bd72b3432ad9151 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Lind?= Date: Wed, 9 Jun 2021 09:42:40 +0200 Subject: [PATCH] Fix small "Use after free" bug (#2409) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jørgen Lind --- sdk/core/azure-core/src/base64.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/core/azure-core/src/base64.cpp b/sdk/core/azure-core/src/base64.cpp index dfed364c0..d447c4ca5 100644 --- a/sdk/core/azure-core/src/base64.cpp +++ b/sdk/core/azure-core/src/base64.cpp @@ -67,10 +67,11 @@ namespace Azure { namespace Core { BIO_flush(bio); BUF_MEM* bufferPtr; BIO_get_mem_ptr(bio, &bufferPtr); + std::string toReturn(bufferPtr->data, bufferPtr->length); BIO_set_close(bio, BIO_NOCLOSE); BIO_free_all(bio); - return std::string(bufferPtr->data, bufferPtr->length); + return toReturn; } std::vector Convert::Base64Decode(const std::string& text)