diff --git a/CMakeSettings.json b/CMakeSettings.json index e963a50af..12fe40e82 100644 --- a/CMakeSettings.json +++ b/CMakeSettings.json @@ -89,11 +89,6 @@ "name": "BUILD_PERFORMANCE_TESTS", "value": "true", "type": "BOOL" - }, - { - "name": "CMAKE_BUILD_TYPE", - "value": "MinSizeRel", - "type": "STRING" } ] }, @@ -137,11 +132,6 @@ "name": "BUILD_PERFORMANCE_TESTS", "value": "True", "type": "BOOL" - }, - { - "name": "CMAKE_BUILD_TYPE", - "value": "MinSizeRel", - "type": "STRING" } ] }, @@ -180,11 +170,6 @@ "name": "BUILD_PERFORMANCE_TESTS", "value": "True", "type": "BOOL" - }, - { - "name": "CMAKE_BUILD_TYPE", - "value": "MinSizeRel", - "type": "STRING" } ] }, @@ -218,11 +203,6 @@ "name": "BUILD_PERFORMANCE_TESTS", "value": "True", "type": "BOOL" - }, - { - "name": "CMAKE_BUILD_TYPE", - "value": "MinSizeRel", - "type": "STRING" } ] } diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md index b63308869..40f94b394 100644 --- a/sdk/core/azure-core/CHANGELOG.md +++ b/sdk/core/azure-core/CHANGELOG.md @@ -11,6 +11,7 @@ - Removed `Azure::Core::Http::HttpPipeline` by making it internal, used only within the SDK. - Split `Azure::Core::RequestConditions` into `Azure::Core::MatchConditions` and `Azure::Core::ModifiedConditions`. - Removed `TransportKind` enum from `Azure::Core::Http`. +- Added `Azure::Core::Operation::GetRawResponse().` - Renamed `NoRevoke` to `EnableCertificateRevocationListCheck` for `Azure::Core::Http::CurlTransportSSLOptions`. - Renamed `GetString()` to `ToString()` in `Azure::Core::DateTime`. - Renamed `GetUuidString()` to `ToString()` in `Azure::Core::Uuid`. diff --git a/sdk/core/azure-core/inc/azure/core/operation.hpp b/sdk/core/azure-core/inc/azure/core/operation.hpp index b51221948..c16990042 100644 --- a/sdk/core/azure-core/inc/azure/core/operation.hpp +++ b/sdk/core/azure-core/inc/azure/core/operation.hpp @@ -51,6 +51,13 @@ namespace Azure { namespace Core { */ virtual std::string GetResumeToken() const = 0; + /** + * @brief Get the raw HTTP response. + * @return A pointer to #Azure::Core::Http::RawResponse. + * @note Does not give up ownership of the RawResponse. + */ + virtual Azure::Core::Http::RawResponse* GetRawResponse() const = 0; + /** * @brief Returns the current #Azure::Core::OperationStatus of the long-running operation. */ diff --git a/sdk/core/azure-core/test/ut/operation_test.hpp b/sdk/core/azure-core/test/ut/operation_test.hpp index 7c60dbff4..08c38a4b4 100644 --- a/sdk/core/azure-core/test/ut/operation_test.hpp +++ b/sdk/core/azure-core/test/ut/operation_test.hpp @@ -19,9 +19,9 @@ namespace Azure { namespace Core { namespace Test { class StringOperation : public Operation { private: - StringClient* m_client; std::string m_operationToken; std::string m_value; + std::unique_ptr m_rawResponse; private: int m_count = 0; @@ -58,7 +58,7 @@ namespace Azure { namespace Core { namespace Test { } public: - StringOperation(StringClient* client) : m_client(client) { (void)m_client; } + Azure::Core::Http::RawResponse* GetRawResponse() const override { return m_rawResponse.get(); } std::string GetResumeToken() const override { return m_operationToken; } @@ -82,7 +82,7 @@ namespace Azure { namespace Core { namespace Test { StringOperation StartStringUpdate() { // Make initial String call - StringOperation operation = StringOperation(this); + StringOperation operation = StringOperation(); return operation; } }; diff --git a/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/delete_key_operation.hpp b/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/delete_key_operation.hpp index 6aaea7e88..9aee9b324 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/delete_key_operation.hpp +++ b/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/delete_key_operation.hpp @@ -77,6 +77,12 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { Azure::Core::Response response); public: + /** + * @brief Get the #Azure::Core::Http::RawResponse of the operation request. + * @return A pointer to #Azure::Core::Http::RawResponse or null. + */ + Azure::Core::Http::RawResponse* GetRawResponse() const override { return m_rawResponse.get(); } + /** * @brief Get the #Azure::Security::KeyVault::Keys::DeletedKey object. * diff --git a/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_responses.hpp b/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_responses.hpp index 09f05759a..3eb287ca5 100644 --- a/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_responses.hpp +++ b/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_responses.hpp @@ -82,6 +82,17 @@ namespace Azure { namespace Storage { namespace Blobs { public: Models::GetBlobPropertiesResult Value() const override { return m_pollResult; } + /** + * @brief Get the raw HTTP response. + * @return A pointer to #Azure::Core::Http::RawResponse. + * @note Does not give up ownership of the RawResponse. + */ + Azure::Core::Http::RawResponse* GetRawResponse() const override + { + // TODO: Fix to return the rawResponse + return nullptr; + } + ~StartCopyBlobOperation() override {} private: diff --git a/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp b/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp index e84a0b30c..a13e68f09 100644 --- a/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp +++ b/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp @@ -198,6 +198,17 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { public: Models::GetShareFilePropertiesResult Value() const override { return m_pollResult; } + /** + * @brief Get the raw HTTP response. + * @return A pointer to #Azure::Core::Http::RawResponse. + * @note Does not give up ownership of the RawResponse. + */ + Azure::Core::Http::RawResponse* GetRawResponse() const override + { + // TODO: Fix to return the rawResponse + return nullptr; + } + ~StartCopyShareFileOperation() override {} private: