github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove libcurl non required options (#1153)

Browse Source 
Fixes: https://github.com/azure/azure-sdk-for-cpp/issues/931
This commit is contained in:
Victor Vazquez 2020-12-15 22:08:48 +00:00 committed by GitHub
parent 0b9befe13d
commit 8cd93803c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 1 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sdk/core/azure-core/CHANGELOG.md
View File

@ -10,6 +10,7 @@
- Removed `DateTime::operator Duration()`.
- Moved `Azure::Core::BearerTokenAuthenticationPolicy`, defined in `azure/core/credentials.hpp` to `Azure::Core::Http` namespace in `azure/core/http/policy.hpp` header.
- Removed option `AllowBeast` from `CurlTransportSSLOptions` in `CurlTransportOptions`.
- Changed default option `NoRevoke` from `CurlTransportSSLOptions` for the `CurlTransportOptions` to `true`. This disables the revocation list checking by default.
## 1.0.0-beta.3 (2020-11-11)

1
sdk/core/azure-core/inc/azure/core/http/curl/curl.hpp
View File

@ -25,7 +25,6 @@ namespace Azure { namespace Core { namespace Http {
*/
struct CurlTransportSSLOptions
{
bool AllowBeast = false;
/**
* @brief This option can disable the revocation list check.
*

4
sdk/core/azure-core/src/http/curl/curl.cpp
View File

@ -1103,10 +1103,6 @@ std::unique_ptr<CurlNetworkConnection> CurlConnectionPool::GetCurlConnection(
}
long sslOption = 0;
if (options.SSLOptions.AllowBeast)
{
sslOption |= CURLSSLOPT_ALLOW_BEAST;
}
if (options.SSLOptions.NoRevoke)
{
sslOption |= CURLSSLOPT_NO_REVOKE;

32
sdk/core/azure-core/test/ut/curl_options.cpp
View File

@ -85,38 +85,6 @@ namespace Azure { namespace Core { namespace Test {
EXPECT_NO_THROW(Azure::Core::Http::CurlConnectionPool::ConnectionPoolIndex.clear());
}
TEST(CurlTransportOptions, allowBeast)
{
Azure::Core::Http::CurlTransportOptions curlOptions;
curlOptions.SSLOptions.AllowBeast = true;
auto transportAdapter = std::make_shared<Azure::Core::Http::CurlTransport>(curlOptions);
Azure::Core::Http::TransportPolicyOptions options;
options.Transport = transportAdapter;
auto transportPolicy = std::make_unique<Azure::Core::Http::TransportPolicy>(options);
std::vector<std::unique_ptr<Azure::Core::Http::HttpPolicy>> policies;
policies.emplace_back(std::move(transportPolicy));
Azure::Core::Http::HttpPipeline pipeline(policies);
Azure::Core::Http::Url url("https://httpbin.org/get");
Azure::Core::Http::Request request(Azure::Core::Http::HttpMethod::Get, url);
std::unique_ptr<Azure::Core::Http::RawResponse> response;
EXPECT_NO_THROW(response = pipeline.Send(Azure::Core::GetApplicationContext(), request));
auto responseCode = response->GetStatusCode();
int expectedCode = 200;
EXPECT_PRED2(
[](int expected, int code) { return expected == code; },
expectedCode,
static_cast<typename std::underlying_type<Azure::Core::Http::HttpStatusCode>::type>(
responseCode));
// Clean the connection from the pool *Windows fails to clean if we leave to be clean uppon
// app-destruction
EXPECT_NO_THROW(Azure::Core::Http::CurlConnectionPool::ConnectionPoolIndex.clear());
}
/*
// Requires libcurl version >= 7.68
TEST(CurlTransportOptions, nativeCA)