From 7971d525dfae8b064e0b0c791cfbb203b0b73371 Mon Sep 17 00:00:00 2001
From: Victor Vazquez <victor.vazquez@microsoft.com>
Date: Wed, 18 Mar 2020 15:39:36 -0700
Subject: [PATCH] Victor/core/basic structure for cmake to work (#37)

* moving files and updating cmake to make it compilable
---
 sdk/core/azure-core/CMakeLists.txt            | 24 ++-------------
 sdk/core/azure-core/inc/http/http.hpp         | 30 +++++++++++++++++++
 .../{ => inc}/internal/contract.hpp           |  0
 sdk/core/azure-core/src/http/http_request.cpp | 15 ++++++++++
 4 files changed, 48 insertions(+), 21 deletions(-)
 create mode 100644 sdk/core/azure-core/inc/http/http.hpp
 rename sdk/core/azure-core/{ => inc}/internal/contract.hpp (100%)
 create mode 100644 sdk/core/azure-core/src/http/http_request.cpp

diff --git a/sdk/core/azure-core/CMakeLists.txt b/sdk/core/azure-core/CMakeLists.txt
index 36c3af207..414aa0946 100644
--- a/sdk/core/azure-core/CMakeLists.txt
+++ b/sdk/core/azure-core/CMakeLists.txt
@@ -9,31 +9,13 @@ set(CMAKE_CXX_STANDARD_REQUIRED True)
 
 add_library (
   azure-core
-  src/http/az_http_request
+  src/http/http_request
   )
 
-if(MSVC)
-  if(WARNINGS_AS_ERRORS)
-    set(WARNINGS_AS_ERRORS_FLAG "/WX")
-  endif()
-
-  target_compile_options(azure-core PRIVATE /Wall ${WARNINGS_AS_ERRORS_FLAG} /wd5031 /wd4668 /wd4820 /wd4255 /analyze)
-elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
-  if(WARNINGS_AS_ERRORS)
-    set(WARNINGS_AS_ERRORS_FLAG "-Werror")
-  endif()
-
-  target_compile_options(azure-core PRIVATE -Xclang -Wall -Wextra -pedantic  ${WARNINGS_AS_ERRORS_FLAG} -Wdocumentation -Wdocumentation-unknown-command -Wcast-qual)
-else()
-  if(WARNINGS_AS_ERRORS)
-    set(WARNINGS_AS_ERRORS_FLAG "-Werror")
-  endif()
-
-  target_compile_options(azure-core PRIVATE -Wall -Wextra -pedantic  ${WARNINGS_AS_ERRORS_FLAG})
-endif()
+# compiler warning flags
+include(global_compile_options)
 
 target_include_directories (azure-core PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/inc> $<INSTALL_INTERFACE:include/az_core>)
-target_include_directories (azure-core PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/internal> $<INSTALL_INTERFACE:include/az_core_internal>)
 
 # make sure that users can consume the project as a library.
 add_library (azure::core ALIAS azure-core)
diff --git a/sdk/core/azure-core/inc/http/http.hpp b/sdk/core/azure-core/inc/http/http.hpp
new file mode 100644
index 000000000..2f71aa275
--- /dev/null
+++ b/sdk/core/azure-core/inc/http/http.hpp
@@ -0,0 +1,30 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+#pragma once
+
+#include <internal/contract.hpp>
+
+namespace azure
+{
+namespace core
+{
+namespace http
+{
+
+class http_request
+{
+
+private:
+  /* data */
+public:
+  http_request();
+  ~http_request();
+};
+
+http_request::http_request() {}
+http_request::~http_request() {}
+
+} // namespace http
+} // namespace core
+} // namespace azure
diff --git a/sdk/core/azure-core/internal/contract.hpp b/sdk/core/azure-core/inc/internal/contract.hpp
similarity index 100%
rename from sdk/core/azure-core/internal/contract.hpp
rename to sdk/core/azure-core/inc/internal/contract.hpp
diff --git a/sdk/core/azure-core/src/http/http_request.cpp b/sdk/core/azure-core/src/http/http_request.cpp
new file mode 100644
index 000000000..a315c06d1
--- /dev/null
+++ b/sdk/core/azure-core/src/http/http_request.cpp
@@ -0,0 +1,15 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+#include <http/http.hpp>
+
+namespace azure
+{
+namespace core
+{
+namespace http
+{
+
+} // namespace http
+} // namespace core
+} // namespace azure