github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove BlobItemDetails::TagCount (#2684)

Browse Source
This commit is contained in:
JinmingHu 2021-07-29 12:41:11 +08:00 committed by GitHub
parent b1c8ea92dc
commit 79143d4a1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/storage/azure-storage-blobs/CHANGELOG.md
View File

@ -8,7 +8,7 @@
- Added source ETag access conditions and last-modified access conditions for `PageBlobClient::UploadPagesFromUri()`.
- Added three new fields `IsServerEncrypted`, `EncryptionKeySha256` and `EncryptionScope` into `SetBlobMetadataResult`.
- Added support for setting blob tags when creating or copying blobs.
- Added new fields `AccessTierChangedOn`, `ArchiveStatus`, `RehydratePriority`, `CopyId`, `CopySource`, `CopyStatus`, `CopyStatusDescription`, `IsIncrementalCopy`, `IncrementalCopyDestinationSnapshot`, `CopyProgress`, `CopyCompletedOn`, `TagCount`, `Tags`, `DeletedOn` and `RemainingRetentionDays` into `BlobItemDetails`.
- Added new fields `AccessTierChangedOn`, `ArchiveStatus`, `RehydratePriority`, `CopyId`, `CopySource`, `CopyStatus`, `CopyStatusDescription`, `IsIncrementalCopy`, `IncrementalCopyDestinationSnapshot`, `CopyProgress`, `CopyCompletedOn`, `Tags`, `DeletedOn` and `RemainingRetentionDays` into `BlobItemDetails`.
- Added support for including blob tags when listing blobs.
### Breaking Changes

15
sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/protocol/blob_rest_client.hpp
View File

@ -936,10 +936,6 @@ namespace Azure { namespace Storage { namespace Blobs {
* blob.
*/
Azure::Nullable<Azure::DateTime> CopyCompletedOn;
/**
* the number of tags stored on the blob.
*/
Azure::Nullable<int32_t> TagCount;
/**
* User-defined tags for this blob.
*/
@ -5861,7 +5857,6 @@ namespace Azure { namespace Storage { namespace Blobs {
k_CopyDestinationSnapshot,
k_DeletedTime,
k_RemainingRetentionDays,
k_TagCount,
k_Metadata,
k_OrMetadata,
k_Tags,
@ -6057,10 +6052,6 @@ namespace Azure { namespace Storage { namespace Blobs {
{
path.emplace_back(XmlTagName::k_RemainingRetentionDays);
}
else if (node.Name == "TagCount")
{
path.emplace_back(XmlTagName::k_TagCount);
}
else if (node.Name == "Metadata")
{
path.emplace_back(XmlTagName::k_Metadata);
@ -6346,12 +6337,6 @@ namespace Azure { namespace Storage { namespace Blobs {
{
ret.Details.RemainingRetentionDays = std::stoi(node.Value);
}
else if (
path.size() == 2 && path[0] == XmlTagName::k_Properties
&& path[1] == XmlTagName::k_TagCount)
{
ret.Details.TagCount = std::stoi(node.Value);
}
}
}
return ret;

2
sdk/storage/azure-storage-blobs/test/ut/blob_container_client_test.cpp
View File

@ -818,8 +818,6 @@ namespace Azure { namespace Storage { namespace Test {
EXPECT_EQ(downloadRet.Value.Details.TagCount.Value(), static_cast<int32_t>(tags.size()));
auto blobItem = GetBlobItem(blobName, Blobs::Models::ListBlobsIncludeFlags::Tags);
ASSERT_TRUE(blobItem.Details.TagCount.HasValue());
EXPECT_EQ(blobItem.Details.TagCount.Value(), static_cast<int32_t>(tags.size()));
EXPECT_EQ(blobItem.Details.Tags, tags);
auto blobServiceClient = Azure::Storage::Blobs::BlobServiceClient::CreateFromConnectionString(