[GEARAMA]: Update issuer restore issuer name (#3064)

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* investigateTestFail

* undo stuffs

* add issuer name back to update issuer.

* test
This commit is contained in:
George Arama 2021-11-05 16:51:22 -07:00 committed by GitHub
parent 7e7979d7f7
commit 781c696522
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions

View File

@ -165,11 +165,13 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
*
* @remark This operation requires the certificates/setissuers permission.
*
* @param issuerName The name of the issuer.
* @param certificateIssuer The certificate issuer.
* @param context The context for the operation can be used for request cancellation.
* @return CertificateIssuer instance.
*/
Azure::Response<CertificateIssuer> UpdateIssuer(
std::string const& issuerName,
CertificateIssuer const& certificateIssuer,
Azure::Core::Context const& context = Azure::Core::Context()) const;

View File

@ -188,19 +188,19 @@ Azure::Response<CertificateIssuer> CertificateClient::CreateIssuer(
}
Azure::Response<CertificateIssuer> CertificateClient::UpdateIssuer(
std::string const& issuerName,
CertificateIssuer const& certificateIssuer,
Azure::Core::Context const& context) const
{
std::string name = certificateIssuer.Name;
auto payload = CertificateIssuerSerializer::Serialize(certificateIssuer);
Azure::Core::IO::MemoryBodyStream payloadStream(
reinterpret_cast<const uint8_t*>(payload.data()), payload.size());
auto request
= CreateRequest(HttpMethod::Patch, {CertificatesPath, IssuersPath, name}, &payloadStream);
auto request = CreateRequest(
HttpMethod::Patch, {CertificatesPath, IssuersPath, issuerName}, &payloadStream);
auto rawResponse = SendRequest(request, context);
auto value = CertificateIssuerSerializer::Deserialize(name, *rawResponse);
auto value = CertificateIssuerSerializer::Deserialize(issuerName, *rawResponse);
return Azure::Response<CertificateIssuer>(std::move(value), std::move(rawResponse));
}

View File

@ -294,7 +294,7 @@ TEST_F(KeyVaultCertificateClientTest, UpdateIssuer)
{
issuer.Credentials.Password = "password2";
auto result = client.UpdateIssuer(issuer);
auto result = client.UpdateIssuer(issuer.Name, issuer);
CheckIssuers(result.Value, issuer);
}