From 763f38549b8f3029b94516f244a6c1dd49990db6 Mon Sep 17 00:00:00 2001 From: JinmingHu Date: Sat, 19 Dec 2020 15:26:06 +0800 Subject: [PATCH] Fix build error caused by storage-common CMakeFile (#1233) # Pull Request Checklist Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly: See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests). - [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html) - [x] Doxygen docs - [x] Unit tests - [x] No unwanted commits/changes - [x] Descriptive title/description - [x] PR is single purpose - [x] Related issue listed - [x] Comments in source - [x] No typos - [x] Update changelog - [x] Not work-in-progress - [x] External references or docs updated - [x] Self review of PR done - [x] Any breaking changes? --- sdk/storage/azure-storage-common/CMakeLists.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sdk/storage/azure-storage-common/CMakeLists.txt b/sdk/storage/azure-storage-common/CMakeLists.txt index 35649d938..625eab589 100644 --- a/sdk/storage/azure-storage-common/CMakeLists.txt +++ b/sdk/storage/azure-storage-common/CMakeLists.txt @@ -75,10 +75,9 @@ target_include_directories( $ ) -# libxml2 headers and libraries will be changed to PRIVATE in the future. -target_include_directories(azure-storage-common PUBLIC ${LIBXML2_INCLUDE_DIRS}) target_link_libraries(azure-storage-common PUBLIC Azure::azure-core) -target_link_libraries(azure-storage-common INTERFACE Threads::Threads ${LIBXML2_LIBRARIES}) +target_include_directories(azure-storage-common PRIVATE ${LIBXML2_INCLUDE_DIRS}) +target_link_libraries(azure-storage-common PRIVATE ${LIBXML2_LIBRARIES}) if(MSVC) target_link_libraries(azure-storage-common PRIVATE bcrypt crypt32)