From 7025e232bd9099f10f5992084e822366d084d454 Mon Sep 17 00:00:00 2001 From: Ahson Khan Date: Thu, 7 Mar 2024 16:56:06 -0800 Subject: [PATCH] Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where they are not needed. (#5418) --- .../inc/azure/keyvault/certificates/certificate_client.hpp | 6 +----- .../inc/azure/keyvault/secrets/secret_client.hpp | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client.hpp b/sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client.hpp index d43fc8969..54781a8db 100644 --- a/sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client.hpp +++ b/sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client.hpp @@ -33,11 +33,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat * * @details The client supports retrieving KeyVaultCertificate. */ - class CertificateClient -#if !defined(TESTING_BUILD) - final -#endif - { + class CertificateClient final { friend class CreateCertificateOperation; #if defined(TESTING_BUILD) diff --git a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp index 6cb87e5da..89c38c64e 100644 --- a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp +++ b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp @@ -42,11 +42,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets { * Vault. The client supports creating, retrieving, updating, deleting, purging, backing up, * restoring, and listing the secret. */ - class SecretClient -#if !defined(TESTING_BUILD) - final -#endif - { + class SecretClient final { private: // Using a shared pipeline for a client to share it with LRO (like delete key)