diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a31ee36f7..a625015c8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -30,7 +30,7 @@ ########### # PRLabel: %Attestation -/sdk/attestation/ @LarryOsterman @gkostal @anilba06 @kroshkina-ms +/sdk/attestation/ @LarryOsterman @gkostal @anilba06 @kroshkina-ms @ahmadmsft @rickwinter @ahsonkhan @antkmsft @vhvb1989 @gearama # PRLabel: %KeyVault /sdk/keyvault/ @vhvb1989 @gearama @antkmsft @rickwinter diff --git a/sdk/attestation/azure-security-attestation/CHANGELOG.md b/sdk/attestation/azure-security-attestation/CHANGELOG.md index 40d6b15db..0917a87c9 100644 --- a/sdk/attestation/azure-security-attestation/CHANGELOG.md +++ b/sdk/attestation/azure-security-attestation/CHANGELOG.md @@ -1,6 +1,6 @@ # Release History -## 1.0.0-beta.3 (Unreleased) +## 1.0.0-beta.3 (2022-06-07) ### Breaking Changes - `ValueToSend` field in `TpmAttestationOptions` becomes `Payload`. diff --git a/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_administration_client.hpp b/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_administration_client.hpp index ab67b7154..bafac8951 100644 --- a/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_administration_client.hpp +++ b/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_administration_client.hpp @@ -95,9 +95,6 @@ namespace Azure { namespace Security { namespace Attestation { * @return Response> The returned policy from the * service. * - * @note \b Note: The RetrieveResponseValidationCollateral API \b MUST be called before the - * GetAttestationPolicy API is called to retrieve the information needed to validate the - * result returned by the service. */ Response> GetAttestationPolicy( Models::AttestationType const& attestationType, @@ -131,9 +128,6 @@ namespace Azure { namespace Security { namespace Attestation { * @return Response> The result of the set policy * operation. * - * @note \b Note: The RetrieveResponseValidationCollateral API \b MUST be called before the - * SetAttestationPolicy API is called to retrieve the information needed to validate the - * result returned by the service. */ Response> SetAttestationPolicy( Models::AttestationType const& attestationType, @@ -150,9 +144,6 @@ namespace Azure { namespace Security { namespace Attestation { * @return Response> The result of the reset * policy operation. * - * @note \b Note: The RetrieveResponseValidationCollateral API \b MUST be called before the - * ResetAttestationPolicy API is called to retrieve the information needed to validate the - * result returned by the service. */ Response> ResetAttestationPolicy( Models::AttestationType const& attestationType, @@ -270,36 +261,6 @@ namespace Azure { namespace Security { namespace Attestation { std::vector m_attestationSigners; - /** - * @brief Construct a new Attestation Administration Client object. - * - * @param endpoint The URL address where the client will send the requests to. - * @param credential The authentication token to use. - * @param options The options to customize the client behavior. - * @return The newly created client. - */ - static AttestationAdministrationClient CreateConcrete( - std::string const& endpoint, - std::shared_ptr credential, - AttestationAdministrationClientOptions const& options - = AttestationAdministrationClientOptions{}, - Azure::Core::Context const& context = Azure::Core::Context{}); - - /** - * @brief Construct a new Attestation Administration Client object. - * - * @param endpoint The URL address where the client will send the requests to. - * @param credential The authentication token to use. - * @param options The options to customize the client behavior. - * @return The newly created client. - */ - static std::unique_ptr CreatePointer( - std::string const& endpoint, - std::shared_ptr credential, - AttestationAdministrationClientOptions const& options - = AttestationAdministrationClientOptions{}, - Azure::Core::Context const& context = Azure::Core::Context{}); - /** * @brief Construct a new Attestation Administration Client object. * diff --git a/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_client.hpp b/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_client.hpp index e4071b395..2d55b7676 100644 --- a/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_client.hpp +++ b/sdk/attestation/azure-security-attestation/inc/azure/attestation/attestation_client.hpp @@ -201,9 +201,6 @@ namespace Azure { namespace Security { namespace Attestation { * @returns Response> - The result of the * attestation operation. * - * @note \b Note: The RetrieveResponseValidationCollateral API \b MUST be called before the - * AttestSgxEnclave API is called to retrieve the information needed to validate the - * result returned by the service. */ Response> AttestSgxEnclave( std::vector const& sgxQuoteToAttest, @@ -222,9 +219,6 @@ namespace Azure { namespace Security { namespace Attestation { * @returns Response> - The result of the attestation * operation - * @note \b Note: The RetrieveResponseValidationCollateral API \b MUST be called before the - * AttestOpenEnclave API is called to retrieve information needed to used to validate the - * result returned by the service. */ Response> AttestOpenEnclave( std::vector const& openEnclaveReportToAttest, @@ -262,41 +256,6 @@ namespace Azure { namespace Security { namespace Attestation { AttestationTokenValidationOptions m_tokenValidationOptions; std::vector m_attestationSigners; - /** @brief Construct a new Attestation Client object - * - * @details Constructs a new attestation client. Follows the - * factory pattern in [C++ Core Guidelines - * C.50](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c50-use-a-factory-function-if-you-need-virtual-behavior-during-initialization) - * - * @param endpoint The URL address where the client will send the requests to. - * @param credential The authentication method to use (required for TPM attestation). If the - * credential parameter is not supplied, the connection will be unauthenticated. - * @param options The options to customize the client behavior. - * @return std::unique_ptr The newly created client. - */ - static AttestationClient CreateConcrete( - std::string const& endpoint, - std::shared_ptr credential, - AttestationClientOptions const& options = AttestationClientOptions{}, - Azure::Core::Context const& constext = Azure::Core::Context{}); - /** @brief Construct a new Attestation Client object - * - * @details Constructs a new attestation client. Follows the - * factory pattern in [C++ Core Guidelines - * C.50](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c50-use-a-factory-function-if-you-need-virtual-behavior-during-initialization) - * - * @param endpoint The URL address where the client will send the requests to. - * @param credential The authentication method to use (required for TPM attestation). If the - * credential parameter is not supplied, the connection will be unauthenticated. - * @param options The options to customize the client behavior. - * @return std::unique_ptr The newly created client. - */ - static std::unique_ptr CreatePointer( - std::string const& endpoint, - std::shared_ptr credential, - AttestationClientOptions const& options = AttestationClientOptions{}, - Azure::Core::Context const& constext = Azure::Core::Context{}); - /** @brief Construct a new Attestation Client object * * @param endpoint The URL address where the client will send the requests to.