From 6b50feb0d4c8be0086db7089543884c303a325be Mon Sep 17 00:00:00 2001
From: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed, 14 Apr 2021 22:37:40 -0700
Subject: [PATCH] Sync eng/common directory with azure-sdk-tools for PR 1559
 (#2123)

* Handle empty files in Test-SampleMetadata

Relates to Azure/azure-sdk-for-java#20684

* Remove condition from verify-samples

* Use forward slash in path

* Fix directory typo

Co-authored-by: Heath Stewart <heaths@microsoft.com>
---
 eng/common/pipelines/templates/steps/verify-samples.yml | 8 ++------
 eng/common/scripts/Test-SampleMetadata.ps1              | 4 +++-
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/eng/common/pipelines/templates/steps/verify-samples.yml b/eng/common/pipelines/templates/steps/verify-samples.yml
index fcd87d2cc..fef0f4ddd 100644
--- a/eng/common/pipelines/templates/steps/verify-samples.yml
+++ b/eng/common/pipelines/templates/steps/verify-samples.yml
@@ -5,15 +5,11 @@ parameters:
   - name: ScriptDirectory
     type: string
     default: eng/common/scripts
-  - name: Condition
-    type: boolean
-    default: succeeded()
 
 steps:
   - pwsh: |
       # If the last path segment is an absolute path it will be used entirely.
-      $root = [System.IO.Path]::Combine('$(Build.SourcesDireectory)', 'sdk', '${{ parameters.ServiceDirectory }}')
-      Get-ChildItem $root -Filter *.md -Recurse | ${{ parameters.ScriptDirectory }}\Test-SampleMetadata.ps1 -AllowParentProducts
+      $root = [System.IO.Path]::Combine('$(Build.SourcesDirectory)', 'sdk', '${{ parameters.ServiceDirectory }}')
+      Get-ChildItem $root -Filter *.md -Recurse | ${{ parameters.ScriptDirectory }}/Test-SampleMetadata.ps1 -AllowParentProducts
     displayName: Verify sample metadata
     workingDirectory: $(Build.SourcesDirectory)
-    condition: ${{ parameters.Condition }}
diff --git a/eng/common/scripts/Test-SampleMetadata.ps1 b/eng/common/scripts/Test-SampleMetadata.ps1
index cd74690ca..523aeb31d 100644
--- a/eng/common/scripts/Test-SampleMetadata.ps1
+++ b/eng/common/scripts/Test-SampleMetadata.ps1
@@ -31,11 +31,13 @@ process {
         }
 
         [string[]] $content = $file | Get-Content
-        if (!$content[0].StartsWith('---')) {
+        if (!$content -or !$content[0].StartsWith('---')) {
             Write-Verbose "Skipping $($file.FullName): does not contain frontmatter"
             continue
         }
 
+        Write-Verbose "Checking $($file.FullName)"
+
         # Reset metadata and create mutable collections.
         $products = [System.Collections.Generic.List[string]]::new()