github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Storage Fix AccessType live test failure (#5807)

Browse Source 
* Fix live test failure

* update datalake tests
This commit is contained in:
microzchang 2024-07-17 02:26:21 -07:00 committed by GitHub
parent b9c776c9ff
commit 60fbccf8c0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 29 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/storage/assets.json
View File

@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "cpp",
"TagPrefix": "cpp/storage",
"Tag": "cpp/storage_75931731d9"
"Tag": "cpp/storage_c3a4a21ce9"
}

18
sdk/storage/azure-storage-blobs/test/ut/blob_container_client_test.cpp
View File

@ -442,7 +442,6 @@ namespace Azure { namespace Storage { namespace Test {
containerClient.CreateIfNotExists();
Blobs::SetBlobContainerAccessPolicyOptions options;
options.AccessType = Blobs::Models::PublicAccessType::Blob;
{
Blobs::Models::SignedIdentifier identifier;
identifier.Id = RandomString(63) + "1";
@ -479,7 +478,6 @@ namespace Azure { namespace Storage { namespace Test {
EXPECT_TRUE(IsValidTime(ret.Value.LastModified));
auto ret2 = containerClient.GetAccessPolicy();
EXPECT_EQ(ret2.Value.AccessType, options.AccessType);
if (m_testContext.IsLiveMode())
{
EXPECT_EQ(ret2.Value.SignedIdentifiers, options.SignedIdentifiers);
@ -487,6 +485,22 @@ namespace Azure { namespace Storage { namespace Test {
containerClient.DeleteIfExists();
}
TEST_F(BlobContainerClientTest, AccessType_PLAYBACKONLY_)
{
auto containerClient = *m_blobContainerClient;
containerClient.CreateIfNotExists();
Blobs::SetBlobContainerAccessPolicyOptions options;
options.AccessType = Blobs::Models::PublicAccessType::Blob;
auto ret = containerClient.SetAccessPolicy(options);
EXPECT_TRUE(ret.Value.ETag.HasValue());
EXPECT_TRUE(IsValidTime(ret.Value.LastModified));
auto ret2 = containerClient.GetAccessPolicy();
EXPECT_EQ(ret2.Value.AccessType, options.AccessType);
containerClient.DeleteIfExists();
}
TEST_F(BlobContainerClientTest, Lease)
{
auto containerClient = *m_blobContainerClient;

14
sdk/storage/azure-storage-files-datalake/test/ut/datalake_file_system_client_test.cpp
View File

@ -304,7 +304,8 @@ namespace Azure { namespace Storage { namespace Test {
TEST_F(DataLakeFileSystemClientTest, Constructors_LIVEONLY_)
{
{
// Create from connection string validates static creator function and shared key constructor.
// Create from connection string validates static creator function and shared key
// constructor.
auto fileSystemName = LowercaseRandomString() + "1";
auto connectionStringClient
= Azure::Storage::Files::DataLake::DataLakeFileSystemClient::CreateFromConnectionString(
@ -653,10 +654,18 @@ namespace Azure { namespace Storage { namespace Test {
{
EXPECT_EQ(ret2.Value.SignedIdentifiers, options.SignedIdentifiers);
}
}
}
TEST_F(DataLakeFileSystemClientTest, AccessType_PLAYBACKONLY_)
{
{
auto fileSystem = GetFileSystemClientForTest(LowercaseRandomString());
fileSystem.CreateIfNotExists();
Files::DataLake::SetFileSystemAccessPolicyOptions options;
options.AccessType = Files::DataLake::Models::PublicAccessType::FileSystem;
EXPECT_NO_THROW(fileSystem.SetAccessPolicy(options));
ret2 = fileSystem.GetAccessPolicy();
auto ret2 = fileSystem.GetAccessPolicy();
EXPECT_EQ(ret2.Value.AccessType, options.AccessType);
options.AccessType = Files::DataLake::Models::PublicAccessType::None;
@ -664,6 +673,7 @@ namespace Azure { namespace Storage { namespace Test {
ret2 = fileSystem.GetAccessPolicy();
EXPECT_EQ(ret2.Value.AccessType, options.AccessType);
}
{
auto fileSystem = GetFileSystemClientForTest(LowercaseRandomString());
Files::DataLake::CreateFileSystemOptions options;