From 60b35a6a4f9829d3cf77e057543d62397ee6e6ea Mon Sep 17 00:00:00 2001
From: George Arama <50641385+gearama@users.noreply.github.com>
Date: Sat, 8 Oct 2022 13:41:07 -0700
Subject: [PATCH] Small updates for core tests to work with the main
 automation. (#4004)

* core tests

* clang
---
 .../perf/test/inc/azure/perf/test/delay_test.hpp | 11 ++++-------
 .../perf/test/inc/azure/perf/test/no_op_test.hpp | 16 +++++++++++++++-
 2 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/sdk/core/perf/test/inc/azure/perf/test/delay_test.hpp b/sdk/core/perf/test/inc/azure/perf/test/delay_test.hpp
index 4d779f110..9a21179cd 100644
--- a/sdk/core/perf/test/inc/azure/perf/test/delay_test.hpp
+++ b/sdk/core/perf/test/inc/azure/perf/test/delay_test.hpp
@@ -56,7 +56,7 @@ namespace Azure { namespace Perf { namespace Test {
     {
       // Increment the counter and fetch the value, then remove 1 to get the previous-increment
       // value
-      auto instanceCount = _detail::DelayTestInstanceCount.fetch_add(1) - 1;
+      auto instanceCount = _detail::DelayTestInstanceCount.fetch_add(0);
       // default value if option is not parsed is 1000
       auto initialDelay = m_options.GetOptionOrDefault("InitialDelayMs", 1000);
       auto instanceGrowFactor = m_options.GetOptionOrDefault("InstanceGrowthFactor", 1);
@@ -77,17 +77,14 @@ namespace Azure { namespace Perf { namespace Test {
     std::vector<Azure::Perf::TestOption> GetTestOptions() override
     {
       return {
-          {"InitialDelayMs",
-           {"--delay"},
-           "Initial delay (in milliseconds). Default to 1000 (1sec)",
-           1},
+          {"InitialDelayMs", {"-m"}, "Initial delay (in milliseconds). Default to 1000 (1sec)", 1},
           {"InstanceGrowthFactor",
-           {"--infactor"},
+           {"-n"},
            "Instance growth factor. The delay of instance N will be (InitialDelayMS * "
            "(InstanceGrowthFactor ^ InstanceCount)). Default to 1",
            1},
           {"IterationGrowthFactor",
-           {"--itfactor"},
+           {"-t"},
            "Initial delay (in milliseconds). The delay of iteration N will be (InitialDelayMS * "
            "(IterationGrowthFactor ^ IterationCount)). Default to 1",
            1}};
diff --git a/sdk/core/perf/test/inc/azure/perf/test/no_op_test.hpp b/sdk/core/perf/test/inc/azure/perf/test/no_op_test.hpp
index 1910ec3cf..f3875cda4 100644
--- a/sdk/core/perf/test/inc/azure/perf/test/no_op_test.hpp
+++ b/sdk/core/perf/test/inc/azure/perf/test/no_op_test.hpp
@@ -32,7 +32,21 @@ namespace Azure { namespace Perf { namespace Test {
      * @brief Define an empty test.
      *
      */
-    void Run(Azure::Core::Context const&) override {}
+    void Run(Azure::Core::Context const&) override
+    { // Get the option or a default value of 0
+      auto myTestOption = m_options.GetOptionOrDefault("extraOption", 0);
+      (void)myTestOption;
+    }
+
+    /**
+     * @brief Define the test options for the test.
+     *
+     * @return The list of test options.
+     */
+    std::vector<Azure::Perf::TestOption> GetTestOptions() override
+    {
+      return {{"extraOption", {"-e"}, "Example for extended option for test.", 1}};
+    }
 
     /**
      * @brief Get the static Test Metadata for the test.