github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Check API changes only if package is modified (#3385)

Browse Source 
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
This commit is contained in:
Azure SDK Bot 2022-03-02 09:03:02 -08:00 committed by GitHub
parent 2a57a72e50
commit 59e620318e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
eng/common/pipelines/templates/steps/detect-api-changes.yml
View File

@ -14,6 +14,5 @@ steps:
-PullRequestNumber $(System.PullRequest.PullRequestNumber)
-RepoFullName $(Build.Repository.Name)
pwsh: true
workingDirectory: $(Pipeline.Workspace)
displayName: Detect API changes
condition: and(succeededOrFailed(), eq(variables['Build.Reason'],'PullRequest'))

19
eng/common/scripts/Detect-Api-Changes.ps1
View File

@ -12,7 +12,8 @@ Param (
[array] $ArtifactList,
[string] $RepoFullName = "",
[string] $ArtifactName = "packages",
[string] $APIViewUri = "https://apiview.dev/PullRequest/DetectApiChanges"
[string] $APIViewUri = "https://apiview.dev/PullRequest/DetectApiChanges",
[string] $TargetBranch = ("origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH}" -replace "refs/heads/")
)
# Submit API review request and return status whether current revision is approved or pending or failed to create review
@ -59,8 +60,12 @@ function Should-Process-Package($pkgPath, $packageName)
}
# Get package info from json file created before updating version to daily dev
$pkgInfo = Get-Content $pkgPropPath | ConvertFrom-Json
Write-Host "SDK Type: $($pkgInfo.SdkType)"
return $pkgInfo.IsNewSdk
$packagePath = $pkgInfo.DirectoryPath
$modifiedFiles = git diff --name-only --relative $TargetBranch HEAD
$modifiedFiles = $modifiedFiles.Where({$_.startswith($packagePath)})
$filteredFileCount = $modifiedFiles.Count
Write-Host "Number of modified files for package: $filteredFileCount"
return ($filteredFileCount -gt 0 -and $pkgInfo.IsNewSdk)
}
function Log-Input-Params()
@ -94,7 +99,9 @@ foreach ($artifact in $ArtifactList)
if ($packages)
{
$pkgPath = $packages.Values[0]
if (Should-Process-Package -pkgPath $pkgPath -packageName $artifact.name)
$isRequired = Should-Process-Package -pkgPath $pkgPath -packageName $artifact.name
Write-Host "Is API change detect required for $($artifact.name):$($isRequired)"
if ($isRequired -eq $True)
{
$filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/")
$respCode = Submit-Request -filePath $filePath -packageName $artifact.name
@ -103,6 +110,10 @@ foreach ($artifact in $ArtifactList)
$responses[$artifact.name] = $respCode
}
}
else
{
Write-Host "Pull request does not have any change for $($artifact.name). Skipping API change detect."
}
}
else
{