Enable UseFederatedAuth by default (#5852)

* enable use federated

* 401 unauthorized

* 401

* cleanup readmes

* DISABLE RUN

* Remove UseFederatedAuth overrides from ci.yml

* DISABLE RUN for admin samples,

eng/pipelines/templates/jobs/live.tests.yml

@@ -47,7 +47,7 @@ parameters:
   default: {}
 - name: UseFederatedAuth
   type: boolean
-  default: false
+  default: true
 
 jobs:
 - job:

eng/pipelines/templates/stages/archetype-sdk-client.yml

@@ -95,7 +95,7 @@ parameters:
     default: {}
   - name: UseFederatedAuth
     type: boolean
-    default: false
+    default: true
 
 extends:
   ${{ if eq(variables['System.TeamProject'], 'internal') }}:

eng/pipelines/templates/stages/archetype-sdk-tests.yml

@@ -40,7 +40,7 @@ parameters:
   default: {}
 - name: UseFederatedAuth
   type: boolean
-  default: false
+  default: true
 
 stages:
 - ${{ each cloud in parameters.CloudConfig }}:

sdk/attestation/ci.yml

@@ -32,7 +32,6 @@ extends:
       LiveTestCtestRegex: azure-security-attestation.*
       LineCoverageTarget: 70
       BranchCoverageTarget: 34
-      UseFederatedAuth: true
       Artifacts:
         - Name: azure-security-attestation
           Path: azure-security-attestation

sdk/core/ci.yml

@@ -53,7 +53,6 @@ extends:
       LiveTestTimeoutInMinutes: 90 # default is 60 min. We need a little longer on worst case for Win+jsonTests
       LineCoverageTarget: 88
       BranchCoverageTarget: 68
-      UseFederatedAuth: true
 #      PreTestSteps:
 #        - pwsh: |
 #            docker build -t squid-local $(Build.SourcesDirectory)/sdk/core/azure-core/test/ut/proxy_tests/localproxy

sdk/eventhubs/ci.yml

@@ -32,7 +32,6 @@ extends:
       LiveTestTimeoutInMinutes: 120
       LineCoverageTarget: 27
       BranchCoverageTarget: 13
-      UseFederatedAuth: true
       Artifacts:
         - Name: azure-messaging-eventhubs
           Path: azure-messaging-eventhubs

sdk/identity/azure-identity/samples/CMakeLists.txt

@@ -39,13 +39,13 @@ add_executable(client_secret_credential_sample client_secret_credential.cpp)
 target_link_libraries(client_secret_credential_sample PRIVATE azure-identity service get-env-helper)
 target_include_directories(client_secret_credential_sample PRIVATE .)
 target_compile_definitions(client_secret_credential_sample PRIVATE _azure_BUILDING_SAMPLES)
-create_per_service_target_build_for_sample(identity client_secret_credential_sample)
+create_per_service_target_build_for_sample(identity client_secret_credential_sample DISABLE_RUN)
 
 add_executable(default_azure_credential_sample default_azure_credential.cpp)
 target_link_libraries(default_azure_credential_sample PRIVATE azure-identity service)
 target_include_directories(default_azure_credential_sample PRIVATE .)
 target_compile_definitions(default_azure_credential_sample PRIVATE _azure_BUILDING_SAMPLES)
-create_per_service_target_build_for_sample(identity default_azure_credential_sample)
+create_per_service_target_build_for_sample(identity default_azure_credential_sample DISABLE_RUN)
 
 add_executable(environment_credential_sample environment_credential.cpp)
 target_link_libraries(environment_credential_sample PRIVATE azure-identity service)

sdk/identity/azure-identity/test/ut/azure_pipelines_credential_test.cpp

@@ -640,7 +640,7 @@ TEST(AzurePipelinesCredential, InvalidServiceConnectionId_LIVEONLY_)
   }
   catch (AuthenticationException const& ex)
   {
-    EXPECT_TRUE(std::string(ex.what()).find("404 (Not Found)") != std::string::npos) << ex.what();
+    EXPECT_TRUE(std::string(ex.what()).find("401") != std::string::npos) << ex.what();
   }
 }
 

sdk/identity/ci.yml

@@ -30,7 +30,6 @@ extends:
       LiveTestCtestRegex: azure-identity.
       LineCoverageTarget: 95
       BranchCoverageTarget: 56
-      UseFederatedAuth: true
       Artifacts:
         - Name: azure-identity
           Path: azure-identity

sdk/keyvault/azure-security-keyvault-administration/samples/sample1-basic-operations/CMakeLists.txt

@@ -14,6 +14,6 @@ add_executable (
 
 target_compile_definitions(sample1-administration PRIVATE _azure_BUILDING_SAMPLES)
 
-create_per_service_target_build_for_sample(keyvault sample1-administration)
+create_per_service_target_build_for_sample(keyvault sample1-administration DISABLE_RUN)
 
 target_link_libraries(sample1-administration PRIVATE azure-security-keyvault-administration azure-identity get-env-helper)

sdk/keyvault/azure-security-keyvault-administration/samples/sample2-full-backup-restore/CMakeLists.txt

@@ -11,6 +11,6 @@ add_executable (
   sample2-full-backup-restore
   sample2_full_backup_restore.cpp
 )
-create_per_service_target_build_for_sample(keyvault sample2-full-backup-restore)
+create_per_service_target_build_for_sample(keyvault sample2-full-backup-restore DISABLE_RUN)
 
 target_link_libraries(sample2-full-backup-restore PRIVATE azure-security-keyvault-administration azure-identity get-env-helper)

sdk/keyvault/azure-security-keyvault-administration/samples/sample3-backup-selective-restore/CMakeLists.txt

@@ -11,6 +11,6 @@ add_executable (
   sample3-backup-selective-restore
   sample3_backup_selective_restore.cpp
 )
-create_per_service_target_build_for_sample(keyvault sample3-backup-selective-restore)
+create_per_service_target_build_for_sample(keyvault sample3-backup-selective-restore DISABLE_RUN)
 
 target_link_libraries(sample3-backup-selective-restore PRIVATE azure-security-keyvault-administration azure-identity get-env-helper)

sdk/keyvault/ci.yml

@@ -32,7 +32,6 @@ extends:
       LiveTestTimeoutInMinutes: 120
       LineCoverageTarget: 81
       BranchCoverageTarget: 42
-      UseFederatedAuth: true
       Artifacts:
         - Name: azure-security-keyvault-keys
           Path: azure-security-keyvault-keys

sdk/storage/ci.yml

@@ -33,7 +33,6 @@ extends:
       LiveTestCtestRegex: azure-storage
       Clouds: Preview
       SupportedClouds: Preview
-      UseFederatedAuth: true
       Artifacts:
         - Name: azure-storage-common
           Path: azure-storage-common

sdk/tables/ci.yml

@@ -30,7 +30,6 @@ extends:
       CtestRegex: azure-data
       LineCoverageTarget: 77
       BranchCoverageTarget: 42
-      UseFederatedAuth: true
       LiveTestCtestRegex: azure-data
       Clouds: Preview
       SupportedClouds: Preview