github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Sync eng/common directory with azure-sdk-tools for PR 12416 (#6775)

Browse Source 
* Pass packageInfo parameter conditionally to Find-Language-Artifacts-For-Apireview

* Use new parameter

---------

Co-authored-by: ray chen <raychen@microsoft.com>
This commit is contained in:
Azure SDK Bot 2025-10-09 15:56:21 -07:00 committed by GitHub
parent a42fbeb452
commit 345101e9a5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 29 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
eng/common/scripts/Detect-Api-Changes.ps1
View File

@ -80,22 +80,13 @@ function Submit-Request($filePath, $packageName)
return $StatusCode
}
function Should-Process-Package($pkgPath, $packageName)
function Should-Process-Package($packageInfo)
{
$pkg = Split-Path -Leaf $pkgPath
$pkgPropPath = Join-Path -Path $configFileDir "$packageName.json"
if (!(Test-Path $pkgPropPath))
{
LogWarning "Package property file path $($pkgPropPath) is invalid."
return $False
}
# Get package info from json file created before updating version to daily dev
$pkgInfo = Get-Content $pkgPropPath | ConvertFrom-Json
$packagePath = $pkgInfo.DirectoryPath
$packagePath = $packageInfo.DirectoryPath
$modifiedFiles = @(Get-ChangedFiles -DiffPath "$packagePath/*" -DiffFilterType '')
$filteredFileCount = $modifiedFiles.Count
LogInfo "Number of modified files for package: $filteredFileCount"
return ($filteredFileCount -gt 0 -and $pkgInfo.IsNewSdk)
return ($filteredFileCount -gt 0 -and $packageInfo.IsNewSdk)
}
function Log-Input-Params()
@ -126,24 +117,42 @@ $responses = @{}
LogInfo "Processing PackageInfo at $configFileDir"
$packageProperties = Get-ChildItem -Recurse -Force "$configFileDir" `
| Where-Object {
$packageInfoFiles = Get-ChildItem -Recurse -Force "$configFileDir" `
| Where-Object {
$_.Extension -eq '.json' -and ($_.FullName.Substring($configFileDir.Length + 1) -notmatch '^_.*?[\\\/]')
}
foreach ($packagePropFile in $packageProperties)
foreach ($packageInfoFile in $packageInfoFiles)
{
$packageMetadata = Get-Content $packagePropFile | ConvertFrom-Json
$pkgArtifactName = $packageMetadata.ArtifactName ?? $packageMetadata.Name
$packageInfo = Get-Content $packageInfoFile | ConvertFrom-Json
$pkgArtifactName = $packageInfo.ArtifactName ?? $packageInfo.Name
LogInfo "Processing $($pkgArtifactName)"
$packages = &$FindArtifactForApiReviewFn $ArtifactPath $pkgArtifactName
# Check if the function supports the packageInfo parameter
$functionInfo = Get-Command $FindArtifactForApiReviewFn -ErrorAction SilentlyContinue
$supportsPackageInfoParam = $false
if ($functionInfo -and $functionInfo.Parameters) {
# Check if function specifically supports packageInfo parameter
$parameterNames = $functionInfo.Parameters.Keys
$supportsPackageInfoParam = $parameterNames -contains 'packageInfo'
}
# Call function with appropriate parameters
if ($supportsPackageInfoParam) {
LogInfo "Calling $FindArtifactForApiReviewFn with packageInfo parameter"
$packages = &$FindArtifactForApiReviewFn $ArtifactPath $pkgArtifactName $packageInfo
}
else {
LogInfo "Calling $FindArtifactForApiReviewFn with legacy parameters"
$packages = &$FindArtifactForApiReviewFn $ArtifactPath $pkgArtifactName
}
if ($packages)
{
$pkgPath = $packages.Values[0]
$isRequired = Should-Process-Package -pkgPath $pkgPath -packageName $pkgArtifactName
$isRequired = Should-Process-Package $packageInfo
LogInfo "Is API change detect required for $($pkgArtifactName):$($isRequired)"
if ($isRequired -eq $True)
{
@ -156,7 +165,7 @@ foreach ($packagePropFile in $packageProperties)
}
else
{
LogInfo "Pull request does not have any change for $($pkgArtifactName)). Skipping API change detect."
LogInfo "Pull request does not have any change for $($pkgArtifactName). Skipping API change detect."
}
}
else