From 325466ecaedab19cc228411b648d311f4563ab8d Mon Sep 17 00:00:00 2001 From: JinmingHu Date: Thu, 10 Jun 2021 10:02:01 +0800 Subject: [PATCH] Fix memory leak in Base64Encode (#2441) * Fix memory leak * cl --- sdk/core/azure-core/CHANGELOG.md | 3 +++ sdk/core/azure-core/src/base64.cpp | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md index 082573d40..e42a84ac6 100644 --- a/sdk/core/azure-core/CHANGELOG.md +++ b/sdk/core/azure-core/CHANGELOG.md @@ -2,6 +2,9 @@ ## 1.1.0-beta.1 (Unreleased) +### Bug Fixes + +- Fixed a memory leak issue in `Base64Encode()`. ## 1.0.0 (2021-06-04) diff --git a/sdk/core/azure-core/src/base64.cpp b/sdk/core/azure-core/src/base64.cpp index 823325ced..83924baea 100644 --- a/sdk/core/azure-core/src/base64.cpp +++ b/sdk/core/azure-core/src/base64.cpp @@ -68,7 +68,6 @@ namespace Azure { namespace Core { BUF_MEM* bufferPtr; BIO_get_mem_ptr(bio, &bufferPtr); std::string toReturn(bufferPtr->data, bufferPtr->length); - BIO_set_close(bio, BIO_NOCLOSE); BIO_free_all(bio); return toReturn;