From 2dbaa8a37d7d43dbaf6202ff73104e6c7a1a6377 Mon Sep 17 00:00:00 2001
From: Theodore Tsirpanis <teo@tsirpanis.gr>
Date: Tue, 12 Dec 2023 20:02:29 +0200
Subject: [PATCH] Disable default features in libxml2. (#5221)

* Disable default features in libxml2.
We don't seem to make use of any of them in `xml_wrapper.cpp`.

* Update changelog.

* Added "Acknowledgments" section to the Storage Changelog.

* "Identity" => "Storage" (my bad)

* Apply suggestions from code review

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
---
 sdk/storage/azure-storage-common/CHANGELOG.md     | 8 ++++++++
 sdk/storage/azure-storage-common/vcpkg.json       | 1 +
 sdk/storage/azure-storage-common/vcpkg/vcpkg.json | 1 +
 vcpkg.json                                        | 1 +
 4 files changed, 11 insertions(+)

diff --git a/sdk/storage/azure-storage-common/CHANGELOG.md b/sdk/storage/azure-storage-common/CHANGELOG.md
index ad804eadb..592642c93 100644
--- a/sdk/storage/azure-storage-common/CHANGELOG.md
+++ b/sdk/storage/azure-storage-common/CHANGELOG.md
@@ -4,12 +4,20 @@
 
 ### Features Added
 
+- Removed unnecessary dependencies on non-Windows platforms. (A community contribution, courtesy of _[teo-tsirpanis](https://github.com/teo-tsirpanis)_)
+
 ### Breaking Changes
 
 ### Bugs Fixed
 
 ### Other Changes
 
+### Acknowledgments
+
+Thank you to our developer community members who helped to make Azure Storage better with their contributions to this release:
+
+- Theodore Tsirpanis _([GitHub](https://github.com/teo-tsirpanis))_
+
 ## 12.5.0 (2023-11-07)
 
 ### Features Added
diff --git a/sdk/storage/azure-storage-common/vcpkg.json b/sdk/storage/azure-storage-common/vcpkg.json
index 624ed9925..fe8c4cadf 100644
--- a/sdk/storage/azure-storage-common/vcpkg.json
+++ b/sdk/storage/azure-storage-common/vcpkg.json
@@ -11,6 +11,7 @@
     "azure-core-cpp",
     {
       "name": "libxml2",
+      "default-features": false,
       "platform": "!windows"
     },
     {
diff --git a/sdk/storage/azure-storage-common/vcpkg/vcpkg.json b/sdk/storage/azure-storage-common/vcpkg/vcpkg.json
index e52ffb5c4..5389bf052 100644
--- a/sdk/storage/azure-storage-common/vcpkg/vcpkg.json
+++ b/sdk/storage/azure-storage-common/vcpkg/vcpkg.json
@@ -22,6 +22,7 @@
     },
     {
       "name": "libxml2",
+      "default-features": false,
       "platform": "!windows"
     },
     {
diff --git a/vcpkg.json b/vcpkg.json
index cc5c112b9..3f796f254 100644
--- a/vcpkg.json
+++ b/vcpkg.json
@@ -8,6 +8,7 @@
     },
     {
       "name": "libxml2",
+      "default-features": false,
       "platform": "!windows & !uwp"
     },
     {