From 2b205d95f7c013387a1419ee91a7b8949ea8481d Mon Sep 17 00:00:00 2001 From: George Arama <50641385+gearama@users.noreply.github.com> Date: Thu, 2 Sep 2021 10:28:50 -0700 Subject: [PATCH] Kyle feedback (#2822) * rename readmes for samples to show up in repo by default * moved files around per kyle's comment * update cmake file * update links to samples --- .../azure-security-keyvault-secrets/CMakeLists.txt | 2 +- sdk/keyvault/azure-security-keyvault-secrets/README.md | 8 ++++---- .../{test => }/samples/CMakeLists.txt | 0 .../samples/sample1-basic-operations/CMakeLists.txt | 0 .../sample1-basic-operations/README.md} | 0 .../sample1-basic-operations/sample1-basic-operations.cpp | 0 .../samples/sample2-backup-restore/CMakeLists.txt | 0 .../sample2-backup-restore/README.md} | 0 .../sample2-backup-restore/sample2-backup-restore.cpp | 0 .../samples/sample3-delete-recover/CMakeLists.txt | 0 .../sample3-delete-recover/README.md} | 0 .../sample3-delete-recover/sample3-delete-recover.cpp | 0 .../samples/sample4-get-secrets-deleted/CMakeLists.txt | 0 .../sample4-get-secrets-deleted/README.md} | 0 .../sample4-get-secrets-deleted.cpp | 0 15 files changed, 5 insertions(+), 5 deletions(-) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/CMakeLists.txt (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample1-basic-operations/CMakeLists.txt (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test/samples/sample1-basic-operations/sample1-basic-operations.md => samples/sample1-basic-operations/README.md} (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample1-basic-operations/sample1-basic-operations.cpp (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample2-backup-restore/CMakeLists.txt (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test/samples/sample2-backup-restore/sample2-backup-restore.md => samples/sample2-backup-restore/README.md} (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample2-backup-restore/sample2-backup-restore.cpp (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample3-delete-recover/CMakeLists.txt (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test/samples/sample3-delete-recover/sample3-delete-recover.md => samples/sample3-delete-recover/README.md} (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample3-delete-recover/sample3-delete-recover.cpp (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample4-get-secrets-deleted/CMakeLists.txt (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.md => samples/sample4-get-secrets-deleted/README.md} (100%) rename sdk/keyvault/azure-security-keyvault-secrets/{test => }/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.cpp (100%) diff --git a/sdk/keyvault/azure-security-keyvault-secrets/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-secrets/CMakeLists.txt index 561426777..cedd0ccb8 100644 --- a/sdk/keyvault/azure-security-keyvault-secrets/CMakeLists.txt +++ b/sdk/keyvault/azure-security-keyvault-secrets/CMakeLists.txt @@ -87,7 +87,7 @@ if (BUILD_PERFORMANCE_TESTS) endif() if(BUILD_SAMPLES) - add_subdirectory(test/samples) + add_subdirectory(samples) endif() az_vcpkg_export( diff --git a/sdk/keyvault/azure-security-keyvault-secrets/README.md b/sdk/keyvault/azure-security-keyvault-secrets/README.md index dc63e6fb8..195cfc3bb 100644 --- a/sdk/keyvault/azure-security-keyvault-secrets/README.md +++ b/sdk/keyvault/azure-security-keyvault-secrets/README.md @@ -157,21 +157,21 @@ You will notice that additional information is logged, like the client request I Several Azure Key Vault secrets client library samples are available to you in this GitHub repository. These samples provide example code for additional scenarios commonly encountered while working with Azure Key Vault: -* [Sample1-Basic-Operations](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations): +* [Sample1-Basic-Operations](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations): * Create a secret * Get a secret * Update a secret * Delete and Purge a secret -* [Sample2-Backup-Restore](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore): +* [Sample2-Backup-Restore](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore): * Backup a secret * Restore a deleted secret -* [Sample3-Delete-Recover](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover): +* [Sample3-Delete-Recover](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover): * Delete a secret * Recover a deleted Secret -* [Sample4-Get-Secrets-Deleted](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted): +* [Sample4-Get-Secrets-Deleted](https://github.com/Azure/azure-sdk-for-cpp/tree/main/sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted): * List all secrets * List all of a secrets versions * List all deletes secrets diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-secrets/samples/CMakeLists.txt similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/CMakeLists.txt rename to sdk/keyvault/azure-security-keyvault-secrets/samples/CMakeLists.txt diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations/CMakeLists.txt similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations/CMakeLists.txt rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations/CMakeLists.txt diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations/sample1-basic-operations.md b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations/README.md similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations/sample1-basic-operations.md rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations/README.md diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations/sample1-basic-operations.cpp b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations/sample1-basic-operations.cpp similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample1-basic-operations/sample1-basic-operations.cpp rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample1-basic-operations/sample1-basic-operations.cpp diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore/CMakeLists.txt similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore/CMakeLists.txt rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore/CMakeLists.txt diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore/sample2-backup-restore.md b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore/README.md similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore/sample2-backup-restore.md rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore/README.md diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore/sample2-backup-restore.cpp b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore/sample2-backup-restore.cpp similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample2-backup-restore/sample2-backup-restore.cpp rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample2-backup-restore/sample2-backup-restore.cpp diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover/CMakeLists.txt similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover/CMakeLists.txt rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover/CMakeLists.txt diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover/sample3-delete-recover.md b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover/README.md similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover/sample3-delete-recover.md rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover/README.md diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover/sample3-delete-recover.cpp b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover/sample3-delete-recover.cpp similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample3-delete-recover/sample3-delete-recover.cpp rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample3-delete-recover/sample3-delete-recover.cpp diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted/CMakeLists.txt similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted/CMakeLists.txt rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted/CMakeLists.txt diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.md b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted/README.md similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.md rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted/README.md diff --git a/sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.cpp b/sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.cpp similarity index 100% rename from sdk/keyvault/azure-security-keyvault-secrets/test/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.cpp rename to sdk/keyvault/azure-security-keyvault-secrets/samples/sample4-get-secrets-deleted/sample4-get-secrets-deleted.cpp