From 2a4f62d88ffbe6dfc74223b06bd7f04d91442495 Mon Sep 17 00:00:00 2001 From: Victor Vazquez Date: Thu, 14 Apr 2022 07:31:01 +0000 Subject: [PATCH] format --- .../src/attestation_client.cpp | 41 +++++++++++-------- .../azure/core/http/win_http_transport.hpp | 12 +++--- .../src/http/winhttp/win_http_transport.cpp | 12 ++++-- 3 files changed, 38 insertions(+), 27 deletions(-) diff --git a/sdk/attestation/azure-security-attestation/src/attestation_client.cpp b/sdk/attestation/azure-security-attestation/src/attestation_client.cpp index 8ef1f1c51..7f668749f 100644 --- a/sdk/attestation/azure-security-attestation/src/attestation_client.cpp +++ b/sdk/attestation/azure-security-attestation/src/attestation_client.cpp @@ -27,25 +27,30 @@ using namespace Azure::Core::Http::Policies::_internal; using namespace Azure::Core::Http::_internal; #if defined(BUILD_TRANSPORT_WINHTTP_ADAPTER) -// Whenever winHTTP transport is built, create a policy to make request with no client certificate for attestation requests +// Whenever winHTTP transport is built, create a policy to make request with no client certificate +// for attestation requests #include "azure/core/http/win_http_transport.hpp" namespace { - class SetNoClientCertificatePolicy : public Azure::Core::Http::Policies::HttpPolicy { - public: - std::unique_ptr Clone() const override - { - return std::make_unique(); - } +class SetNoClientCertificatePolicy : public Azure::Core::Http::Policies::HttpPolicy { +public: + std::unique_ptr Clone() const override + { + return std::make_unique(); + } - std::unique_ptr Send( - Azure::Core::Http::Request& request, - Azure::Core::Http::Policies::NextHttpPolicy nextHttpPolicy, - const Azure::Core::Context& ctx) const override { - return nextHttpPolicy.Send(request, Azure::Core::Http::_internal::WinHttpTransportContextProvider::GetNoClientCertificateContext(ctx)); - } - }; -} + std::unique_ptr Send( + Azure::Core::Http::Request& request, + Azure::Core::Http::Policies::NextHttpPolicy nextHttpPolicy, + const Azure::Core::Context& ctx) const override + { + return nextHttpPolicy.Send( + request, + Azure::Core::Http::_internal::WinHttpTransportContextProvider:: + GetNoClientCertificateContext(ctx)); + } +}; +} // namespace #endif AttestationClient::AttestationClient( @@ -67,11 +72,11 @@ AttestationClient::AttestationClient( } m_apiVersion = options.Version.ToString(); std::vector> perCallpolicies; - - #if defined(BUILD_TRANSPORT_WINHTTP_ADAPTER) + +#if defined(BUILD_TRANSPORT_WINHTTP_ADAPTER) // This configuration will make winHTTP to disable client certificate for all attestation requests perCallpolicies.emplace_back(std::make_unique()); - #endif +#endif m_pipeline = std::make_shared( options, diff --git a/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp b/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp index 91bd10b1a..063994573 100644 --- a/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp +++ b/sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp @@ -145,13 +145,13 @@ namespace Azure { namespace Core { namespace Http { * */ class WinHttpTransportContextProvider { - public: - // Factory with no constructor - WinHttpTransportContextProvider() = delete; + public: + // Factory with no constructor + WinHttpTransportContextProvider() = delete; - // Creates a set up token to make - static Azure::Core::Context GetNoClientCertificateContext(Azure::Core::Context const& parent); - static bool HasNoClientCertificateConfiguration(Azure::Core::Context const& context); + // Creates a set up token to make + static Azure::Core::Context GetNoClientCertificateContext(Azure::Core::Context const& parent); + static bool HasNoClientCertificateConfiguration(Azure::Core::Context const& context); }; } // namespace _internal diff --git a/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp b/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp index d4cad8033..1733a5987 100644 --- a/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp +++ b/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp @@ -200,11 +200,16 @@ Azure::Core::Context::Key NoClientCertificateConfiguration; } // namespace -Azure::Core::Context Azure::Core::Http::_internal::WinHttpTransportContextProvider::GetNoClientCertificateContext(Azure::Core::Context const& parent) { +Azure::Core::Context +Azure::Core::Http::_internal::WinHttpTransportContextProvider::GetNoClientCertificateContext( + Azure::Core::Context const& parent) +{ return parent.WithValue(NoClientCertificateConfiguration, true); } -bool Azure::Core::Http::_internal::WinHttpTransportContextProvider::HasNoClientCertificateConfiguration(Azure::Core::Context const& context) { +bool Azure::Core::Http::_internal::WinHttpTransportContextProvider:: + HasNoClientCertificateConfiguration(Azure::Core::Context const& context) +{ bool value = false; context.TryGetValue(NoClientCertificateConfiguration, value); return value; @@ -355,7 +360,8 @@ void WinHttpTransport::CreateRequestHandle(std::unique_ptr<_detail::HandleManage } // Option is set up by context settings only and is only available for SDK clients - if(m_noClientCert) { + if (m_noClientCert) + { // If the service requests TLS client certificates, we want to let the WinHTTP APIs know that // it's ok to initiate the request without a client certificate. //