diff --git a/sdk/core/azure-core/inc/azure/core/nullable.hpp b/sdk/core/azure-core/inc/azure/core/nullable.hpp index 97e97f89a..8468ff6cf 100644 --- a/sdk/core/azure-core/inc/azure/core/nullable.hpp +++ b/sdk/core/azure-core/inc/azure/core/nullable.hpp @@ -98,7 +98,7 @@ public: * @brief Destructs the contained value, if there is one. * */ - void Reset() noexcept /* enforces termination */ + void Reset() noexcept(std::is_nothrow_destructible::value) /* enforces termination */ { if (m_hasValue) { diff --git a/sdk/core/azure-core/inc/azure/core/operation.hpp b/sdk/core/azure-core/inc/azure/core/operation.hpp index 21336fcae..039ab3080 100644 --- a/sdk/core/azure-core/inc/azure/core/operation.hpp +++ b/sdk/core/azure-core/inc/azure/core/operation.hpp @@ -139,7 +139,7 @@ namespace Azure { namespace Core { * @brief Gets the current #Azure::Core::OperationStatus of the long-running operation. * */ - OperationStatus Status() const noexcept { return m_status; } + OperationStatus const& Status() const noexcept { return m_status; } /** * @brief Checks if the long-running operation is completed. diff --git a/sdk/core/azure-core/src/http/winhttp/win_http_request.hpp b/sdk/core/azure-core/src/http/winhttp/win_http_request.hpp index 2bf5601b2..97e083bff 100644 --- a/sdk/core/azure-core/src/http/winhttp/win_http_request.hpp +++ b/sdk/core/azure-core/src/http/winhttp/win_http_request.hpp @@ -55,7 +55,7 @@ namespace Azure { namespace Core { namespace Http { namespace _detail { DWORD_PTR dwContext, DWORD dwInternetStatus, LPVOID lpvStatusInformation, - DWORD dwStatusInformationLength) noexcept; + DWORD dwStatusInformationLength); /* * Callback from WinHTTP called after the TLS certificates are received when the caller sets diff --git a/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp b/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp index d19375e08..a48149071 100644 --- a/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp +++ b/sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp @@ -517,7 +517,7 @@ namespace Azure { namespace Core { namespace Http { namespace _detail { DWORD_PTR dwContext, DWORD internetStatus, LPVOID statusInformation, - DWORD statusInformationLength) noexcept + DWORD statusInformationLength) { // If we're called before our context has been set (on Open and Close callbacks), ignore the // status callback.