From 0df1cfa90fc60c8d55aa00f356b0963c3fccbde7 Mon Sep 17 00:00:00 2001 From: Kan Tang Date: Sun, 24 Jan 2021 20:28:34 -0800 Subject: [PATCH] Changed `DataLakeFileClient::Flush`'s `endingOffset` parameter's name to `position`. (#1449) * Changed DataLakeFileClient::Flush's endingOffset parameter's name to position. * Update CHANGELOG.md --- sdk/storage/azure-storage-files-datalake/CHANGELOG.md | 4 ++++ .../inc/azure/storage/files/datalake/datalake_file_client.hpp | 4 ++-- .../azure-storage-files-datalake/src/datalake_file_client.cpp | 4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/sdk/storage/azure-storage-files-datalake/CHANGELOG.md b/sdk/storage/azure-storage-files-datalake/CHANGELOG.md index db5ee1fe0..cee250d93 100644 --- a/sdk/storage/azure-storage-files-datalake/CHANGELOG.md +++ b/sdk/storage/azure-storage-files-datalake/CHANGELOG.md @@ -31,6 +31,10 @@ - Removed unused type `AccountResourceType` and `PathLeaseAction`. - Changed all previous `LeaseDuration` members to a new type named `LeaseDurationType`. +### Other Changes and Improvements + +- Changed `DataLakeFileClient::Flush`'s `endingOffset` parameter's name to `position`. + ## 12.0.0-beta.6 (2020-01-14) ### New Features diff --git a/sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/datalake_file_client.hpp b/sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/datalake_file_client.hpp index 7c65122cc..e7b6d6a15 100644 --- a/sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/datalake_file_client.hpp +++ b/sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/datalake_file_client.hpp @@ -98,7 +98,7 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { /** * @brief Flushes previous uploaded data to a file. - * @param endingOffset This parameter allows the caller to upload data in parallel and control + * @param position This parameter allows the caller to upload data in parallel and control * the order in which it is appended to the file. * The value must be the offset where the data is to be appended. * Uploaded data is not immediately flushed, or written, to the file. To flush, @@ -112,7 +112,7 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { * @remark This request is sent to dfs endpoint. */ Azure::Core::Response Flush( - int64_t endingOffset, + int64_t position, const FlushDataLakeFileOptions& options = FlushDataLakeFileOptions()) const; /** diff --git a/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp b/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp index a336ca898..5b01a97bd 100644 --- a/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp +++ b/sdk/storage/azure-storage-files-datalake/src/datalake_file_client.cpp @@ -222,11 +222,11 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { } Azure::Core::Response DataLakeFileClient::Flush( - int64_t endingOffset, + int64_t position, const FlushDataLakeFileOptions& options) const { Details::DataLakeRestClient::Path::FlushDataOptions protocolLayerOptions; - protocolLayerOptions.Position = endingOffset; + protocolLayerOptions.Position = position; protocolLayerOptions.RetainUncommittedData = options.RetainUncommittedData; protocolLayerOptions.Close = options.Close; protocolLayerOptions.ContentLength = 0;