From 0bc420af0af3a74e8d2020f9f224abcb77798a9b Mon Sep 17 00:00:00 2001 From: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Tue, 17 Aug 2021 09:50:47 -0700 Subject: [PATCH] Enable API review approval check for Java spring packages (#2759) Co-authored-by: praveenkuttappan --- eng/common/scripts/Create-APIReview.ps1 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1 index 3451cf7ab..5f1b0b320 100644 --- a/eng/common/scripts/Create-APIReview.ps1 +++ b/eng/common/scripts/Create-APIReview.ps1 @@ -140,7 +140,9 @@ if ($packages) else { # Return error code if status code is 201 for new data plane package - if ($pkgInfo.SdkType -eq "client" -and $pkgInfo.IsNewSdk) + # Temporarily enable API review for spring SDK types. Ideally this should be done be using 'IsReviewRequired' method in language side + # to override default check of SDK type client + if (($pkgInfo.SdkType -eq "client" -or $pkgInfo.SdkType -eq "spring") -and $pkgInfo.IsNewSdk) { if ($respCode -eq '201') {