From 0b9befe13d5190c6302f518c395a30af718984ed Mon Sep 17 00:00:00 2001 From: Victor Vazquez Date: Mon, 14 Dec 2020 17:01:12 -0800 Subject: [PATCH] update default value to true for the SDK CurlTransportSSLOptions -> NoRevoke (#1181) fixes: #1101 --- sdk/core/azure-core/CHANGELOG.md | 1 + sdk/core/azure-core/inc/azure/core/http/curl/curl.hpp | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md index e317c2bd9..cd6e5fd02 100644 --- a/sdk/core/azure-core/CHANGELOG.md +++ b/sdk/core/azure-core/CHANGELOG.md @@ -10,6 +10,7 @@ - Removed `DateTime::operator Duration()`. - Moved `Azure::Core::BearerTokenAuthenticationPolicy`, defined in `azure/core/credentials.hpp` to `Azure::Core::Http` namespace in `azure/core/http/policy.hpp` header. +- Changed default option `NoRevoke` from `CurlTransportSSLOptions` for the `CurlTransportOptions` to `true`. This disables the revocation list checking by default. ## 1.0.0-beta.3 (2020-11-11) diff --git a/sdk/core/azure-core/inc/azure/core/http/curl/curl.hpp b/sdk/core/azure-core/inc/azure/core/http/curl/curl.hpp index e4608cb80..3304cd078 100644 --- a/sdk/core/azure-core/inc/azure/core/http/curl/curl.hpp +++ b/sdk/core/azure-core/inc/azure/core/http/curl/curl.hpp @@ -26,7 +26,15 @@ namespace Azure { namespace Core { namespace Http { struct CurlTransportSSLOptions { bool AllowBeast = false; - bool NoRevoke = false; + /** + * @brief This option can disable the revocation list check. + * + * @remark Libcurl does revocation list check by default for ssl backends that supports this + * feature. However, the Azure SDK overrides libcurl's behavior and disables the revocation list + * check by default. + * + */ + bool NoRevoke = true; }; /**