2e817d5be8
# 🔍 Description ## Issue References 🔗 This pull request fixes #5918, when Kyuubi beeline executes incorrect SQL,it will exit with exception: ``` java.lang.NoClassDefFoundError: org/apache/thrift/transport/TTransportException ``` ## Describe Your Solution 🔧 1.Supply `org.apache.thrift:libthrift` to `kyuubi-beeline` module. 2.We should override BeeLine's handleSQLException method,makes it compatible As we discussed, only `org.apache.kyuubi.shaded.thrift.transport.TTransportException` will be received by `kyuubi-beeline`,so it‘s unnecessary to add libthrift dependency to `kyuubi-beeline`. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [ ] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [ ] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes #5919 from hadoopkandy/KYUUBI-5918. Closes #5918 ee96c4436 [kandy01.wang] [KYUUBI #5918] [Bug] kyuubi beeline exit with exception : java.lang.NoClassDefFoundError: org/apache/thrift/transport/TTransportException Authored-by: kandy01.wang <kandy01.wang@vipshop.com> Signed-off-by: Cheng Pan <chengpan@apache.org> |
||
|---|---|---|
| .. | ||
| src | ||
| pom.xml | ||
| README.md | ||
Kyuubi Hive BeeLine Module
Aiming to make a better supported beeline for Kyuubi
- Support to show launch engine log when getting KyuubiConnection(Done, available since v1.4.0-incubating)