c83ea54e00
fixe #286
I believe it should be simple for now and we can update it when need.
manually
Squashed commit of the following:
commit b618f82056e1b4c003dbde2b9eb9f01358dc3497
Author: ulysses-you <ulyssesyou18@gmail.com>
Date: Thu Jan 14 20:40:44 2021 +0800
merge
commit 8c76e7b5ce159c4e088c66dfc60ab50f821b8c78
Merge: 7f37def c6bf6eb
Author: ulysses-you <ulyssesyou18@gmail.com>
Date: Thu Jan 14 20:37:30 2021 +0800
Merge branch 'master' of https://github.com/yaooqinn/kyuubi into pr-template
commit 7f37def09273a7c28613b926189467e1364c8952
Author: ulysses-you <ulyssesyou18@gmail.com>
Date: Thu Jan 14 20:03:35 2021 +0800
add pr template
21 lines
813 B
Plaintext
21 lines
813 B
Plaintext
<!--
|
|
Thanks for sending a pull request! Here are some tips for you:
|
|
1. If this is your first time, please read our contributor guidelines: https://github.com/yaooqinn/kyuubi#contributing
|
|
-->
|
|
|
|
### Please add issue ID here?
|
|
<!-- replace ${issue ID} with the actual issue id -->
|
|
Fixes ${issue ID}
|
|
|
|
### Why are the changes needed?
|
|
<!--
|
|
Please clarify why the changes are needed. For instance,
|
|
1. If you add a feature, you can talk about the user case of it.
|
|
2. If you fix a bug, you can clarify why it is a bug.
|
|
-->
|
|
|
|
### Test Plan:
|
|
- Add some test cases that check the changes thoroughly including negative and positive cases if possible
|
|
- Add screenshots for manual tests if appropriate
|
|
- [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
|