d3e17680f5
# 🔍 Description ## Issue References 🔗 This pull request fixes #6485 ## Describe Your Solution 🔧 Ignore uppercase and lowercase letters in table names when using regular expressions to match. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Added unit tests when table names have capital letters. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6605 from BruceWong96/fix-presto-regex. Closes #6485 06f737f24 [Bruce Wong] Fix typos 93071754a [Bruce Wong] Added unit tests for table names with both upper and lower case letters 9837030a1 [Bruce Wong] fix table not found Authored-by: Bruce Wong <603334301@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
105 lines
4.5 KiB
Python
105 lines
4.5 KiB
Python
from __future__ import absolute_import
|
|
from __future__ import unicode_literals
|
|
|
|
import re
|
|
from builtins import str
|
|
|
|
import sqlalchemy
|
|
|
|
from pyhive.tests.sqlalchemy_test_case import SqlAlchemyTestCase
|
|
from pyhive.tests.sqlalchemy_test_case import with_engine_connection
|
|
from sqlalchemy import types
|
|
from sqlalchemy.engine import create_engine
|
|
from sqlalchemy.schema import Column
|
|
from sqlalchemy.schema import MetaData
|
|
from sqlalchemy.schema import Table
|
|
from sqlalchemy.sql import text
|
|
from sqlalchemy.types import String
|
|
from decimal import Decimal
|
|
|
|
import contextlib
|
|
import unittest
|
|
|
|
|
|
class TestSqlAlchemyPresto(unittest.TestCase, SqlAlchemyTestCase):
|
|
def create_engine(self):
|
|
return create_engine('presto://localhost:8080/hive/default?source={}'.format(self.id()))
|
|
|
|
def test_bad_format(self):
|
|
self.assertRaises(
|
|
ValueError,
|
|
lambda: create_engine('presto://localhost:8080/hive/default/what'),
|
|
)
|
|
|
|
@with_engine_connection
|
|
def test_reflect_select(self, engine, connection):
|
|
"""reflecttable should be able to fill in a table from the name"""
|
|
one_row_complex = Table('one_row_complex', MetaData(), autoload_with=engine)
|
|
# Presto ignores the union column
|
|
self.assertEqual(len(one_row_complex.c), 15 - 1)
|
|
self.assertIsInstance(one_row_complex.c.string, Column)
|
|
rows = connection.execute(one_row_complex.select()).fetchall()
|
|
self.assertEqual(len(rows), 1)
|
|
self.assertEqual(list(rows[0]), [
|
|
True,
|
|
127,
|
|
32767,
|
|
2147483647,
|
|
9223372036854775807,
|
|
0.5,
|
|
0.25,
|
|
'a string',
|
|
'1970-01-01 00:00:00.000',
|
|
b'123',
|
|
[1, 2],
|
|
{"1": 2, "3": 4}, # Presto converts all keys to strings so that they're valid JSON
|
|
[1, 2], # struct is returned as a list of elements
|
|
# '{0:1}',
|
|
Decimal('0.1'),
|
|
])
|
|
|
|
# TODO some of these types could be filled in better
|
|
self.assertIsInstance(one_row_complex.c.boolean.type, types.Boolean)
|
|
self.assertIsInstance(one_row_complex.c.tinyint.type, types.Integer)
|
|
self.assertIsInstance(one_row_complex.c.smallint.type, types.Integer)
|
|
self.assertIsInstance(one_row_complex.c.int.type, types.Integer)
|
|
self.assertIsInstance(one_row_complex.c.bigint.type, types.BigInteger)
|
|
self.assertIsInstance(one_row_complex.c.float.type, types.Float)
|
|
self.assertIsInstance(one_row_complex.c.double.type, types.Float)
|
|
self.assertIsInstance(one_row_complex.c.string.type, String)
|
|
self.assertIsInstance(one_row_complex.c.timestamp.type, types.TIMESTAMP)
|
|
self.assertIsInstance(one_row_complex.c.binary.type, types.VARBINARY)
|
|
self.assertIsInstance(one_row_complex.c.array.type, types.NullType)
|
|
self.assertIsInstance(one_row_complex.c.map.type, types.NullType)
|
|
self.assertIsInstance(one_row_complex.c.struct.type, types.NullType)
|
|
self.assertIsInstance(one_row_complex.c.decimal.type, types.NullType)
|
|
|
|
def test_url_default(self):
|
|
engine = create_engine('presto://localhost:8080/hive')
|
|
try:
|
|
with contextlib.closing(engine.connect()) as connection:
|
|
self.assertEqual(connection.execute(text('SELECT 1 AS foobar FROM one_row')).scalar(), 1)
|
|
finally:
|
|
engine.dispose()
|
|
|
|
@with_engine_connection
|
|
def test_reserved_words(self, engine, connection):
|
|
"""Presto uses double quotes, not backticks"""
|
|
# Use keywords for the table/column name
|
|
fake_table = Table('select', MetaData(), Column('current_timestamp', String))
|
|
query = str(fake_table.select().where(fake_table.c.current_timestamp == 'a').compile(engine))
|
|
self.assertIn('"select"', query)
|
|
self.assertIn('"current_timestamp"', query)
|
|
self.assertNotIn('`select`', query)
|
|
self.assertNotIn('`current_timestamp`', query)
|
|
|
|
@with_engine_connection
|
|
def test_hash_table(self, engine, connection):
|
|
sqlalchemy_version = float(re.search(r"^([\d]+\.[\d]+)\..+", sqlalchemy.__version__).group(1))
|
|
if sqlalchemy_version >= 1.4:
|
|
insp = sqlalchemy.inspect(engine)
|
|
self.assertFalse(insp.has_table("THIS_TABLE_DOSE_NOT_EXIST"))
|
|
self.assertFalse(insp.has_table("THIS_TABLE_DOSE_not_exist"))
|
|
else:
|
|
self.assertFalse(Table('THIS_TABLE_DOSE_NOT_EXIST', MetaData(bind=engine)).exists())
|
|
self.assertFalse(Table('THIS_TABLE_DOSE_not_exits', MetaData(bind=engine)).exists()) |