6cd2ad9ef7
### _Why are the changes needed?_ 1. reformat code should include all of the modules in the project. 2. stylecheck should include all of the modules in the project. 3. there is a bug in the stage `Upload style check report`. Since the `grep` returns code 1 when the pattern is not found, the upload report does not work before this pr. ``` > echo "a" > /tmp/a; grep abc /tmp/a; echo $? 1 ``` Before this PR ``` Run for log in `find * -name "scalastyle-output.xml"`; do echo "=========$log========="; grep "error" $log; done =========dev/kyuubi-tpcds/target/scalastyle-output.xml========= Error: Process completed with exit code 1. ``` After this PR ``` Run for log in `find * -name "scalastyle-output.xml"`; <?xml version="1.0" encoding="UTF-8"?> <checkstyle version="5.0"> <file name="/home/runner/work/incubator-kyuubi/incubator-kyuubi/extensions/spark/kyuubi-extension-spark-3-3/src/main/scala/org/apache/kyuubi/sql/KyuubiSparkSQLExtension.scala"> <error column="0" line="21" source="org.scalastyle.scalariform.ImportOrderChecker" severity="error" message="There should at least one a single empty line separating groups 3rdParty and kyuubi."/> </file> </checkstyle> ``` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2780 from cfmcgrady/refine-stylecheck. Closes #2780 a9c4a71e [Fu Chen] update reformat f5d4d4e4 [Fu Chen] address comment 0665e7e5 [Fu Chen] address 91d123ee [Fu Chen] fix f5d6414f [Fu Chen] style.yml c56fa081 [Fu Chen] dev/reformat Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org> |
||
|---|---|---|
| .. | ||
| actions/tune-runner-vm | ||
| ISSUE_TEMPLATE | ||
| workflows | ||
| labeler.yml | ||
| PULL_REQUEST_TEMPLATE | ||