apache/kyuubi
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity
4ae0003874
kyuubi/docker
History
phyyou b81aef5583
[KYUUBI #4589] [HELM] Update template on port-foward usage guide NOTES.txt 
- Fix Stale Docs URL in Helm Chart
- ~~Update kyuubiDefaults structure~~
- Update NOTES.txt
  - When kyuubi.kyuubiConf.kyuubiDefaults."kyuubi.frontend.bind.host" set localhost, render port-forward example  in NOTES.txt for development usage guide
- ~~Add extraFiles for config mount~~
  - ~~extraFiles for another file mount in kyuubi conf directory.~~

### _Why are the changes needed?_

Based on https://github.com/apache/kyuubi/issues/4561#issuecomment-1481026954_

> I think Helm chart notes had been wrong from this commit.

>dbb741fc5b/charts/kyuubi/templates/NOTES.txt (L33-L34)

> Can we delete this note or update this note  if `--address` option is work like this? :
> ```suggestion
>  - To access {{ $.Release.Name }}-{{ $name | kebabcase }} service from outside the cluster for debugging, run the following > >
> command:
>     kubectl port-forward svc/{{ $.Release.Name }}-{{ $name | kebabcase }} {{ tpl $frontend.service.port $ }}:{{ tpl >?> >$frontend.service.port $ }} -n {{ $.Release.Namespace }} --address <your-ip>
> ```

~~and more changes:~~
- ~~Update `.Values.kyuubiConf.kyuubiDefaults` to dict for more variant usage in templates. (like NOTES.txt changes)~~
- ~~Add extraFiles in configmap for like mounting hive-site-xml on kyuubi config directory.~~

### _How was this patch tested?_

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4589 from phyyou/feat/helm-chart-improve.

Closes #4589

d7ee29e95 [phyyou] Fix regex when no equal sign
0b86f280a [phyyou] Update condition for edge case
4edf904f5 [phyyou] chore
aabe93ca9 [PHYYOU] Update kyuubiDefaults example guide in Helm Chart
4de896446 [phyyou] Add README.md for Kyuubi Helm Chart (It from airflow chart README.md)
abacd3277 [phyyou] Add Example Usecases in kyuubiConf
ebcb2310a [phyyou] Update empty string to nil
2533a9306 [phyyou] Revert extraFiles
56fa525a5 [phyyou] Revert kyuubiConf Structure Update Update NOTES.txt for Reverted values
966e74c50 [phyyou] fix: template => include
03d698442 [phyyou] Fix: Add EOF
e6affddf7 [phyyou] Add extraFiles for config mount
b0963fd48 [phyyou] Update NOTES.txt;
ac9766ab9 [phyyou] Update kyuubiDefaults structure
77eaa05ac [phyyou] Fix Stale Docs URL

Lead-authored-by: phyyou <gydudwls@gmail.com>
Co-authored-by: PHYYOU <34825352+phyyou@users.noreply.github.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 0ebeddae39)
Signed-off-by: Cheng Pan <chengpan@apache.org>
2023-03-24 21:30:25 +08:00
..
playground [KYUUBI #4338] Bump Spark from 3.3.1 to 3.3.2 2023-02-19 00:08:15 +08:00
Dockerfile [KYUUBI #4288] Use eclipse-temurin:8-jdk-focal as default base image 2023-02-10 12:25:57 +08:00
kyuubi-configmap.yaml [KYUUBI #4589] [HELM] Update template on port-foward usage guide NOTES.txt 2023-03-24 21:30:25 +08:00
kyuubi-deployment.yaml [KYUUBI #4020] remove incubating from kyuubi source code 2023-01-04 09:43:20 +08:00
kyuubi-pod.yaml [KYUUBI #4020] remove incubating from kyuubi source code 2023-01-04 09:43:20 +08:00
kyuubi-service.yaml [KYUUBI #4020] remove incubating from kyuubi source code 2023-01-04 09:43:20 +08:00