[KYUUBI #1679] Remove invalid column and field number check
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> ResultSet checks if the column number of data matches the one in metadata by calling iterator.next() to get a sample row, which would make the first row missing in the final result. The bug didn't appear in the tests, because the condition is wrong. Fixed by c0e9072a4c3383562b0fe1938e3bfa1947376754. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [X] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1680 from link3280/bugfix/flink_invliad_resultset. Closes #1679 238809d0 [Paul Lin] Fix first row missing in ResultSet c0e9072a [Paul Lam] Fix ArrayIndexOutOfBoundsException in ResultSet Lead-authored-by: Paul Lam <link3280@gmail.com> Co-authored-by: Paul Lin <paullin3280@gmail.com> Signed-off-by: yanghua <yanghua1127@gmail.com>
This commit is contained in:
parent
e4f5ba7010
commit
e0d9458144
@ -53,11 +53,6 @@ public class ResultSet {
|
||||
this.resultKind = Preconditions.checkNotNull(resultKind, "resultKind must not be null");
|
||||
this.columns = Preconditions.checkNotNull(columns, "columns must not be null");
|
||||
this.data = Preconditions.checkNotNull(data, "data must not be null");
|
||||
if (!data.hasNext()) {
|
||||
Preconditions.checkArgument(
|
||||
columns.size() == data.next().getArity(),
|
||||
"the size of columns and the number of fields in the row should be equal");
|
||||
}
|
||||
this.changeFlags = changeFlags;
|
||||
if (changeFlags != null) {
|
||||
Preconditions.checkArgument(
|
||||
|
||||
Loading…
Reference in New Issue
Block a user