[KYUUBI #303] Add host:port msg if we failed to initialize
 [](https://github.com/yaooqinn/kyuubi/pull/303) [❨?❩](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT --> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html --> <!-- replace ${issue ID} with the actual issue id --> Fixes #303 <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the user case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Before this PR, if we start Kyuubi with an already used port, we will get this error msg. It's better to print host:port which we bind. ``` Exception in thread "main" org.apache.kyuubi.KyuubiException: Failed to initialize frontend service at org.apache.kyuubi.service.FrontendService.initialize(FrontendService.scala:102) at org.apache.kyuubi.service.CompositeService.$anonfun$initialize$1(CompositeService.scala:40) at org.apache.kyuubi.service.CompositeService.$anonfun$initialize$1$adapted(CompositeService.scala:40) at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62) at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49) at org.apache.kyuubi.service.CompositeService.initialize(CompositeService.scala:40) at org.apache.kyuubi.service.Serverable.initialize(Serverable.scala:37) at org.apache.kyuubi.server.KyuubiServer.initialize(KyuubiServer.scala:88) at org.apache.kyuubi.server.KyuubiServer$.startServer(KyuubiServer.scala:45) at org.apache.kyuubi.server.KyuubiServer$.main(KyuubiServer.scala:74) at org.apache.kyuubi.server.KyuubiServer.main(KyuubiServer.scala) Caused by: java.net.BindException: Address already in use at java.net.PlainSocketImpl.socketBind(Native Method) at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387) at java.net.ServerSocket.bind(ServerSocket.java:375) at java.net.ServerSocket.<init>(ServerSocket.java:237) at org.apache.kyuubi.service.FrontendService.initialize(FrontendService.scala:77) ... 11 more ``` - Add some test cases that check the changes thoroughly including negative and positive cases if possible - Add screenshots for manual tests if appropriate - [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Squashed commit of the following: commit c3f5ffa3dae5d9822ae9b0d8eec879e971ccdea2 Author: ulysses-you <ulyssesyou18@gmail.com> Date: Tue Jan 26 18:23:40 2021 +0800 fix commit 42d333de2c1edc0373c737053ff6c28b48a41cf7 Author: ulysses-you <ulyssesyou18@gmail.com> Date: Tue Jan 26 14:44:35 2021 +0800 err msg
This commit is contained in:
parent
666593c426
commit
d44afdb346
@ -99,7 +99,8 @@ class FrontendService private (name: String, be: BackendService, oomHook: Runnab
|
||||
s" [$minThreads, $maxThreads] worker threads")
|
||||
} catch {
|
||||
case e: Throwable =>
|
||||
throw new KyuubiException("Failed to initialize frontend service", e)
|
||||
throw new KyuubiException(
|
||||
s"Failed to initialize frontend service on $serverAddr:$portNum.", e)
|
||||
}
|
||||
super.initialize(conf)
|
||||
}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user