apache/kyuubi
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

[KYUUBI #1267] Modify comments for the golden file test suite and fix it

Browse Source 
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

Modify comments for the golden file test suite and fix it,  see #1267 for details.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [X] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1272 from wForget/KYUUBI-1267.

Closes #1267

f8c4c586 [wForget] [KYUUBI #1267] Make appName and appId to lazy
417c9db7 [wForget] Merge branch 'master' of https://github.com/apache/incubator-kyuubi into KYUUBI-1267
512458be [wForget] [KYUUBI #1267] Modify comments for the golden file test suite and fix it

Authored-by: wForget <643348094@qq.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
This commit is contained in:
wForget 2021-10-25 14:49:20 +08:00 committed by ulysses-you
parent ed9820a907
commit ccb8117cff
No known key found for this signature in database
GPG Key ID: 4C500BC62D576766
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala vendored
View File

@ -31,8 +31,8 @@ object KDFRegistry {
@transient @transient
val registeredFunctions = new ArrayBuffer[KyuubiDefinedFunction]() val registeredFunctions = new ArrayBuffer[KyuubiDefinedFunction]()
val appName = SparkEnv.get.conf.get("spark.app.name") lazy val appName = SparkEnv.get.conf.get("spark.app.name")
val appId = SparkEnv.get.conf.get("spark.app.id") lazy val appId = SparkEnv.get.conf.get("spark.app.id")
val kyuubi_version: KyuubiDefinedFunction = create( val kyuubi_version: KyuubiDefinedFunction = create(
"kyuubi_version", "kyuubi_version",

4
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/udf/KyuubiDefinedFunctionSuite.scala vendored
View File

@ -30,12 +30,12 @@ import org.apache.kyuubi.{KyuubiFunSuite, TestUtils}
* *
* To run the entire test suite: * To run the entire test suite:
* {{{ * {{{
* build/mvn test -DwildcardSuites=org.apache.kyuubi.engine.spark.udf.KyuubiDefinedFunctionSuite -pl '!externals/kyuubi-download' * build/mvn clean install -Pspark-provided -DwildcardSuites=org.apache.kyuubi.engine.spark.udf.KyuubiDefinedFunctionSuite
* }}} * }}}
* *
* To re-generate golden files for entire suite, run: * To re-generate golden files for entire suite, run:
* {{{ * {{{
* KYUUBI_UPDATE=1 build/mvn test -DwildcardSuites=org.apache.kyuubi.engine.spark.udf.KyuubiDefinedFunctionSuite -pl '!externals/kyuubi-download' * KYUUBI_UPDATE=1 build/mvn clean install -Pspark-provided -DwildcardSuites=org.apache.kyuubi.engine.spark.udf.KyuubiDefinedFunctionSuite
* }}} * }}}
*/ */
// scalastyle:on line.size.limit // scalastyle:on line.size.limit

4
kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
View File

@ -35,12 +35,12 @@ import org.apache.kyuubi.zookeeper.ZookeeperConf
* *
* To run the entire test suite: * To run the entire test suite:
* {{{ * {{{
* build/mvn test -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration -pl '!externals/kyuubi-download' * build/mvn clean install -Pspark-provided -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
* }}} * }}}
* *
* To re-generate golden files for entire suite, run: * To re-generate golden files for entire suite, run:
* {{{ * {{{
* KYUUBI_UPDATE=1 build/mvn test -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration -pl '!externals/kyuubi-download' * KYUUBI_UPDATE=1 build/mvn clean install -Pspark-provided -DwildcardSuites=org.apache.kyuubi.config.AllKyuubiConfiguration
* }}} * }}}
*/ */
// scalastyle:on line.size.limit // scalastyle:on line.size.limit

4
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/tpcds/OutputSchemaTPCDSSuite.scala
View File

@ -29,12 +29,12 @@ import org.apache.kyuubi.tags.{DeltaTest, ExtendedSQLTest}
/** /**
* To run this test suite: * To run this test suite:
* {{{ * {{{
* build/mvn test -Pspark-3.1 -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite -Dmaven.plugin.scalatest.exclude.tags='' * build/mvn clean install -Pspark-3.1 -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite
* }}} * }}}
* *
* To re-generate golden files for this suite: * To re-generate golden files for this suite:
* {{{ * {{{
* KYUUBI_UPDATE=1 build/mvn test -Pspark-3.1 -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite -Dmaven.plugin.scalatest.exclude.tags='' * KYUUBI_UPDATE=1 build/mvn clean install -Pspark-3.1 -Dtest=none -DwildcardSuites=org.apache.kyuubi.operation.tpcds.OutputSchemaTPCDSSuite
* }}} * }}}
*/ */
// scalastyle:on line.size.limit // scalastyle:on line.size.limit