From c1e5545c648fbd9d62c562014447eea205849094 Mon Sep 17 00:00:00 2001 From: timothy65535 Date: Tue, 7 Sep 2021 09:46:53 +0800 Subject: [PATCH] [KYUUBI #1043] Let spark history logger handle events asynchronously ### _Why are the changes needed?_ > there seems to be no good way to solve the synchronization problem. For `EventLoggerType.SPARK` This looks simple, Please send a separate PR to solve this issue ```git - sc.eventLogger.foreach(_.onOtherEvent(kyuubiEvent)) + sc.listenerBus.post(kyuubiEvent) ``` _Originally posted by yaooqinn in https://github.com/apache/incubator-kyuubi/issues/1023#issuecomment-913558016_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1044 from timothy65535/1043. Closes #1043 0ea1d4f7 [timothy65535] [KYUUBI #1043] Let spark history logger handle events asynchronously Authored-by: timothy65535 Signed-off-by: ulysses-you --- .../main/scala/org/apache/spark/kyuubi/SparkContextHelper.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkContextHelper.scala b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkContextHelper.scala index dd10718a8..667bd984a 100644 --- a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkContextHelper.scala +++ b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkContextHelper.scala @@ -38,6 +38,6 @@ object SparkContextHelper { */ private class SparkHistoryEventLogger(sc: SparkContext) extends EventLogger[KyuubiSparkEvent] { override def logEvent(kyuubiEvent: KyuubiSparkEvent): Unit = { - sc.eventLogger.foreach(_.onOtherEvent(kyuubiEvent)) + sc.listenerBus.post(kyuubiEvent) } }