From ba26de688e112f84060201439cce9b8832a15cbb Mon Sep 17 00:00:00 2001
From: Cheng Pan <379377944@qq.com>
Date: Thu, 22 Apr 2021 20:45:43 +0800
Subject: [PATCH] [KYUUBI #563] [TEST] Bump scalatest 3.2.8

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
Bump the latest version of scalatest.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request

Closes #563 from pan3793/scalatest.

Closes #563

1b7f844 [Cheng Pan] [TEST] Bump scalatest 3.2.8

Authored-by: Cheng Pan <379377944@qq.com>
Signed-off-by: fwang12 <fwang12@ebay.com>
---
 pom.xml               | 2 +-
 scalastyle-config.xml | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/pom.xml b/pom.xml
index dc7827d55..05b456c4a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -81,7 +81,7 @@
         <slf4j.version>1.7.30</slf4j.version>
         <zookeeper.version>3.4.14</zookeeper.version>
 
-        <scalatest.version>3.1.4</scalatest.version>
+        <scalatest.version>3.2.8</scalatest.version>
         <iceberg.name>iceberg-spark3-runtime</iceberg.name>
         <iceberg.version>0.11.1</iceberg.version>
 
diff --git a/scalastyle-config.xml b/scalastyle-config.xml
index 743a3e4cf..f7d0d2449 100644
--- a/scalastyle-config.xml
+++ b/scalastyle-config.xml
@@ -135,12 +135,6 @@ This file is divided into 3 sections:
   <!-- ??? usually shouldn't be checked into the code base. -->
   <check level="error" class="org.scalastyle.scalariform.NotImplementedErrorUsage" enabled="true"/>
 
-  // remove this after upgrade to scalatest 3.2.x
-  <check customId="funsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
-    <parameters><parameter name="regex">^FunSuite[A-Za-z]*$</parameter></parameters>
-    <customMessage>Tests must extend org.apache.kyuubi.KyuubiFunSuite instead.</customMessage>
-  </check>
-
   <check customId="anyfunsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
     <parameters><parameter name="regex">^AnyFunSuite[A-Za-z]*$</parameter></parameters>
     <customMessage>Tests must extend org.apache.kyuubi.KyuubiFunSuite instead.</customMessage>