apache/kyuubi
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

[KYUUBI #689] Fix MetricsSystemSuite on JDK 11

Browse Source 
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
Fix #689.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request

Closes #690 from pan3793/689.

Closes #689

bd64a666 [Cheng Pan] Revert "[GA] Enable JDK 11 in GA"
ab103cf3 [Cheng Pan] [GA] Enable JDK 11 in GA
1762f92b [Cheng Pan] Fix MetricsSystemSuite on G1

Authored-by: Cheng Pan <379377944@qq.com>
Signed-off-by: Kent Yao <yao@apache.org>
This commit is contained in:
Cheng Pan 2021-06-13 23:15:51 +08:00 committed by Kent Yao
parent fcab159112
commit a1cc06ce97
No known key found for this signature in database
GPG Key ID: F7051850A0AF904D
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kyuubi-metrics/src/test/scala/org/apache/kyuubi/metrics/MetricsSystemSuite.scala
View File

@ -64,7 +64,7 @@ class MetricsSystemSuite extends KyuubiFunSuite {
val client: HttpClient = new HttpClient
client.start()
val res: ContentResponse = client.GET(prometheusHttpServer.getURI.resolve(testContextPath))
assert(res.getContentAsString.contains("PS_MarkSweep_count"))
assert(res.getContentAsString.contains("heap_usage"))
assert(res.getContentAsString.contains("kyuubi_connection_opened 2021.0"))
client.stop()
@ -83,7 +83,7 @@ class MetricsSystemSuite extends KyuubiFunSuite {
metricsSystem.initialize(conf)
metricsSystem.start()
val reportFile = Paths.get(reportPath.toString, "report.json")
checkJsonFileMetrics(reportFile, "PS-MarkSweep.count")
checkJsonFileMetrics(reportFile, "heap.usage")
metricsSystem.incCount(MetricsConstants.STATEMENT_TOTAL)
checkJsonFileMetrics(reportFile, MetricsConstants.STATEMENT_TOTAL)