From 8e8679e92bf7a0e175895bfb6177330a8c2b176f Mon Sep 17 00:00:00 2001
From: Kent Yao <yao@apache.org>
Date: Wed, 3 Mar 2021 22:23:38 +0800
Subject: [PATCH] [KYUUBI #392] Remove netty dependency

![yaooqinn](https://badgen.net/badge/Hello/yaooqinn/green) [![Closes #392](https://badgen.net/badge/Preview/Closes%20%23392/blue)](https://github.com/yaooqinn/kyuubi/pull/392) ![0](https://badgen.net/badge/%2B/0/red) ![23](https://badgen.net/badge/-/23/green) ![2](https://badgen.net/badge/commits/2/yellow) ![Target Issue](https://badgen.net/badge/Missing/Target%20Issue/ff0000) [&#10088;?&#10089;](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

netty is unnecessary

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request

Closes #392 from yaooqinn/netty.

824d84e [Kent Yao] nit
402317d [Kent Yao] Remove netty dependency

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
---
 kyuubi-assembly/pom.xml | 4 ----
 kyuubi-ha/pom.xml       | 6 ------
 kyuubi-main/pom.xml     | 6 ------
 pom.xml                 | 7 -------
 4 files changed, 23 deletions(-)

diff --git a/kyuubi-assembly/pom.xml b/kyuubi-assembly/pom.xml
index 88f8ffcaa..5482e7853 100644
--- a/kyuubi-assembly/pom.xml
+++ b/kyuubi-assembly/pom.xml
@@ -77,10 +77,6 @@
             <artifactId>curator-test</artifactId>
         </dependency>
 
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty</artifactId>
-        </dependency>
         <!-- end: for EmbeddedZkServer -->
 
         <!-- default package with log4j -->
diff --git a/kyuubi-ha/pom.xml b/kyuubi-ha/pom.xml
index f563710f1..2143b957d 100644
--- a/kyuubi-ha/pom.xml
+++ b/kyuubi-ha/pom.xml
@@ -65,12 +65,6 @@
             <artifactId>curator-test</artifactId>
             <scope>provided</scope>
         </dependency>
-
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty</artifactId>
-            <scope>provided</scope>
-        </dependency>
         <!-- End: for EmbeddedZkServer -->
 
         <dependency>
diff --git a/kyuubi-main/pom.xml b/kyuubi-main/pom.xml
index 1f1b8c4f2..cafb4bc6b 100644
--- a/kyuubi-main/pom.xml
+++ b/kyuubi-main/pom.xml
@@ -115,12 +115,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty</artifactId>
-            <scope>test</scope>
-        </dependency>
-
         <dependency>
             <groupId>org.apache.iceberg</groupId>
             <artifactId>${iceberg.name}</artifactId>
diff --git a/pom.xml b/pom.xml
index 1a98b9f64..dcb847342 100644
--- a/pom.xml
+++ b/pom.xml
@@ -67,7 +67,6 @@
         <curator.version>2.12.0</curator.version>
         <hadoop.version>2.7.4</hadoop.version>
         <hive.version>2.3.7</hive.version>
-        <netty3.version>3.7.0.Final</netty3.version>
         <spark.version>3.0.2</spark.version>
         <slf4j.version>1.7.30</slf4j.version>
         <zookeeper.version>3.4.14</zookeeper.version>
@@ -806,12 +805,6 @@
                 </exclusions>
             </dependency>
 
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty</artifactId>
-                <version>${netty3.version}</version>
-            </dependency>
-
             <dependency>
                 <groupId>org.apache.iceberg</groupId>
                 <artifactId>${iceberg.name}</artifactId>