apache/kyuubi
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

[KYUUBI #791] Fix point to right repo in PULL_REQUEST_TEMPLATE (#792)

Browse Source 
* [KYUUBI 791] Fix point to right repo in PULL_REQUEST_TEMPLATE

* improve contributions.md
This commit is contained in:
timothy65535 2021-07-13 22:47:59 +08:00 committed by GitHub
parent 7027898cb3
commit 8b76cc4bca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/PULL_REQUEST_TEMPLATE vendored
View File

@ -3,7 +3,7 @@ Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

12
docs/community/contributions.md
View File

@ -2,12 +2,12 @@
# Contribution Guidelines
**Kyuubi** is an [Apache License v2.0](https://github.com/NetEase/kyuubi/blob/master/LICENSE) open source software.
**Kyuubi** is an [Apache License v2.0](https://github.com/apache/incubator-kyuubi/blob/master/LICENSE) open source software.
Contributing to Kyuubi including source code, documents, tests e.t.c. means that you agree to the Apache License v2.0.
- Better to search the issue history first before reporting an <a class="github-button" href="https://github.com/NetEase/kyuubi/issues" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-issue-opened" data-show-count="true" aria-label="Issue NetEase/kyuubi on GitHub">Issue</a>
- Better to create an <a class="github-button" href="https://github.com/NetEase/kyuubi/issues" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-issue-opened" data-show-count="true" aria-label="Issue NetEase/kyuubi on GitHub">Issue</a> to describe the feature or bug first before make a pull request.
- Better to search the issue history first before reporting an <a class="github-button" href="https://github.com/apache/incubator-kyuubi/issues" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-issue-opened" data-show-count="true" aria-label="Issue NetEase/kyuubi on GitHub">Issue</a>
- Better to create an <a class="github-button" href="https://github.com/apache/incubator-kyuubi/issues" data-color-scheme="no-preference: light; light: dark; dark: light;" data-icon="octicon-issue-opened" data-show-count="true" aria-label="Issue NetEase/kyuubi on GitHub">Issue</a> to describe the feature or bug first before make a pull request.
- Better to use English for world widely understanding.
- Ask us anything
@ -17,12 +17,12 @@ Before you start, please read the [Code of Conduct](http://www.apache.org/founda
If you are new to submit a Pull Request, the follow steps are helpful to you.
1. An available [git](https://git-scm.com/downloads), you can run `git version` if you not sure you have
2. Fork [Kyuubi](https://github.com/NetEase/kyuubi) on github, now you have a cloned Kyuubi repo
2. Fork [Kyuubi](https://github.com/apache/incubator-kyuubi) on github, now you have a cloned Kyuubi repo
3. Clone your Kyuubi repo with cmd `git clone https://github.com/${yourname}/kyuubi.git`
4. Create a new branch with cmd `git checkout -b test-branch`
5. Modify the code you want
6. Commit and push code to your Kyuubi repo with commd `git commit -am "comment"; git push test-branch test-branch`
7. Back to [Kyuubi](https://github.com/NetEase/kyuubi), you can see a banner about `new pull request`
7. Back to [Kyuubi](https://github.com/apache/incubator-kyuubi), you can see a banner about `new pull request`
8. Now we can create a pull request to Kyuubi
## Creating a Pull Request
@ -43,7 +43,7 @@ Here are some tips for you:
### _Which issue are you going to fix?_
<!--
Replace ${ID} below with the actual issue id from
https://github.com/NetEase/kyuubi/issues,
https://github.com/apache/incubator-kyuubi/issues,
so that the issue will be linked and automatically closed after merging
-->