From 825c70db7b97543241a46f813a77606dc92efd43 Mon Sep 17 00:00:00 2001 From: Tianlin Liao Date: Tue, 21 Jun 2022 12:46:49 +0800 Subject: [PATCH] [KYUUBI #2919] Fix typo and wording for JDBCMetadataStoreConf ### _Why are the changes needed?_ Fix typo and wording for JDBCMetadataStoreConf. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2919 from lightning-L/typo-1. Closes #2919 f02ffb8a [Tianlin Liao] fix typo and wording for JDBCMetadataStoreConf Authored-by: Tianlin Liao Signed-off-by: Fei Wang --- docs/deployment/settings.md | 2 +- .../kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/deployment/settings.md b/docs/deployment/settings.md index 8e2645cdf..abf1e737b 100644 --- a/docs/deployment/settings.md +++ b/docs/deployment/settings.md @@ -350,7 +350,7 @@ kyuubi.metadata.request.retry.queue.size|65536|The maximum queue size for buffer kyuubi.metadata.request.retry.threads|10|Number of threads in the metadata request retry manager thread pool. The metadata store might be unavailable sometimes and the requests will fail, to tolerant for this case and unblock the main thread, we support to retry the failed requests in async way.|int|1.6.0 kyuubi.metadata.store.class|org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore|Fully qualified class name for server metadata store.|string|1.6.0 kyuubi.metadata.store.jdbc.database.schema.init|true|Whether to init the jdbc metadata store database schema.|boolean|1.6.0 -kyuubi.metadata.store.jdbc.database.type|DERBY|The database type for server jdbc metadata store.
  • DERBY: Apache Derby, jdbc driver `org.apache.derby.jdbc.AutoloadedDriver`.
  • MYSQL: MySQL, jdbc driver `com.mysql.jdbc.Driver`.
  • CUSTOM: User-defined database type, need specify the jdbc driver in addition.
    • Note that: The jdbc datasource is powered by HiKariCP, for datasource properties, please specify them with prefix: kyuubi.server.metadata.store.jdbc.datasource. For example, kyuubi.server.metadata.store.jdbc.datasource.connectionTimeout=10000.|string|1.6.0 +kyuubi.metadata.store.jdbc.database.type|DERBY|The database type for server jdbc metadata store.
    • DERBY: Apache Derby, jdbc driver `org.apache.derby.jdbc.AutoloadedDriver`.
    • MYSQL: MySQL, jdbc driver `com.mysql.jdbc.Driver`.
    • CUSTOM: User-defined database type, need to specify corresponding jdbc driver.
      • Note that: The jdbc datasource is powered by HiKariCP, for datasource properties, please specify them with prefix: kyuubi.metadata.store.jdbc.datasource. For example, kyuubi.metadata.store.jdbc.datasource.connectionTimeout=10000.|string|1.6.0 kyuubi.metadata.store.jdbc.driver|<undefined>|JDBC driver class name for server jdbc metadata store.|string|1.6.0 kyuubi.metadata.store.jdbc.password||The password for server jdbc metadata store.|string|1.6.0 kyuubi.metadata.store.jdbc.url|jdbc:derby:memory:kyuubi_state_store_db;create=true|The jdbc url for server jdbc metadata store. By defaults, it is a DERBY in-memory database url, and the state information is not shared across kyuubi instances. To enable multiple kyuubi instances high available, please specify a production jdbc url.|string|1.6.0 diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala index bbc474c92..ba62e0f4a 100644 --- a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala +++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala @@ -40,10 +40,10 @@ object JDBCMetadataStoreConf { .doc("The database type for server jdbc metadata store.
        " + "
      • DERBY: Apache Derby, jdbc driver `org.apache.derby.jdbc.AutoloadedDriver`.
        • " + "
      • MYSQL: MySQL, jdbc driver `com.mysql.jdbc.Driver`.
        • " + - "
      • CUSTOM: User-defined database type, need specify the jdbc driver in addition.
        • " + + "
      • CUSTOM: User-defined database type, need to specify corresponding jdbc driver.
        • " + " Note that: The jdbc datasource is powered by HiKariCP, for datasource properties," + - " please specify them with prefix: kyuubi.server.metadata.store.jdbc.datasource." + - " For example, kyuubi.server.metadata.store.jdbc.datasource.connectionTimeout=10000.") + " please specify them with prefix: kyuubi.metadata.store.jdbc.datasource." + + " For example, kyuubi.metadata.store.jdbc.datasource.connectionTimeout=10000.") .version("1.6.0") .stringConf .transform(_.toUpperCase(Locale.ROOT))