From 824aba60708c0973ee638eeb97d296e2f8dc737e Mon Sep 17 00:00:00 2001
From: zwangsheng <2213335496@qq.com>
Date: Tue, 21 Mar 2023 21:05:57 +0800
Subject: [PATCH] [KYUUBI #3646][Improvement][UI] Front-end style should
 bracket same line

### _Why are the changes needed?_

Should bracket same line.

According to https://github.com/npetruzzelli/prettier-config-standard, should set true to bracketSameLine and also drop jsxBracketSameLine, which been deprecated.

Close #3646

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

- [x] CI

Closes #4571 from zwangsheng/KYUUBI_4570.

Closes #3646

2b61d1173 [zwangsheng] [KYUUBI #3646] bracket same line

Authored-by: zwangsheng <2213335496@qq.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
---
 kyuubi-server/web-ui/.prettierrc                         | 2 +-
 kyuubi-server/web-ui/src/components/menu/index.vue       | 9 +++------
 .../web-ui/src/views/layout/components/header/index.vue  | 3 +--
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/kyuubi-server/web-ui/.prettierrc b/kyuubi-server/web-ui/.prettierrc
index 1fceefb98..01db7f49b 100644
--- a/kyuubi-server/web-ui/.prettierrc
+++ b/kyuubi-server/web-ui/.prettierrc
@@ -4,7 +4,7 @@
   "vueIndentScriptAndStyle": true,
   "singleQuote": true,
   "quoteProps": "as-needed",
-  "jsxBracketSameLine": false,
+  "bracketSameLine": true,
   "jsxSingleQuote": true,
   "arrowParens": "always",
   "htmlWhitespaceSensitivity": "strict",
diff --git a/kyuubi-server/web-ui/src/components/menu/index.vue b/kyuubi-server/web-ui/src/components/menu/index.vue
index b563b491e..d6d4d1b56 100644
--- a/kyuubi-server/web-ui/src/components/menu/index.vue
+++ b/kyuubi-server/web-ui/src/components/menu/index.vue
@@ -21,14 +21,12 @@
     class="el-menu-container"
     :collapse="isCollapse"
     :default-active="activePath"
-    :router="true"
-  >
+    :router="true">
     <template v-for="(menu, index) in menus">
       <el-menu-item
         v-if="!menu.children || menu.children.length === 0"
         :key="index + '-1'"
-        :index="menu.router"
-      >
+        :index="menu.router">
         <el-icon>
           <component :is="menu.icon" />
         </el-icon>
@@ -44,8 +42,7 @@
         <el-menu-item
           v-for="(child, index2) in menu.children"
           :key="index2"
-          :index="child.router"
-        >
+          :index="child.router">
           <el-icon :size="16">
             <component :is="child.icon" />
           </el-icon>
diff --git a/kyuubi-server/web-ui/src/views/layout/components/header/index.vue b/kyuubi-server/web-ui/src/views/layout/components/header/index.vue
index 5c9bb2a3a..ada2a8605 100644
--- a/kyuubi-server/web-ui/src/views/layout/components/header/index.vue
+++ b/kyuubi-server/web-ui/src/views/layout/components/header/index.vue
@@ -33,8 +33,7 @@
           <el-dropdown-item
             v-for="(locale, key) in locales"
             :key="key"
-            :command="locale.key"
-          >
+            :command="locale.key">
             {{ locale.label }}
           </el-dropdown-item>
         </el-dropdown-menu>