[KYUUBI #1134] [TEST] DataLake suites should clean up withKyuubiConf instead of extraConfigs

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
Keep consistent with
```
    withKyuubiConf.foreach { case (k, v) =>
      System.setProperty(k, v)
      kyuubiConf.set(k, v)
    }
```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1134 from pan3793/t.

Closes #1134

b8e0aa65 [Cheng Pan] [TEST] DataLake Suites should clean up withKyuubiConf instead of extraConfigs

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
This commit is contained in:
Cheng Pan 2021-09-23 09:31:29 +08:00
parent bd0989487d
commit 787ba9efe2
No known key found for this signature in database
GPG Key ID: 8001952629BCC75D
3 changed files with 8 additions and 3 deletions

View File

@ -23,12 +23,14 @@ import org.apache.kyuubi.tags.DeltaTest
@DeltaTest
class SparkDeltaOperationSuite extends WithSparkSQLEngine with BasicDeltaJDBCTests {
override protected def jdbcUrl: String = getJdbcUrl
override def withKyuubiConf: Map[String, String] = extraConfigs
override def afterAll(): Unit = {
super.afterAll()
for ((k, _) <- extraConfigs) {
for ((k, _) <- withKyuubiConf) {
System.clearProperty(k)
}
}

View File

@ -23,13 +23,14 @@ import org.apache.kyuubi.tags.HudiTest
@HudiTest
class SparkHudiOperationSuite extends WithSparkSQLEngine with BasicHudiJDBCTests {
override protected def jdbcUrl: String = getJdbcUrl
override def withKyuubiConf: Map[String, String] = extraConfigs
override def afterAll(): Unit = {
super.afterAll()
for ((k, _) <- extraConfigs) {
for ((k, _) <- withKyuubiConf) {
System.clearProperty(k)
}
}

View File

@ -23,12 +23,14 @@ import org.apache.kyuubi.tags.IcebergTest
@IcebergTest
class SparkIcebergOperationSuite extends WithSparkSQLEngine with BasicIcebergJDBCTests {
override protected def jdbcUrl: String = getJdbcUrl
override def withKyuubiConf: Map[String, String] = extraConfigs
override def afterAll(): Unit = {
super.afterAll()
for ((k, _) <- extraConfigs) {
for ((k, _) <- withKyuubiConf) {
System.clearProperty(k)
}
}